diff mbox

Add configure.nat as a dependency of config.status

Message ID 1528122903-16122-1-git-send-email-simon.marchi@ericsson.com
State New, archived
Headers

Commit Message

Simon Marchi June 4, 2018, 2:35 p.m. UTC 
  After pulling Alan's change that added aarch64-sve-linux-ptrace.o to
configure.nat, I got an undefined reference to aarch64_sve_get_vq when
doing a "make clean && make".  It turns out that re-running configure
(./config.status --recheck) was needed to re-generate the Makefile with
aarch64-sve-linux-ptrace.o included in the object list.  Putting
configure.nat in the dependencies of config.status would make sure that
when we modify configure.nat, the configure script is re-ran.  I think
it also makes sense because configure.tgt and configure.host are also
there.

gdb/ChangeLog:

	* Makefile.in (config.status): Add configure.nat as a
	dependency.
---
 gdb/Makefile.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Pedro Alves June 4, 2018, 2:36 p.m. UTC | #1 
On 06/04/2018 03:35 PM, Simon Marchi wrote:
> After pulling Alan's change that added aarch64-sve-linux-ptrace.o to
> configure.nat, I got an undefined reference to aarch64_sve_get_vq when
> doing a "make clean && make".  It turns out that re-running configure
> (./config.status --recheck) was needed to re-generate the Makefile with
> aarch64-sve-linux-ptrace.o included in the object list.  Putting
> configure.nat in the dependencies of config.status would make sure that
> when we modify configure.nat, the configure script is re-ran.  I think
> it also makes sense because configure.tgt and configure.host are also
> there.
> 
> gdb/ChangeLog:
> 
> 	* Makefile.in (config.status): Add configure.nat as a
> 	dependency.

Makes sense.

Thanks,
Pedro Alves
Simon Marchi June 4, 2018, 2:41 p.m. UTC | #2 
On 2018-06-04 10:36, Pedro Alves wrote:
> On 06/04/2018 03:35 PM, Simon Marchi wrote:
>> After pulling Alan's change that added aarch64-sve-linux-ptrace.o to
>> configure.nat, I got an undefined reference to aarch64_sve_get_vq when
>> doing a "make clean && make".  It turns out that re-running configure
>> (./config.status --recheck) was needed to re-generate the Makefile 
>> with
>> aarch64-sve-linux-ptrace.o included in the object list.  Putting
>> configure.nat in the dependencies of config.status would make sure 
>> that
>> when we modify configure.nat, the configure script is re-ran.  I think
>> it also makes sense because configure.tgt and configure.host are also
>> there.
>> 
>> gdb/ChangeLog:
>> 
>> 	* Makefile.in (config.status): Add configure.nat as a
>> 	dependency.
> 
> Makes sense.
> 
> Thanks,
> Pedro Alves

Thanks, I pushed it.

Simon
diff mbox

Patch

diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index a0e5b7e..354a636 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -2068,7 +2068,7 @@  stamp-h: $(srcdir)/config.in config.status
 	  CONFIG_LINKS= \
 	  $(SHELL) config.status
 
-config.status: $(srcdir)/configure configure.tgt configure.host ../bfd/development.sh
+config.status: $(srcdir)/configure configure.nat configure.tgt configure.host ../bfd/development.sh
 	$(SHELL) config.status --recheck
 
 ACLOCAL = aclocal