diff mbox

[3/4] gdb: Run INF_EXEC_COMPLETE handler for additional cases

Message ID 59b1b9214bf0db884bf2eefcdacbf4e148137e57.1527157948.git.andrew.burgess@embecosm.com
State New, archived
Headers

Commit Message

Andrew Burgess May 24, 2018, 10:50 a.m. UTC 
  When making an inferior call, and non-stop mode is off, then, once the
inferior call is complete all threads will be stopped, and we should
run the INF_EXEC_COMPLETE handler.  This will result in a call to
'target_async(0)' to remove the event handlers for the target.

This was discussed by Yao Qi in this mailing list thread:

    https://sourceware.org/ml/gdb/2017-10/msg00032.html

Without this then the target event handlers are left in place even
when the target is stopped, which is different to what happens during
a standard stop proceedure (for example when one thread hits a
breakpoint).

gdb/ChangeLog:

	PR gdb/22882
	* infrun.c (fetch_inferior_event): If GDB is not proceeding then
	run INF_EXEC_COMPLETE handler, even when not calling normal_stop.
	Move should_notify_stop local into more inner scope.
---
 gdb/ChangeLog |  8 ++++++++
 gdb/infrun.c  | 16 ++++++++--------
 2 files changed, 16 insertions(+), 8 deletions(-)

Comments

Pedro Alves June 11, 2018, 6:02 p.m. UTC | #1 
On 05/24/2018 11:50 AM, Andrew Burgess wrote:
> When making an inferior call, and non-stop mode is off, then, once the
> inferior call is complete all threads will be stopped, and we should
> run the INF_EXEC_COMPLETE handler.  This will result in a call to
> 'target_async(0)' to remove the event handlers for the target.
> 
> This was discussed by Yao Qi in this mailing list thread:
> 
>     https://sourceware.org/ml/gdb/2017-10/msg00032.html
> 
> Without this then the target event handlers are left in place even
> when the target is stopped, which is different to what happens during
> a standard stop proceedure (for example when one thread hits a
> breakpoint).
> 
> gdb/ChangeLog:
> 
> 	PR gdb/22882
> 	* infrun.c (fetch_inferior_event): If GDB is not proceeding then
> 	run INF_EXEC_COMPLETE handler, even when not calling normal_stop.
> 	Move should_notify_stop local into more inner scope.

OK.

Thanks,
Pedro Alves
diff mbox

Patch

diff --git a/gdb/infrun.c b/gdb/infrun.c
index 1c4cd55e8f3..80721e822ab 100644
--- a/gdb/infrun.c
+++ b/gdb/infrun.c
@@ -3932,7 +3932,6 @@  fetch_inferior_event (void *client_data)
       struct inferior *inf = find_inferior_ptid (ecs->ptid);
       int should_stop = 1;
       struct thread_info *thr = ecs->event_thread;
-      int should_notify_stop = 1;
 
       delete_just_stopped_threads_infrun_breakpoints ();
 
@@ -3950,6 +3949,9 @@  fetch_inferior_event (void *client_data)
 	}
       else
 	{
+	  int should_notify_stop = 1;
+	  int proceeded = 0;
+
 	  clean_up_just_stopped_threads_fsms (ecs);
 
 	  if (thr != NULL && thr->thread_fsm != NULL)
@@ -3960,17 +3962,15 @@  fetch_inferior_event (void *client_data)
 
 	  if (should_notify_stop)
 	    {
-	      int proceeded = 0;
-
 	      /* We may not find an inferior if this was a process exit.  */
 	      if (inf == NULL || inf->control.stop_soon == NO_STOP_QUIETLY)
 		proceeded = normal_stop ();
+	    }
 
-	      if (!proceeded)
-		{
-		  inferior_event_handler (INF_EXEC_COMPLETE, NULL);
-		  cmd_done = 1;
-		}
+	  if (!proceeded)
+	    {
+	      inferior_event_handler (INF_EXEC_COMPLETE, NULL);
+	      cmd_done = 1;
 	    }
 	}
     }