[RFA,42/42] Remove record_line_ftype
Commit Message
The record_line_ftype typedef was only used in the DWARF reader, and
we removed those uses a few patches ago. So, remove the typedef.
gdb/ChangeLog
2018-05-22 Tom Tromey <tom@tromey.com>
* legacy-buildsym.h (record_line): Don't use record_line_ftype.
* buildsym.h (record_line_ftype): Remove typedef.
---
gdb/ChangeLog | 5 +++++
gdb/buildsym.h | 4 ----
gdb/legacy-buildsym.h | 2 +-
3 files changed, 6 insertions(+), 5 deletions(-)
Comments
On 2018-05-23 12:58 AM, Tom Tromey wrote:
> The record_line_ftype typedef was only used in the DWARF reader, and
> we removed those uses a few patches ago. So, remove the typedef.
LGTM.
Simon
PS: Thanks for splitting the series the way you did. 42 patches looks like a lot,
but it was actually much easier to understand and review like this than if it had
been 4-5 big patches.
@@ -399,10 +399,6 @@ private:
struct pending *m_local_symbols = nullptr;
};
-/* The type of the record_line function. */
-typedef void (record_line_ftype) (struct subfile *subfile, int line,
- CORE_ADDR pc);
-
extern void add_symbol_to_list (struct symbol *symbol,
@@ -79,7 +79,7 @@ extern struct context_stack *push_context (int desc, CORE_ADDR valu);
extern struct context_stack *pop_context (void);
-extern record_line_ftype record_line;
+extern void record_line (struct subfile *subfile, int line, CORE_ADDR pc);
extern struct compunit_symtab *start_symtab (struct objfile *objfile,
const char *name,