[RFA,10/42] Move some code from buildsym to stabsread

  A few things that currently reside in buildsym.c turn out to be
specific to the stabs reader.  This patch moves these from
buildsym.[ch] to stabsread.[ch].

gdb/ChangeLog
2018-05-22  Tom Tromey  <tom@tromey.com>

	* stabsread.h (HASHSIZE, hashname, symnum, next_symbol_text)
	(next_symbol_text_func): Move from buildsym.h.
	* stabsread.c (hashname): Move from buildsym.c.
	* buildsym.h (HASHSIZE, symnum, next_symbol_text)
	(next_symbol_text_func, hashname): Move to stabsread.h.
	* buildsym.c: Don't include bcache.h
	(hashname): Move to stasbread.c.
---
 gdb/ChangeLog   | 10 ++++++++++
 gdb/buildsym.c  | 10 ----------
 gdb/buildsym.h  | 15 ---------------
 gdb/stabsread.c | 13 +++++++++++++
 gdb/stabsread.h | 15 +++++++++++++++
 5 files changed, 38 insertions(+), 25 deletions(-)
  

I just have one comment:

On 05/22/2018 09:58 PM, Tom Tromey wrote:
> diff --git a/gdb/stabsread.c b/gdb/stabsread.c
> index 4cfefaa3e0..13663106dc 100644
> --- a/gdb/stabsread.c
> +++ b/gdb/stabsread.c
> @@ -44,6 +44,7 @@
>  #include "target-float.h"
>  #include "cp-abi.h"
>  #include "cp-support.h"
> +#include "bcache.h"
>  #include <ctype.h>
>  
>  /* Ask stabsread.h to define the vars it normally declares `extern'.  */
> @@ -4839,6 +4840,18 @@ find_name_end (const char *name)
>      }
>  }
>  
> +
> +
> +/* Compute a small integer hash code for the given name.  */
> +
> +int
> +hashname (const char *name)
> +{
> +  return hash (name, strlen (name)) % HASHSIZE;
> +}
> +
> +
> +
>  /* Initializer for this module.  */
>  
>  void

Seems some superfluous newlines got pasted in here?
Please use "See stabsread.h" and move the comment into the header.

Okay, that's actually two comments, but one is so trivial, I didn't count it.

Keith
  

On 2018-07-05 03:16 PM, Keith Seitz wrote:
> I just have one comment:
> 
> On 05/22/2018 09:58 PM, Tom Tromey wrote:
>> diff --git a/gdb/stabsread.c b/gdb/stabsread.c
>> index 4cfefaa3e0..13663106dc 100644
>> --- a/gdb/stabsread.c
>> +++ b/gdb/stabsread.c
>> @@ -44,6 +44,7 @@
>>  #include "target-float.h"
>>  #include "cp-abi.h"
>>  #include "cp-support.h"
>> +#include "bcache.h"
>>  #include <ctype.h>
>>  
>>  /* Ask stabsread.h to define the vars it normally declares `extern'.  */
>> @@ -4839,6 +4840,18 @@ find_name_end (const char *name)
>>      }
>>  }
>>  
>> +
>> +
>> +/* Compute a small integer hash code for the given name.  */
>> +
>> +int
>> +hashname (const char *name)
>> +{
>> +  return hash (name, strlen (name)) % HASHSIZE;
>> +}
>> +
>> +
>> +
>>  /* Initializer for this module.  */
>>  
>>  void
> 
> Seems some superfluous newlines got pasted in here?

The newline in the middle is actually a form feed character, as recommended in the
GNU coding standards [1]:

"Please use formfeed characters (control-L) to divide the program into pages at logical
places (but not within a function). It does not matter just how long the pages are,
since they do not have to fit on a printed page. The formfeeds should appear alone on
lines by themselves."

I'd be really curious to know if anybody cares about them today.  I know in some
editors you can jump from on to the other.  In my editor, they just appear as the
little "special character" box with the ascii/unicode in it.

[1] https://www.gnu.org/prep/standards/html_node/Formatting.html

> Please use "See stabsread.h" and move the comment into the header.
> 
> Okay, that's actually two comments, but one is so trivial, I didn't count it.
> 
> Keith
> 

LGTM with Keith's comment about the comment addressed.

Simon
  

>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

Keith> Seems some superfluous newlines got pasted in here?

I usually put lines around the ^Ls, but it doesn't matter to me so I
removed them.

Keith> Please use "See stabsread.h" and move the comment into the header.

I did this.

Tom
  

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

Simon> The newline in the middle is actually a form feed character, as recommended in the
Simon> GNU coding standards [1]:

Hah, it didn't even occur to me that these wouldn't have shown up, but
that's probably what happened.

Simon> I'd be really curious to know if anybody cares about them today.  I know in some
Simon> editors you can jump from on to the other.  In my editor, they just appear as the
Simon> little "special character" box with the ascii/unicode in it.

I use them as indicators of "this group of functions belongs together",
but I don't actually use the page navigation functions in Emacs.  Also
there's a historical / habitual component to adding them; it's long been
part of the GNU style.

Maybe having more and smaller files would be a better approach to what I
use them for.  Though of course that's not without its costs.

Tom