diff mbox

[RFA,14/42] Move scan_file_globals declaration to stabsread.h

Message ID 20180523045851.11660-15-tom@tromey.com
State New, archived
Headers

Commit Message

Tom Tromey May 23, 2018, 4:58 a.m. UTC 
  scan_file_globals is defined in stabsread.c, so move its declaration
to stabsread.h.

gdb/ChangeLog
2018-05-22  Tom Tromey  <tom@tromey.com>

	* stabsread.h (scan_file_globals): Move from buildsym.h.
	* buildsym.h (scan_file_globals): Move to stabsread.h.
---
 gdb/ChangeLog   | 5 +++++
 gdb/buildsym.h  | 4 ----
 gdb/stabsread.h | 2 ++
 3 files changed, 7 insertions(+), 4 deletions(-)

Comments

Simon Marchi July 8, 2018, 4:52 p.m. UTC | #1 
On 2018-05-23 12:58 AM, Tom Tromey wrote:
> scan_file_globals is defined in stabsread.c, so move its declaration
> to stabsread.h.

LGTM, though can you move the comment to the .h and add the usual "See..."?

Simon
Tom Tromey July 9, 2018, 11:07 p.m. UTC | #2 
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

Simon> On 2018-05-23 12:58 AM, Tom Tromey wrote:
>> scan_file_globals is defined in stabsread.c, so move its declaration
>> to stabsread.h.

Simon> LGTM, though can you move the comment to the .h and add the usual "See..."?

I did this.

Tom
diff mbox

Patch

diff --git a/gdb/buildsym.h b/gdb/buildsym.h
index 77fc5bdd3c..f70777946a 100644
--- a/gdb/buildsym.h
+++ b/gdb/buildsym.h
@@ -205,10 +205,6 @@  extern struct compunit_symtab *end_expandable_symtab (CORE_ADDR end_addr,
 
 extern void augment_type_symtab (void);
 
-/* Defined in stabsread.c.  */
-
-extern void scan_file_globals (struct objfile *objfile);
-
 extern void buildsym_init ();
 
 extern struct context_stack *push_context (int desc, CORE_ADDR valu);
diff --git a/gdb/stabsread.h b/gdb/stabsread.h
index ce254e65d0..a5f327012d 100644
--- a/gdb/stabsread.h
+++ b/gdb/stabsread.h
@@ -221,4 +221,6 @@  extern void free_header_files (void);
 
 extern void init_header_files (void);
 
+extern void scan_file_globals (struct objfile *objfile);
+
 #undef EXTERN