diff mbox

New ARI warning Fri May 18 01:56:48 UTC 2018

Message ID 4f3b5ef9-f310-c4a3-a122-fe15aed41ab1@ericsson.com
State New, archived
Headers

Commit Message

Simon Marchi May 18, 2018, 7:49 p.m. UTC 
  On 2018-05-18 03:14 PM, Simon Marchi wrote:
> On 2018-05-18 15:03, Joel Brobecker wrote:
>> Right, which is why I formulated this as a question. I don't really
>> know what style we want there. But since it was easy to patch the
>> script, I thought I'd send that right away, to show one of the options.
>> But I'd be OK with deciding that unittests/ should follow the GDB
>> coding standards.
> 
> I think we can just add the /* ARI: ... */ comments, I'll try it later.  I don't see any reason why it would be harder in general to follow our code conventions in unit tests than anywhere else.  This case is just a bit of a special one.

Here's what I pushed:

From 1d143c36eedc0f0b124e6aa6fb3b98b1e6ff74b0 Mon Sep 17 00:00:00 2001
From: Simon Marchi <simon.marchi@ericsson.com>
Date: Fri, 18 May 2018 15:47:56 -0400
Subject: [PATCH] format_pieces-selftests.c: Silence ARI warnings

Silence this:

unittests/format_pieces-selftests.c:51: warning: code: Do not use printf("%ll"), instead use printf("%s",phex()) to dump a `long long' value
unittests/format_pieces-selftests.c:56: warning: code: Do not use printf("%ll"), instead use printf("%s",phex()) to dump a `long long' value

gdb/ChangeLog:

	* unittests/format_pieces-selftests.c (test_format_specifier):
	Add ARI comments.
---
 gdb/ChangeLog                           | 5 +++++
 gdb/unittests/format_pieces-selftests.c | 4 ++--
 2 files changed, 7 insertions(+), 2 deletions(-)
diff mbox

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index d4d00f8..57edb23 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@ 
+2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
+
+	* unittests/format_pieces-selftests.c (test_format_specifier):
+	Add ARI comments.
+
 2018-05-18  Tom Tromey  <tom@tromey.com>

 	* c-typeprint.c (maybe_print_hole): New function.
diff --git a/gdb/unittests/format_pieces-selftests.c b/gdb/unittests/format_pieces-selftests.c
index 6d11a9c..8f63247 100644
--- a/gdb/unittests/format_pieces-selftests.c
+++ b/gdb/unittests/format_pieces-selftests.c
@@ -48,12 +48,12 @@  test_escape_sequences ()
 static void
 test_format_specifier ()
 {
-  check ("Hello %d%llx%%d",
+  check ("Hello %d%llx%%d", /* ARI: %ll */
     {
       format_piece ("Hello ", literal_piece),
       format_piece ("%d", int_arg),
       format_piece ("", literal_piece),
-      format_piece ("%llx", long_long_arg),
+      format_piece ("%llx", long_long_arg), /* ARI: %ll */
       format_piece ("%%d", literal_piece),
     });
 }