Patchwork [committed] MIPS: Make `mask_address_var' static

login
register
mail settings
Submitter Maciej W. Rozycki
Date May 15, 2018, 3:03 p.m.
Message ID <alpine.DEB.2.00.1805151556510.10896@tp.orcam.me.uk>
Download mbox | patch
Permalink /patch/27271/
State Committed
Headers show

Comments

Maciej W. Rozycki - May 15, 2018, 3:03 p.m.
Make the `mask_address_var' variable static, it is not used outside 
mips-tdep.c and having no target name embedded within it causes a risk 
of a namespace clash.

	gdb/
	* mips-tdep.c (mask_address_var): Make variable static.
---
 gdb/mips-tdep.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

gdb-mips-mask-address-var-static.diff

Patch

Index: binutils/gdb/mips-tdep.c
===================================================================
--- binutils.orig/gdb/mips-tdep.c	2018-04-16 13:54:45.000000000 +0100
+++ binutils/gdb/mips-tdep.c	2018-04-16 15:19:15.149150666 +0100
@@ -1122,7 +1122,7 @@  mips_pseudo_register_type (struct gdbarc
 }
 
 /* Should the upper word of 64-bit addresses be zeroed?  */
-enum auto_boolean mask_address_var = AUTO_BOOLEAN_AUTO;
+static enum auto_boolean mask_address_var = AUTO_BOOLEAN_AUTO;
 
 static int
 mips_mask_address_p (struct gdbarch_tdep *tdep)