Patchwork powerpc: Move around math-related Implies

login
register
mail settings
Submitter Tulio Magno Quites Machado Filho
Date May 11, 2018, 7:35 p.m.
Message ID <20180511193538.4445-1-tuliom@linux.ibm.com>
Download mbox | patch
Permalink /patch/27247/
State Committed
Headers show

Comments

Tulio Magno Quites Machado Filho - May 11, 2018, 7:35 p.m.
Currently, powerpc, powerpc64, and powerpc64le imply the same set of
subdirectories from sysdeps/ieee754: flt-32, dbl-64, ldbl-128ibm, and
ldbl-opt.  In preparation for the transition of the long double format -
from IBM Extended Precision to IEEE 754 128-bits floating-point - on
powerpc64le, this patch splits the shared Implies file into three
separate files (one for each of the powerpc architectures), without
changing their contents.  Future patches will modify powerpc64le.

2018-05-11  Tulio Magno Quites Machado Filho  <tuliom@linux.ibm.com>
	    Gabriel F. T. Gomes  <gabriel@inconstante.eti.br>

	* sysdeps/powerpc/Implies: Removed.  Previous contents copied to...
	* sysdeps/powerpc/powerpc32/Implies-after: ... here.
	* sysdeps/powerpc/powerpc64/be/Implies-after: ... here.
	* sysdeps/powerpc/powerpc64/le/Implies-before: ... and here.
---
 sysdeps/powerpc/{Implies => powerpc32/Implies-after} | 0
 sysdeps/powerpc/powerpc64/be/Implies-after           | 5 +++++
 sysdeps/powerpc/powerpc64/le/Implies-before          | 5 +++++
 3 files changed, 10 insertions(+)
 rename sysdeps/powerpc/{Implies => powerpc32/Implies-after} (100%)
 create mode 100644 sysdeps/powerpc/powerpc64/be/Implies-after
Gabriel F. T. Gomes - May 11, 2018, 8:20 p.m.
On Fri, 11 May 2018, Tulio Magno Quites Machado Filho wrote:

>Currently, powerpc, powerpc64, and powerpc64le imply the same set of
>subdirectories from sysdeps/ieee754: flt-32, dbl-64, ldbl-128ibm, and
>ldbl-opt.  In preparation for the transition of the long double format -
>from IBM Extended Precision to IEEE 754 128-bits floating-point - on
>powerpc64le, this patch splits the shared Implies file into three
>separate files (one for each of the powerpc architectures), without
>changing their contents.  Future patches will modify powerpc64le.
>
>2018-05-11  Tulio Magno Quites Machado Filho  <tuliom@linux.ibm.com>
>	    Gabriel F. T. Gomes  <gabriel@inconstante.eti.br>
>
>	* sysdeps/powerpc/Implies: Removed.  Previous contents copied to...
>	* sysdeps/powerpc/powerpc32/Implies-after: ... here.
>	* sysdeps/powerpc/powerpc64/be/Implies-after: ... here.
>	* sysdeps/powerpc/powerpc64/le/Implies-before: ... and here.

Do we still need to use the "-after" and "-before" mechanism after this
change?
Tulio Magno Quites Machado Filho - May 11, 2018, 10:02 p.m.
"Gabriel F. T. Gomes" <gabriel@inconstante.eti.br> writes:

> On Fri, 11 May 2018, Tulio Magno Quites Machado Filho wrote:
>
>>Currently, powerpc, powerpc64, and powerpc64le imply the same set of
>>subdirectories from sysdeps/ieee754: flt-32, dbl-64, ldbl-128ibm, and
>>ldbl-opt.  In preparation for the transition of the long double format -
>>from IBM Extended Precision to IEEE 754 128-bits floating-point - on
>>powerpc64le, this patch splits the shared Implies file into three
>>separate files (one for each of the powerpc architectures), without
>>changing their contents.  Future patches will modify powerpc64le.
>>
>>2018-05-11  Tulio Magno Quites Machado Filho  <tuliom@linux.ibm.com>
>>	    Gabriel F. T. Gomes  <gabriel@inconstante.eti.br>
>>
>>	* sysdeps/powerpc/Implies: Removed.  Previous contents copied to...
>>	* sysdeps/powerpc/powerpc32/Implies-after: ... here.
>>	* sysdeps/powerpc/powerpc64/be/Implies-after: ... here.
>>	* sysdeps/powerpc/powerpc64/le/Implies-before: ... and here.
>
> Do we still need to use the "-after" and "-before" mechanism after this
> change?

Yes.  Without them the sysdeps order would be different.
Gabriel F. T. Gomes - May 24, 2018, 2:02 p.m.
On Fri, 11 May 2018, Tulio Magno Quites Machado Filho wrote:

>"Gabriel F. T. Gomes" <gabriel@inconstante.eti.br> writes:
>
>> On Fri, 11 May 2018, Tulio Magno Quites Machado Filho wrote:
>>  
>>>	* sysdeps/powerpc/Implies: Removed.  Previous contents copied to...
>>>	* sysdeps/powerpc/powerpc32/Implies-after: ... here.
>>>	* sysdeps/powerpc/powerpc64/be/Implies-after: ... here.
>>>	* sysdeps/powerpc/powerpc64/le/Implies-before: ... and here.  
>>
>> Do we still need to use the "-after" and "-before" mechanism after this
>> change?  
>
>Yes.  Without them the sysdeps order would be different.

OK, then.  The patch looks good to me.
Tulio Magno Quites Machado Filho - May 25, 2018, 1:51 a.m.
"Gabriel F. T. Gomes" <gabriel@inconstante.eti.br> writes:

> On Fri, 11 May 2018, Tulio Magno Quites Machado Filho wrote:
>
>>"Gabriel F. T. Gomes" <gabriel@inconstante.eti.br> writes:
>>
>>> On Fri, 11 May 2018, Tulio Magno Quites Machado Filho wrote:
>>>  
>>>>	* sysdeps/powerpc/Implies: Removed.  Previous contents copied to...
>>>>	* sysdeps/powerpc/powerpc32/Implies-after: ... here.
>>>>	* sysdeps/powerpc/powerpc64/be/Implies-after: ... here.
>>>>	* sysdeps/powerpc/powerpc64/le/Implies-before: ... and here.  
>>>
>>> Do we still need to use the "-after" and "-before" mechanism after this
>>> change?  
>>
>>Yes.  Without them the sysdeps order would be different.
>
> OK, then.  The patch looks good to me.

Committed as c1dc1e1b3487.

Thanks!

Patch

diff --git a/sysdeps/powerpc/Implies b/sysdeps/powerpc/powerpc32/Implies-after
similarity index 100%
rename from sysdeps/powerpc/Implies
rename to sysdeps/powerpc/powerpc32/Implies-after
diff --git a/sysdeps/powerpc/powerpc64/be/Implies-after b/sysdeps/powerpc/powerpc64/be/Implies-after
new file mode 100644
index 0000000000..78dba9510c
--- /dev/null
+++ b/sysdeps/powerpc/powerpc64/be/Implies-after
@@ -0,0 +1,5 @@ 
+# On PowerPC we use the IBM extended long double format.
+ieee754/ldbl-128ibm
+ieee754/ldbl-opt
+ieee754/dbl-64
+ieee754/flt-32
diff --git a/sysdeps/powerpc/powerpc64/le/Implies-before b/sysdeps/powerpc/powerpc64/le/Implies-before
index 48065141a9..7c20db4e97 100644
--- a/sysdeps/powerpc/powerpc64/le/Implies-before
+++ b/sysdeps/powerpc/powerpc64/le/Implies-before
@@ -1 +1,6 @@ 
+# On PowerPC we use the IBM extended long double format.
+ieee754/ldbl-128ibm
+ieee754/ldbl-opt
+ieee754/dbl-64
+ieee754/flt-32
 ieee754/float128