From patchwork Thu May 10 22:23:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 27217 Received: (qmail 46044 invoked by alias); 10 May 2018 22:24:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 42068 invoked by uid 89); 10 May 2018 22:24:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_HELO_PASS, TIME_LIMIT_EXCEEDED autolearn=unavailable version=3.3.2 spammy=UD:build-id.h, Forward, buildidh, build-id.h X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.200.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 May 2018 22:24:07 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway36.websitewelcome.com (Postfix) with ESMTP id F2E17400F2265 for ; Thu, 10 May 2018 17:24:04 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id GtymfFDdEbXuJGtymfZ3qt; Thu, 10 May 2018 17:24:04 -0500 X-Authority-Reason: nr=8 Received: from 97-122-176-117.hlrn.qwest.net ([97.122.176.117]:54520 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1fGtym-001ijL-O7; Thu, 10 May 2018 17:24:04 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFA 01/15] Move some declarations to mdebugread.h Date: Thu, 10 May 2018 16:23:43 -0600 Message-Id: <20180510222357.27332-2-tom@tromey.com> In-Reply-To: <20180510222357.27332-1-tom@tromey.com> References: <20180510222357.27332-1-tom@tromey.com> X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fGtym-001ijL-O7 X-Source-Sender: 97-122-176-117.hlrn.qwest.net (bapiya.Home) [97.122.176.117]:54520 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes This moves a couple of mdebugread-related declarations from symfile.h to mdebugread.h, which seemed more appropriate. gdb/ChangeLog 2018-05-09 Tom Tromey * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs): Don't declare. * mipsread.c: Include mdebugread.h. * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs): Declare. * elfread.c: Include mdebugread.h. --- gdb/ChangeLog | 9 +++++++++ gdb/elfread.c | 1 + gdb/mdebugread.h | 9 +++++++++ gdb/mipsread.c | 1 + gdb/symfile.h | 11 ----------- 5 files changed, 20 insertions(+), 11 deletions(-) diff --git a/gdb/elfread.c b/gdb/elfread.c index b4b4a1b24c..ac3a17a890 100644 --- a/gdb/elfread.c +++ b/gdb/elfread.c @@ -47,6 +47,7 @@ #include "build-id.h" #include "location.h" #include "auxv.h" +#include "mdebugread.h" /* Forward declarations. */ extern const struct sym_fns elf_sym_fns_gdb_index; diff --git a/gdb/mdebugread.h b/gdb/mdebugread.h index a3a0c57a5e..817c5072a8 100644 --- a/gdb/mdebugread.h +++ b/gdb/mdebugread.h @@ -37,4 +37,13 @@ struct mdebug_extra_func_info #define MDEBUG_EFI_SYMBOL_NAME "__GDB_EFI_INFO__" +extern void mdebug_build_psymtabs (minimal_symbol_reader &, + struct objfile *, + const struct ecoff_debug_swap *, + struct ecoff_debug_info *); + +extern void elfmdebug_build_psymtabs (struct objfile *, + const struct ecoff_debug_swap *, + asection *); + #endif /* MDEBUGREAD_H */ diff --git a/gdb/mipsread.c b/gdb/mipsread.c index 7b6ec2e48d..bff56b9b55 100644 --- a/gdb/mipsread.c +++ b/gdb/mipsread.c @@ -29,6 +29,7 @@ #include "objfiles.h" #include "buildsym.h" #include "stabsread.h" +#include "mdebugread.h" #include "coff/sym.h" #include "coff/internal.h" diff --git a/gdb/symfile.h b/gdb/symfile.h index 358e42b3f2..9c149c8922 100644 --- a/gdb/symfile.h +++ b/gdb/symfile.h @@ -610,17 +610,6 @@ extern void dwarf2_build_frame_info (struct objfile *); void dwarf2_free_objfile (struct objfile *); -/* From mdebugread.c */ - -extern void mdebug_build_psymtabs (minimal_symbol_reader &, - struct objfile *, - const struct ecoff_debug_swap *, - struct ecoff_debug_info *); - -extern void elfmdebug_build_psymtabs (struct objfile *, - const struct ecoff_debug_swap *, - asection *); - /* From minidebug.c. */ extern gdb_bfd_ref_ptr find_separate_debug_file_in_section (struct objfile *);