Patchwork [RFC,2/5] Remove mapped_index::total_size

login
register
mail settings
Submitter Simon Marchi
Date May 9, 2018, 9:26 p.m.
Message ID <1525901216-15031-3-git-send-email-simon.marchi@ericsson.com>
Download mbox | patch
Permalink /patch/27186/
State New
Headers show

Comments

Simon Marchi - May 9, 2018, 9:26 p.m.
It is unused.

gdb/ChangeLog:

	* dwarf2read.c (mapped_index) <total_size>: Remove.
---
 gdb/dwarf2read.c | 4 ----
 1 file changed, 4 deletions(-)
Tom Tromey - May 10, 2018, 8:33 p.m.
>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:

Simon> It is unused.
Simon> gdb/ChangeLog:

Simon> 	* dwarf2read.c (mapped_index) <total_size>: Remove.

IMO this qualifies as obvious.

Tom
Simon Marchi - May 18, 2018, 8:04 p.m.
On 2018-05-10 04:33 PM, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:
> 
> Simon> It is unused.
> Simon> gdb/ChangeLog:
> 
> Simon> 	* dwarf2read.c (mapped_index) <total_size>: Remove.
> 
> IMO this qualifies as obvious.
> 
> Tom
> 

Right, I pushed it on its own.

Simon

Patch

diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index 823b498..1c72818 100644
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -197,9 +197,6 @@  struct mapped_index final : public mapped_index_base
   /* Index data format version.  */
   int version;
 
-  /* The total length of the buffer.  */
-  off_t total_size;
-
   /* The address table data.  */
   gdb::array_view<const gdb_byte> address_table;
 
@@ -3500,7 +3497,6 @@  to use the section anyway."),
     return 0;
 
   map->version = version;
-  map->total_size = section->size;
 
   metadata = (offset_type *) (addr + sizeof (offset_type));