From patchwork Tue May 8 12:27:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kratochvil X-Patchwork-Id: 27151 Received: (qmail 85443 invoked by alias); 8 May 2018 12:27:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 84805 invoked by uid 89); 8 May 2018 12:27:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 08 May 2018 12:27:37 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 408474029AF6; Tue, 8 May 2018 12:27:36 +0000 (UTC) Received: from host1.jankratochvil.net (unknown [10.36.118.9]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9ED39AFD53; Tue, 8 May 2018 12:27:33 +0000 (UTC) Date: Tue, 8 May 2018 14:27:30 +0200 From: Jan Kratochvil To: Ulrich Weigand Cc: Pedro Alves , Yao Qi , gdb-patches@sourceware.org Subject: [obv] watchpoint-unaligned.exp: Use skip_hw_watchpoint_tests [Re: [patch] aarch64: PR 19806: watchpoints: false negatives + PR 20207 contiguous ones] Message-ID: <20180508122730.GA177617@host1.jankratochvil.net> References: <20180501230606.GA3138797@host1.jankratochvil.net> <20180508120811.25BF1D804F5@oc3748833570.ibm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180508120811.25BF1D804F5@oc3748833570.ibm.com> User-Agent: Mutt/1.9.2 (2017-12-15) On Tue, 08 May 2018 14:08:11 +0200, Ulrich Weigand wrote: > Jan Kratochvil wrote: > > > PR breakpoints/19806 and support for PR external/20207. > > * gdb.base/watchpoint-unaligned.c: New file. > > * gdb.base/watchpoint-unaligned.exp: New file. > > These new tests all fail on SPU. It looks like the test requires > hardware watchpoints, should it check for [skip_hw_watchpoint_tests] ? I was not aware of skip_hw_watchpoint_tests, checked in as obvious. Thanks, Jan gdb/testsuite/ChangeLog 2018-05-08 Jan Kratochvil * gdb.base/watchpoint-unaligned.exp: Use skip_hw_watchpoint_tests. --- gdb/testsuite/ChangeLog | 4 ++++ gdb/testsuite/gdb.base/watchpoint-unaligned.exp | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 761fb7334c..d6db46916e 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2018-05-08 Jan Kratochvil + + * gdb.base/watchpoint-unaligned.exp: Use skip_hw_watchpoint_tests. + 2018-05-04 Tom Tromey PR python/22730: diff --git a/gdb/testsuite/gdb.base/watchpoint-unaligned.exp b/gdb/testsuite/gdb.base/watchpoint-unaligned.exp index 6bdd4b6d05..66358f2747 100644 --- a/gdb/testsuite/gdb.base/watchpoint-unaligned.exp +++ b/gdb/testsuite/gdb.base/watchpoint-unaligned.exp @@ -17,6 +17,10 @@ # Test inserting read watchpoints on unaligned addresses. +if {[skip_hw_watchpoint_tests]} { + return 0 +} + standard_testfile if { [prepare_for_testing ${testfile}.exp ${testfile} ${srcfile}] } { return -1