From patchwork Mon May 7 17:11:21 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Max Filippov X-Patchwork-Id: 27148 Received: (qmail 31504 invoked by alias); 7 May 2018 17:11:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 31469 invoked by uid 89); 7 May 2018 17:11:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.4 required=5.0 tests=BAYES_00, FREEMAIL_FROM, FROM_LOCAL_NOVOWEL, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=sends X-HELO: mail-lf0-f65.google.com Received: from mail-lf0-f65.google.com (HELO mail-lf0-f65.google.com) (209.85.215.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 07 May 2018 17:11:39 +0000 Received: by mail-lf0-f65.google.com with SMTP id x7-v6so6705215lff.13 for ; Mon, 07 May 2018 10:11:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=KGbhSEZLkv1lVQQO47wTRsfEByYgquezI4uNUmrV16w=; b=GoFAU3eDy/pDDh+kF9W+18630p0RhdYE6KzUaHLWxRTU+hnzirVxYz/cELTBaM6N1M dKsA7I19H4r9YGKUVpJiB3WNfSmWvtEXLGdUUbRHHjNcxV2DB6N4k8LqWEoL2jMiJ5o5 UmrJnKy0gzKRkssbKMeZEU8MV2YYIrED8EmQQndGcxQWgVd39psuNCIDmjJQevWZH9i+ idvoI3uTcnegh9WxHEaKq8wHO+F49GagvDW1M2YgFshKr8ABwTPQIk56E3CuksaJ1HMu 3TJ+gyQEno335w44KYuyruugtAnMjCZPCgBs4ROTg1qbGuoTZWZiEhPYP/kACHXArdsY Xx5g== X-Gm-Message-State: ALQs6tAmFnvp/mc4+v794nBlp9Bt20JX9x8tYVKAyY1LzazKLfgMXLRV ruMiw+FFQEW/80HOCupnaie3nA== X-Google-Smtp-Source: AB8JxZrDaQCzIONKE42vJhy8eOoRXiT2pIXNmgvEVh+gEP96/cHlCLuUg5mNMG5bCqloJsXfHPGb9g== X-Received: by 2002:a2e:1545:: with SMTP id 5-v6mr3682611ljv.56.1525713096257; Mon, 07 May 2018 10:11:36 -0700 (PDT) Received: from octofox.cadence.com (jcmvbkbc-1-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:1fa::2]) by smtp.gmail.com with ESMTPSA id v64-v6sm4348063lje.56.2018.05.07.10.11.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 May 2018 10:11:35 -0700 (PDT) From: Max Filippov To: gdb-patches@sourceware.org Cc: Woody LaRue , Pedro Alves , Max Filippov Subject: [PATCH v2] gdb: xtensa: handle privileged registers Date: Mon, 7 May 2018 10:11:21 -0700 Message-Id: <20180507171121.7746-1-jcmvbkbc@gmail.com> X-IsSubscribed: yes xtensa GDB may be used with both bare-metal and linux-based applications. In case of bare-metal application gdbserver is able to provide information about all CPU registers: both unprivileged and privileged. In case of linux-based application only a small subset of privileged state is available. Currently xtensa GDB only expects unprivileged registers in 'g' packets and it fails to communicate with server that sends both privileged and unprivileged registers. Allow bare-metal xtensa GDB to deal with both privileged and unprivileged registers by initializing tdep->num_regs with the total number of target CPU registers. Keep linux-based xtensa GDB functionality as is by copying tdep->num_nopriv_regs to tdep->num_regs. gdb/ 2018-05-07 Max Filippov * xtensa-linux-tdep.c (xtensa-tdep.h): New include. (xtensa_linux_init_abi): Limit tdep->num_regs by tdep->num_nopriv_regs. * xtensa-tdep.c (xtensa_derive_tdep): Calculate tdep->num_nopriv_regs and only copy it to tdep->num_regs if it's not initialized. --- Changes v1->v2: - expand description. gdb/xtensa-linux-tdep.c | 6 ++++++ gdb/xtensa-tdep.c | 12 ++++-------- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/gdb/xtensa-linux-tdep.c b/gdb/xtensa-linux-tdep.c index a9b30c73f7bf..b62085de2fcb 100644 --- a/gdb/xtensa-linux-tdep.c +++ b/gdb/xtensa-linux-tdep.c @@ -18,6 +18,7 @@ along with this program. If not, see . */ #include "defs.h" +#include "xtensa-tdep.h" #include "osabi.h" #include "linux-tdep.h" #include "solib-svr4.h" @@ -97,6 +98,11 @@ xtensa_linux_gdb_signal_to_target (struct gdbarch *gdbarch, static void xtensa_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch) { + struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch); + + if (tdep->num_nopriv_regs < tdep->num_regs) + tdep->num_regs = tdep->num_nopriv_regs; + linux_init_abi (info, gdbarch); set_solib_svr4_fetch_link_map_offsets diff --git a/gdb/xtensa-tdep.c b/gdb/xtensa-tdep.c index a1ecf5f56a42..01f96165dc8d 100644 --- a/gdb/xtensa-tdep.c +++ b/gdb/xtensa-tdep.c @@ -3145,16 +3145,12 @@ xtensa_derive_tdep (struct gdbarch_tdep *tdep) max_size = rmap->byte_size; if (rmap->mask != 0 && tdep->num_regs == 0) tdep->num_regs = n; - /* Find out out how to deal with priveleged registers. - - if ((rmap->flags & XTENSA_REGISTER_FLAGS_PRIVILEGED) != 0 - && tdep->num_nopriv_regs == 0) - tdep->num_nopriv_regs = n; - */ if ((rmap->flags & XTENSA_REGISTER_FLAGS_PRIVILEGED) != 0 - && tdep->num_regs == 0) - tdep->num_regs = n; + && tdep->num_nopriv_regs == 0) + tdep->num_nopriv_regs = n; } + if (tdep->num_regs == 0) + tdep->num_regs = tdep->num_nopriv_regs; /* Number of pseudo registers. */ tdep->num_pseudo_regs = n - tdep->num_regs;