From patchwork Mon Apr 16 20:50:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 26761 Received: (qmail 51231 invoked by alias); 16 Apr 2018 20:51:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 51219 invoked by uid 89); 16 Apr 2018 20:51:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.2 spammy=H*RU:Unknown_Domain, Hx-spam-relays-external:Unknown_Domain, HX-ClientProxiedBy:2603, HX-Exchange-Antispam-Report-CFA-Test:201703061406153 X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Apr 2018 20:51:29 +0000 Received: from ESESSHC020.ericsson.se (Unknown_Domain [153.88.183.78]) by sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id 55.CC.21035.ECC05DA5; Mon, 16 Apr 2018 22:51:26 +0200 (CEST) Received: from ESESBMB501.ericsson.se (153.88.183.168) by ESESSHC020.ericsson.se (153.88.183.78) with Microsoft SMTP Server (TLS) id 14.3.382.0; Mon, 16 Apr 2018 22:50:43 +0200 Received: from ESESBMB501.ericsson.se (153.88.183.168) by ESESBMB501.ericsson.se (153.88.183.168) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.26; Mon, 16 Apr 2018 22:50:42 +0200 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB501.ericsson.se (153.88.183.168) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.26 via Frontend Transport; Mon, 16 Apr 2018 22:50:42 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.48.218] (192.75.88.130) by DM5PR1501MB2007.namprd15.prod.outlook.com (2603:10b6:4:a1::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.675.14; Mon, 16 Apr 2018 20:50:40 +0000 Subject: [pushed] linux_spu_make_corefile_notes: return note_data instead of nullptr (was: [PATCH] Make target_read_alloc & al return vectors) To: Pedro Alves , References: <1521691401-21512-1-git-send-email-simon.marchi@ericsson.com> <8b2d798a-9383-4f98-0248-6a1a8d4fa1a2@redhat.com> From: Simon Marchi Message-ID: <27aef02a-2bb9-683a-2362-40cfad1174f4@ericsson.com> Date: Mon, 16 Apr 2018 16:50:08 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <8b2d798a-9383-4f98-0248-6a1a8d4fa1a2@redhat.com> X-ClientProxiedBy: DM5PR19CA0043.namprd19.prod.outlook.com (2603:10b6:3:9a::29) To DM5PR1501MB2007.namprd15.prod.outlook.com (2603:10b6:4:a1::37) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DM5PR1501MB2007; X-Microsoft-Exchange-Diagnostics: 1; DM5PR1501MB2007; 3:zZgrqk6syh3dAw7fB0UETEbiqH4dO5gzJlH24GTM6+E/NbGsoB6gQnsEPegIgKOtDA1f9agWyKHghD+c2MknFHsUSXJHRtabDBU1gjPdjJo1pMFqGNzFEab+gqfs0wqjLNFjO+lyNQLp5w+KPZ/dsccUP/L7r85xhAvJaXNn84bPv3YVCvdt0SfETXtnsv8IKCCb+RSkXFBKImRm0GFOqXj1HalgviBu/+8qUbXRsOj2np7qMNcLPMwN1y7CVglm; 25:6tb6kCg0Llm8+DllFR3+8Y8qP/Y4Zn+O8aXw+VMCMie93Kg1h8YhFb0Y00M5kRZ3C0fTtbgbDiH9gDWVLfqXuEdSx5gTR4PEV7o9UVaZraaWgIsl8DMN0Zyf3RyVoogrM6YCpI4rTgSyelVoW2+BmSznPtBMXEP04LYf7aIt6UbCcSx3zBSiIPZDfjfw9KFZrlIQE0//NPsrlAfZYfuh/MeAKr+xDwruZH5NGsRGSDbDKOtP5csp/GqVVJelnC6tbpmBjobYD4GgeGk8lDcFSi/ggaTGUxI1XGFDbTqmIDZYFVbzOm8JSrvGLXXJ+D0fPFNXrcVienFBYpr4pfZOAg==; 31:Q3c2P2w2EkcscI+K/VAjsSvP/FV38co07CajH5ZC1j+47NAGxIMB/y8CclEZjuY8Z3Tng9msRnLsb2zid8IpTIWQbiumLBxdCD/jCb0YsqkFJ3FU9W2Cni1dEDNo8YKOVrnqC0d84REY/IjJ4ng3iU/NStAoVG9v+Yzez8LIMyrIIfSyw7xYHIVerXxiiPA4f1ic7SN47qdTs0xSvwXYsTI3wqUngcBhSylEXrbd4cI= X-MS-TrafficTypeDiagnostic: DM5PR1501MB2007: X-Microsoft-Exchange-Diagnostics: 1; DM5PR1501MB2007; 20:dURC788R458/PFj1t2PzcunZ0KEqxdaO73SqUBlt2QiQpJESEJE6SEeIufUKK0c2BoxVAHmCbGmfwnFmdV61kgBJWllF2X9wx0tNIBPZeXTFuuQYxx76Xr/oc0k490gug06QyrKsxloVzMJrEtuigNjPkGv17QBvfa/mggRfJdmKkr95MNdQUf26/NwKmYjxejzQCabwKT2ZpsTzagcTkR01wXzdl10lBt0IFRE0NOJZ7IQVfMevOU4+tkpuYddx/dbYiKTYlYHfSO9ya8U9HMWNHa7HN+3G66k4lZgza7jhD2H4E09ICjArpsDpvFqHT45XB/tpDteRz8UwQI/yUZc/J1oessJUBBGiTxsAZ0L75TTfQUDa3yQHgHVgDEywbXubq970juGjX8nQYczU9qmBnWneykCKSPWFVlbbiEhdCz/nHeUVQIYsW0QJer8ktK0bjVC+Il7+UWplu8p5WyOE6yc+XKLhwjmQsshdzHBY6KXzVMS+BTcK1jCPnMaM; 4:0es14POwEj3UMEp3XZfqRrWMdWtF27dnCrkSMh+lmwMRL6augUSGq4ufIMrZAdOsbigbPczw0eV6TwGt7K56BBELr/7QvXqR0S5OU72pXUgNHo+GqGKDQyw5tRxExnDWdQHRKFs0G2Moagteh+ZET2HwS1i9apLw3Tf0fE7KD4u58NQng+/7yNTx8cGhdSRALKd1Gh7UJJLgJM4xTEI1Og7/PO8l3oLYPpEaGx2epQsU83H0cG3UmaIHOjQN8rLFGypMxteSx6LvOA7MFWnlHL/6zI5HGa5evng7XLwH3vkBkNreYyp0SevDuS7XpMyi X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(37575265505322); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3231232)(944501327)(52105095)(3002001)(93006095)(93001095)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123558120)(20161123564045)(6072148)(201708071742011); SRVR:DM5PR1501MB2007; BCL:0; PCL:0; RULEID:; SRVR:DM5PR1501MB2007; X-Forefront-PRVS: 0644578634 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(39860400002)(396003)(346002)(366004)(376002)(39380400002)(54534003)(377424004)(199004)(189003)(66066001)(8676002)(2906002)(47776003)(478600001)(64126003)(53936002)(8936002)(76176011)(230700001)(7736002)(25786009)(65806001)(65956001)(2486003)(36756003)(52146003)(97736004)(52116002)(68736007)(23676004)(81166006)(81156014)(44832011)(486006)(59450400001)(16576012)(26005)(65826007)(476003)(2616005)(186003)(6486002)(53546011)(386003)(956004)(16526019)(106356001)(6666003)(105586002)(31696002)(316002)(305945005)(86362001)(5660300001)(446003)(11346002)(3846002)(58126008)(1857600001)(6116002)(49976009)(50466002)(31686004)(78286006); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR1501MB2007; H:[142.133.48.218]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjE1MDFNQjIwMDc7MjM6YndjaXpiK29pTFNQb2Y2MzI4QzhQRVFp?= =?utf-8?B?VFdmaDI4ZGFTRjZsSU9ITytNN1M2QU40VlFZWG5JbmYvUnEyaHlQS3F0cjE5?= =?utf-8?B?KzZlOGNlRzFiQjY3NkpoWjdBRkRMaWZMcENqaHRnaDdMV2ZxREwxTFVMZlBV?= =?utf-8?B?R1FkZXg2andTTzhRVTNlc2JKT3EvU2NpdkJ6aHM0bDRjZUUwU3NsYUpPUWFS?= =?utf-8?B?dE9WRlhteGc0RzhDU2xpdCtuelFhSTllcGNoYk9zY0ptTUdNUm8zNGdBTUhx?= =?utf-8?B?bkk5b2ZaRE9GN1pFTUs4VW1QVE9ra3RNSk9tTTY3TThuZEdFa2xVbkhFUEo4?= =?utf-8?B?SVYwODl2NXVlZUx4dDQ4QVluR0hzR21CNlRzbnN0cGJHSUJuN0JXMXR2Z28x?= =?utf-8?B?ZGhWcmdQNkxDSGU1QmhJOHBHN1FpNjV1MjZvYlhpVHNRQmNCdU52UFhRQzgw?= =?utf-8?B?WjI1bmd6bmw4QU1kcXU5U01XNnl4NUVPMGFvbVp0QWc5Z2loSCs0bXFwMDhH?= =?utf-8?B?NDVQVFo4a0lPbi95dkE3blB4VHh0SjRlWGdodk5NUDViZjg2S3pKTXZ3UlZo?= =?utf-8?B?WWF5QS84TEE4RkdNNDhoMW5FMVlueG5XRm03c0Z0UUZ1blg2aFlFMVhaejl2?= =?utf-8?B?NXd6ODRRTHAxd2llSFl1R0Znbi8zZUpNcWtFdndUZktSMU5PNDliU2dLV3FD?= =?utf-8?B?dUl4blE3aWF5LzB2eVJUK2p2UTg2U3dSMWlsR0F1V2owSEJxWjEzRFVLM3g4?= =?utf-8?B?TkZ2Z0F4NmhvblYxQzlKckdMYjVwRHBFMklCUDBXRU1nL3NOSk1jUkNsajEx?= =?utf-8?B?ekk3SHUwQWVkRm1hS1pwdzQ1OHo0QjkxSzNzVmFadnFiNzM5cUNLWEtvVGUr?= =?utf-8?B?eW9hQTVTNjFUaTRheFd3QWNMN1JLZnp0TnRTYjJSbmtGWU9lTUhrS09MNVVL?= =?utf-8?B?L0lROU9mbFUyb1k5SVlJc1BhQ0lGVnNVVTNtemhrZ0FtQVQ1elZCcXJYbGZI?= =?utf-8?B?Nk1CTXFJU1ROMkNCOFdQa2FLaFQ3eU5Db3R6aENiRXdsWEJzZHY2cHE4RUx1?= =?utf-8?B?U3I3ZXljdmMrV2F1aEVWemxLR1dCRmprWlpsWnZpQmxOVGdFbGZTeFc4alFy?= =?utf-8?B?YTVYSElzWXNURythajQ5bmpVT3AzVXU1YjA3dEM5M1lMMDJCQnRnbkNQUVFV?= =?utf-8?B?TE1VY1E1blhha2JtSFhCTGIxM1paYTAyQ3kzeTVtT1FlRHlJYzU1UnBsaEgz?= =?utf-8?B?eFY5UnZTcXc0WnhWQjFCNDNGQnkzbkpsakVCOUVkSVZtU250YzNmUmthcDds?= =?utf-8?B?MExxZkR4V0NFaDhRdWI2ME1lMGpWQjNRNitDYis1YkxFRmFKOWlUam9wTzR4?= =?utf-8?B?T1BsUXBJNnlvV3Z2bW4xOENrbGJJSzg5TVJwZmY3L29OWmJTRjdCNzdWbFh4?= =?utf-8?B?bjU0QXFvR0RvQUxCZ3F6cDZEb0NIZG1HVUNoSWFIMS9nTEZydzJaa3ZSUkFn?= =?utf-8?B?ZlFkQ1ZzMWZxQnlzTEtEZGNlOE03SVZYU2QvSTU1cnkzWTBIZGV0T1c1M1JC?= =?utf-8?B?M0dvTlNVWGE5bkM1eGVmK1c0M2ExNjZUemxuRkdvQVY2NjVONTRJUis5WkNu?= =?utf-8?B?U05CbEcxQjd5RHZScDZHcGE1bmgxREhZTDAyYXd2WkxYNDBZQWFUQ1ZxQUxs?= =?utf-8?B?N2hseEM0aWJYcUVLNlNKRXcwd295S1JQK0RFbmJJZkx4LzVJYklnWVk5STZS?= =?utf-8?B?dTBmRUUwQ0FzemUvT1J3U1lSczJPTG9WZ3d2UXVobXRJcXBOUkZ3SGdWMlpl?= =?utf-8?B?bHRXUk85UFpiSTk4MVBUdEdDZENkV21WWk1ia3cvNmMrdXkxTm92Qkk1VjBN?= =?utf-8?B?d29SU0V1ZExXTkZvekErY3FNdnBYTmM5NWRFRzNxS0d6SmF5L2Q5UlduVGZi?= =?utf-8?B?U0p2YkczWmlNWHhPNzAxUTNIRjZFUktZWHUwVWVkamo2d3Y3MTZMbmRBVG1Y?= =?utf-8?B?ejlnM29KaCtjTWllTE9YdnA2OHFJZWlVMXJ2bUtRPT0=?= X-Microsoft-Antispam-Message-Info: YUBhrOfTniRXRPYexB1Y5UT7k8pw5Rb2zALEboonMDpcefQxwUgNDP/IAsZuoOjl32+38qSwkANdk2pRWPpDC8ZSeh1gis3t8Yz4PFJGDDiR7EH8eZrPkTzTl3fOSwViNveu3+vA9YX/VAJIOjbK4Hho2EPl+TOdf5SlO2x9aW4qAirkpqlByJwFd4hcCl3D X-Microsoft-Exchange-Diagnostics: 1; DM5PR1501MB2007; 6:JCncvlwuyPaWi0cvU1cqfJlxF4SoxcZd7IXjp3ozh04Y5LH84B2KUSY8pdIVEcWxrB/BMceJxnVRYulgsjBGgNipQi1PUbvLCDkf/9TZrh/NbZLcKJp73UT6kwKhsczqyKWfcoEQs2NMPX/BqSflfRnasU8QxZuK67C4fSxCPp7kCU/Dz1MefeMdWVL30RvHHqSuU0cDJ45qdrgR6Jx+v05xswoiNCJaPzrPX16wcRxd9lRvmsoF7wU6YLGaM+qrYTZUa1mhH1UVKsNOxlyZonmrq87yVi4pgxsDXoRVxXxEnsu/QEJ03kWgxa+lBfliDis3yUOMjbuu6dGRYjkXvTUk5+Oe6LvD2LALMh3j0nLARKlbq72By8nKesJwzcFO4o7IICXDalehIaNKzuRq/2ZP7663i/hGmaObRtpovfpPnqmpBW9WaQcPxoEDJ7mc/ZL+2t2SZKTyD2H4J/Dvbw==; 5:DwFCGc650a2TFmkXS5XzgTcu/w+dT23pdgCBBJ86vGUw6jzL2o8A+yGLmpeEgodNLWkfQJb9AwA288R/N/F2v3tLE3YGAVKUaO/A8d470iei6kAB9I1108YouUPsc3DmT3kLSqM2wW5BXePp0E4f+0L+mIMznjUZRkhx7/5KqMM=; 24:4UtL+dowAJcnYu4qRMzadrDiWef3u+0SPrEs2vG/CD+yt0/NqqAbEJrHaOQ/iYx0twaT+SdJrHT0q/8Jw6OxHRFDpmJKAHYpgywKCj9E4Og= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM5PR1501MB2007; 7:NmP24itHTW76Bg790p3SFA1I4SH+BQ0edlp9euIwnlGntWJjQhvbRHWKJZNBc880eLPzhtcZUzvADgGfQ8bWseVozUhC1wD8qDRcsChdgDKRSIzIdIqV02a3VdYfXlUHBDzl6n9rm0vgxT2k7sxoCQaEdAwAviTXET5JXLoREBrgcpgMfCEnMIjfEFtACFdqTJu4+3gIceeIwSfw6240OkXFIpORTlP0BBXk0emF8/BLERF1k2247Wnls/XW226l X-MS-Office365-Filtering-Correlation-Id: 073780a1-3adf-45ec-3a5e-08d5a3dbb731 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2018 20:50:40.7852 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 073780a1-3adf-45ec-3a5e-08d5a3dbb731 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1501MB2007 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes On 2018-04-16 04:04 PM, Pedro Alves wrote: > Hi Simon, > > I noticed this recent regression: > > PASS: gdb.threads/gcore-stale-thread.exp: successfully compiled posix threads test case > PASS: gdb.threads/gcore-stale-thread.exp: set non-stop on > PASS: gdb.threads/gcore-stale-thread.exp: continue to breakpoint: break-here > -PASS: gdb.threads/gcore-stale-thread.exp: save a corefile > +UNSUPPORTED: gdb.threads/gcore-stale-thread.exp: save a corefile > PASS: gdb.threads/gcore-stale-thread.exp: exited thread is current due to non-stop > > and bisection points at: > 9018be22e02 ("Make target_read_alloc & al return vectors") > > diff of gdb.log shows: > > gcore gdb/testsuite/outputs/gdb.threads/gcore-stale-thread/gcore-stale-thread.core > -Saved corefile gdb/testsuite/outputs/gdb.threads/gcore-stale-thread/gcore-stale-thread.core > -(gdb) PASS: gdb.threads/gcore-stale-thread.exp: save a corefile > +Target does not support core file generation. > +(gdb) UNSUPPORTED: gdb.threads/gcore-stale-thread.exp: save a corefile Sorry about that, here's what I pushed to fix it: From 07d28c777757148d13e429c4463da52cbb50d297 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Mon, 16 Apr 2018 16:47:06 -0400 Subject: [PATCH] linux_spu_make_corefile_notes: return note_data instead of nullptr Since commit 9018be2 ("Make target_read_alloc & al return vectors") the test gdb.threads/gcore-stale-thread.exp test results in UNSUPPORTED: UNSUPPORTED: gdb.threads/gcore-stale-thread.exp: save a corefile The problem is that the linux_spu_make_corefile_notes started returning nullptr when reading TARGET_OBJECT_SPU fails. The previous (and proper) behaviour is to return the note_data received as a parameter, so that other functions may continue to append to this buffer. With this patch, the test goes back to PASS. gdb/ChangeLog: * linux-tdep.c (linux_spu_make_corefile_notes): Return note_data instead of nullptr. --- gdb/ChangeLog | 5 +++++ gdb/linux-tdep.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index ad7b993..3993491 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2018-04-16 Simon Marchi + + * linux-tdep.c (linux_spu_make_corefile_notes): Return note_data + instead of nullptr. + 2018-04-16 Pedro Alves * MAINTAINERS (sh): Remove. diff --git a/gdb/linux-tdep.c b/gdb/linux-tdep.c index 552a2a4..24bfd74 100644 --- a/gdb/linux-tdep.c +++ b/gdb/linux-tdep.c @@ -1426,7 +1426,7 @@ linux_spu_make_corefile_notes (bfd *obfd, char *note_data, int *note_size) spu_ids = target_read_alloc (¤t_target, TARGET_OBJECT_SPU, NULL); if (!spu_ids) - return nullptr; + return note_data; /* Generate corefile notes for each SPU file. */ for (size_t i = 0; i < spu_ids->size (); i += 4)