Patchwork h8300/ecoff (Re: Breakage on builder RHEL-s390x-m64, revision c2bf1eecf99abc4d546bb52a008a25e64a29d85e)

login
register
mail settings
Submitter Pedro Alves
Date April 16, 2018, 2:07 p.m.
Message ID <74e9b730-6493-6166-9c05-b8cd43984441@redhat.com>
Download mbox | patch
Permalink /patch/26754/
State New
Headers show

Comments

Pedro Alves - April 16, 2018, 2:07 p.m.
On 04/16/2018 12:22 PM, Alan Modra wrote:
> On Mon, Apr 16, 2018 at 06:58:22AM -0400, gdb-buildbot@sergiodj.net wrote:
>> Unfortunately it seems that there is a breakage on GDB.
>>
>> Commit title: 'Remove m88k support'
>> Revision: c2bf1eecf99abc4d546bb52a008a25e64a29d85e
> [snip]
>> ../../binutils-gdb/gdb/m88k-tdep.c: In function void _initialize_m88k_tdep():
>> ../../binutils-gdb/gdb/m88k-tdep.c:867:21: error: bfd_arch_m88k was not declared in this scope
>>    gdbarch_register (bfd_arch_m88k, m88k_gdbarch_init, NULL);
> 
> Yes, removing the bfd support for m88k will do that..
> 
> m88k has been obsolete since 2016-09-27, ie. it was obsolete in
> binutils-2.28 and should have been removed for binutils-2.29.
> 
> sparc-aout and sparc-coff, m68k-aout and m68k-coff, sh5 and sh64,
> sh-symbianelf, vax-bsd and vax-ultrix, w65, we32k, m88k, h8500,
> h8300-coff, ieee695, tandem, newsos3, netware, and tahoe all
> went today.
> 
> i860, i960, bout, adobe and icoff targets disappeared last week.

I went through this list now, and it looks to me like there's
not much else we can clean up from gdb.  Support for all of
these other ports had already been removed from gdb.

There's just this little bit of ecoff support in the h8300 support
that I ran into that I think we could remove.  Grepping around BFD,
I don't think ECOFF is supported for h8300, is it?

And if not, I'm failing to see why we'd support ECOFF debug info
in ELF for h8300 (.mdebug).  It kind of seems like someone just installed
the set_gdbarch_ecoff_reg_to_regnum hook at the same time the dwarf2
and stabs hooks were installed.

I'm inclined to remove this so that greps for ecoff stuff
only lead to MIPS, as ISTR that Linux/MIPS support still
relies on some subset of ECOFF for something.

From: Pedro Alves <palves@redhat.com>
Date: 2018-04-16 13:43:25 +0100

h8300 ecoff
---

 gdb/h8300-tdep.c |    4 ----
 1 file changed, 4 deletions(-)

Patch

diff --git a/gdb/h8300-tdep.c b/gdb/h8300-tdep.c
index 55e77b6bb6e..ca395efa4e6 100644
--- a/gdb/h8300-tdep.c
+++ b/gdb/h8300-tdep.c
@@ -1265,7 +1265,6 @@  h8300_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
     case bfd_mach_h8300:
       set_gdbarch_num_regs (gdbarch, 13);
       set_gdbarch_num_pseudo_regs (gdbarch, 1);
-      set_gdbarch_ecoff_reg_to_regnum (gdbarch, h8300_dbg_reg_to_regnum);
       set_gdbarch_dwarf2_reg_to_regnum (gdbarch, h8300_dbg_reg_to_regnum);
       set_gdbarch_stab_reg_to_regnum (gdbarch, h8300_dbg_reg_to_regnum);
       set_gdbarch_register_name (gdbarch, h8300_register_name);
@@ -1277,7 +1276,6 @@  h8300_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
     case bfd_mach_h8300hn:
       set_gdbarch_num_regs (gdbarch, 13);
       set_gdbarch_num_pseudo_regs (gdbarch, 1);
-      set_gdbarch_ecoff_reg_to_regnum (gdbarch, h8300_dbg_reg_to_regnum);
       set_gdbarch_dwarf2_reg_to_regnum (gdbarch, h8300_dbg_reg_to_regnum);
       set_gdbarch_stab_reg_to_regnum (gdbarch, h8300_dbg_reg_to_regnum);
       set_gdbarch_register_name (gdbarch, h8300_register_name);
@@ -1297,7 +1295,6 @@  h8300_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
     case bfd_mach_h8300sn:
       set_gdbarch_num_regs (gdbarch, 16);
       set_gdbarch_num_pseudo_regs (gdbarch, 2);
-      set_gdbarch_ecoff_reg_to_regnum (gdbarch, h8300s_dbg_reg_to_regnum);
       set_gdbarch_dwarf2_reg_to_regnum (gdbarch, h8300s_dbg_reg_to_regnum);
       set_gdbarch_stab_reg_to_regnum (gdbarch, h8300s_dbg_reg_to_regnum);
       set_gdbarch_register_name (gdbarch, h8300s_register_name);
@@ -1317,7 +1314,6 @@  h8300_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
     case bfd_mach_h8300sxn:
       set_gdbarch_num_regs (gdbarch, 18);
       set_gdbarch_num_pseudo_regs (gdbarch, 2);
-      set_gdbarch_ecoff_reg_to_regnum (gdbarch, h8300s_dbg_reg_to_regnum);
       set_gdbarch_dwarf2_reg_to_regnum (gdbarch, h8300s_dbg_reg_to_regnum);
       set_gdbarch_stab_reg_to_regnum (gdbarch, h8300s_dbg_reg_to_regnum);
       set_gdbarch_register_name (gdbarch, h8300sx_register_name);