From patchwork Mon Apr 9 18:27:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 26660 Received: (qmail 53542 invoked by alias); 9 Apr 2018 18:28:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 53530 invoked by uid 89); 9 Apr 2018 18:28:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT autolearn=ham version=3.3.2 spammy=stolen, HX-ClientProxiedBy:10b6, pop, 1047 X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Apr 2018 18:28:03 +0000 Received: from ESESSHC021.ericsson.se (Unknown_Domain [153.88.183.81]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id 8C.E2.29657.0B0BBCA5; Mon, 9 Apr 2018 20:28:00 +0200 (CEST) Received: from ESESSMB501.ericsson.se (153.88.183.162) by ESESSHC021.ericsson.se (153.88.183.81) with Microsoft SMTP Server (TLS) id 14.3.382.0; Mon, 9 Apr 2018 20:28:00 +0200 Received: from ESESBMB504.ericsson.se (153.88.183.171) by ESESSMB501.ericsson.se (153.88.183.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.26; Mon, 9 Apr 2018 20:27:59 +0200 Received: from NAM01-BN3-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB504.ericsson.se (153.88.183.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.26 via Frontend Transport; Mon, 9 Apr 2018 20:27:59 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.61.222] (192.75.88.130) by DM5PR1501MB2006.namprd15.prod.outlook.com (2603:10b6:4:a1::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.653.12; Mon, 9 Apr 2018 18:27:56 +0000 Subject: Re: [PATCH v3 3/5] Add gdb::string_view To: Pedro Alves , Simon Marchi , References: <20180407132629.3787-1-simon.marchi@polymtl.ca> <20180407132629.3787-3-simon.marchi@polymtl.ca> From: Simon Marchi Message-ID: <6dfdeab0-40aa-e5b1-ef80-d3ddb1b85300@ericsson.com> Date: Mon, 9 Apr 2018 14:27:46 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: X-ClientProxiedBy: MWHPR03CA0001.namprd03.prod.outlook.com (2603:10b6:300:117::11) To DM5PR1501MB2006.namprd15.prod.outlook.com (2603:10b6:4:a1::36) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4479e4b4-7da5-41dd-7431-08d59e479e25 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DM5PR1501MB2006; X-Microsoft-Exchange-Diagnostics: 1; DM5PR1501MB2006; 3:jbel7gnaPxk1B143Jk/+LzeSm8t0Un48cSlgZ+E6y5DVU5Lgu42cKOElwOPIsktTsec/rL8lkiUPDg5tyBVHBPgz44d10u77xcl/y+6FqVzT74qs87uXkCGgCriWSicFkA6Vcmzpv8CX6FfgYD5En8d8xIlQGvcV16TZuZmRkXS6kk/E/UcUdPA6E97mVtU1socGAuDC9Wt6QsmuogRMIOqQGbCQfM3KeEn8kUEOVmesT/WDLMslYZcnLZP9BBag; 25:aWK5NUi4ozmmoR0doyoT3Y/aYSpUfECThAuyc58BwAFmHufGsX95AKKlpHWKLAW7rhzI1a97LiBj2W+WmMux/EltmleiS4A4Up1xzypA+9UXMddkFXP1MlRnaPS3nPNcfhG0VvAYhfSRsPSdfuztL+FjEqw/OvDZJMMZbibggOttM8/JDCxnZhoOB7HrYbBYup4dzr1yeHJfFb19qBxvi9Itj6wuIBeorrIkaZ123XxT3tmP5Xb8ixTQtSYzEzlI4GFxPFPGsHeXu+KO9QEfkY5ALUW6vhZWanxghZi2DyDJmL6lrwrzGpWUXuwlT0BF33bUKjn7MRLp/yVKWCOSZg==; 31:nXDMKUj3NWo77e4wiTVnGt22VltU0EKCM9QbLU9hAA7Z1wUP9xz89lFrQoKtHicUltNGqzCJKcitg9E9isEqlA8kh2gYBTNx1EcaguiLEYdVGP7rZxASpinBglMehkk+mqLTRd0OlB4QqRrXNPEPlikjtlROlc833tWZ0ctQRqJb3PZoyYN4Rz68L8tyb2ND5msePPyNh+iM2dJ47YXYOP5I+kcNGDoFT/6C3/yLhsE= X-MS-TrafficTypeDiagnostic: DM5PR1501MB2006: X-Microsoft-Exchange-Diagnostics: 1; DM5PR1501MB2006; 20:+Go0G0eYv1ThkJPduf+Fuojm+dqsp36cCXD0y6DO+uqqn08P3so1ENSkAFGfCQmhE6ARo5VHk43ubOKpUjvvual4gWE18ovbGs68XDFxv3suLIw5gvuW+tJkZfkO69/M45wX0+2lES/5Zsr4ZpWBvSLcmr12THl55S16jkgZyvxhLCRHes4ku3Au8yvBxEb+lUpYqcTxvG6gEey+yb2E0p81/i5FeU7fJiIeZnvQj6NFAHI3HeUUkg/VYiOuwFoA5AHDDMhtgkzAjRscnyURBT2VCQOnVn9L0ebRnTA8vGN+UGkBrSsRxu0n0dxxg39zmaKiVRWo6Fw8NYQ6SrwBVjvUZC+4KEl3Y+0MJTKFIzb8or9p4H7F6vEEqM7O3xCbB5JgX0f5m3bYi65xrW48o68WzeQGFNTcQpgsZTMRkVAGzwUw6lrdlQwNJbsKMOujixhYMAI3KuTXw7XGKziCcOH8wd4jdugicgZBHgrSFBR/sgRo/GVxiGFKA8HNhROL; 4:SPuXpP8t4B/zmR6jwHKjpKLWnfjG/6xv01U2m9BPUqKVRWEe2PZRdh1lHZPx6XT98eNQ5XEnyfHuxid6c5dvrJOMVikKizWeprLJgHsGBeatb0H6XO5J+/d/0GFmeJccuY7hFAmb83FY8uaGNSz3H3bB0wmm/TVTW06VV48SpteC1W88XKuUzKhuQM2C0gEcvKjsASNfF1hsC5AR9g2VEkG1fOqBi1WABn0M7GMrCZzeO7RfJYG5uRhpFAouFJj4FVmfBVpiA1zoUg5QSMIaEUkWadN4F3aS7oEbt9jf3B194gabR+22Y4brGdql8xICvTYCIjQjpUMyIhV2cBLXr7Bqe7cM8S6nOMgorRBoqKMY9OKg00GV7dUjotnMnZPTfmJy7S21jaLbL4n9yWY7bXvF/EnJKGzSI+9zpWD0LyM= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(250305191791016)(22074186197030)(788757137089)(17755550239193); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231221)(944501327)(52105095)(93006095)(93001095)(10201501046)(3002001)(6041310)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(6072148)(201708071742011); SRVR:DM5PR1501MB2006; BCL:0; PCL:0; RULEID:; SRVR:DM5PR1501MB2006; X-Forefront-PRVS: 0637FCE711 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(346002)(366004)(396003)(39380400002)(376002)(39860400002)(54534003)(199004)(377424004)(189003)(6246003)(6486002)(52146003)(2486003)(76176011)(52116002)(23676004)(2906002)(26005)(229853002)(186003)(230700001)(16526019)(49976009)(6116002)(106356001)(5660300001)(3846002)(31696002)(36756003)(47776003)(6666003)(65826007)(50466002)(97736004)(65956001)(476003)(58126008)(110136005)(486006)(65806001)(66066001)(478600001)(68736007)(6306002)(16576012)(64126003)(53546011)(386003)(8936002)(105586002)(53946003)(25786009)(316002)(11346002)(305945005)(8676002)(81156014)(81166006)(53936002)(86362001)(2616005)(956004)(446003)(31686004)(7736002)(78286006)(2004002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR1501MB2006; H:[142.133.61.222]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjE1MDFNQjIwMDY7MjM6T24rOHpiWk9WMUV4M29Da3NOODFYQWVY?= =?utf-8?B?ejgza0hmVWhzeERkclppQ1p6QXJ0Sk9jWGxkdEhZSkNyYlFHdUd2d1Budko1?= =?utf-8?B?ZXNyNEVxOVEwdDA0UzRQZytMUmRCczRwQXN4ekdHc21OUmpsRDRwUTlBckE5?= =?utf-8?B?dEl2d2Qydi9kRDd0Mk5sWXJMY3VRSkJ3bHBuT2tUeEpjdmZZMWR6amxTUGJy?= =?utf-8?B?UkN4QkVEbE9CYisweE1ZSldrQ01PSFp0cklRak1qcEt0eVpvOVd3VSt2MDV0?= =?utf-8?B?Rjd0cGIzN01LSmoxd2doUjJ2N3V5ZkdSaGs3VzFvblUxVSttWG9JVEs5Q1FC?= =?utf-8?B?UVVKaEFna2V5S01MTzV2dFdIcDhUcFRwSy96cUpxZlYrMGN2UTUxa0E3alFt?= =?utf-8?B?eGRGYW1qMTdPNnoyNEFVc2Fld2ZJTjhMSTRiZkdWK2ZnMThxRFV6STdVTEdx?= =?utf-8?B?ek16RjRYR0pVYkZwWU1HMGRGaXJ4TXIvN09GREhXSEwvMVVsNnhFeGhLcmUy?= =?utf-8?B?YnNjWkhDM1NJcWlBTUtGRTliUkVxWEZwUlRWek1RR2hBN1B0MGdtOG91YTdJ?= =?utf-8?B?TXNFWjB1UDRMSWFKMStiMkdPNEZMb2d2RENGUDROaWluRGkxMXlDN1hjdHZy?= =?utf-8?B?b3NOQS9HeVViK2Y3WmlTd3o2bzFDK0kzL2pBYWNMSFdIQXhHOHRaTVJZZTRx?= =?utf-8?B?VmxHeHEvWTRuQmVvcTJhMEtQYlhVZTJleUdxU00vYlZVditFSnFqTW9BejlQ?= =?utf-8?B?dlRtNmhzbDQwL25xMmNSRWg0K0IzVlRjd2F3dTZnaHdlWExKakY2aENsaFJj?= =?utf-8?B?dTdqbWR1UE1MZFg5ekFGaC9BN2t1N2NDakg5eXRxdXBUTFRBUElTVEV4OE56?= =?utf-8?B?NFpaT1orMlRRR0JsMDI4am4vTzgvYnk3THRUT3lmNGpIdzZiRjRpYWk4dHNG?= =?utf-8?B?bk1FOGwzMTd2RmR6ZlU2dWRSVkNZdG1RZE0vZDYxZ0w4WHhJcG92c2VvTUlk?= =?utf-8?B?RjJlODBZcWpVbWV2b05VaXFkWWh0N1pvcTVONHBmaHNYKzNWcko0aVR2Mjg4?= =?utf-8?B?eUlraVkwcExBWUlEOXQ5UVNHTWs2V1hBdHgydlRkb2E5NEp4QzJsU1NZVHc3?= =?utf-8?B?SWMrZXZlMVVlZy83ZVZWbHJxR3NXaXFwMnhvM3o1Vk5DMlFzMGkrUm10ZlZB?= =?utf-8?B?dUlXOHc5S2N0OVVuQWJJR2NQekF5cVZsN0xXZ2tSZ0VQTkM3ZWMvRWdpeGlu?= =?utf-8?B?MjBwQ3lhWHZacldUY2g2SWJqYlhXZkZnbzZmNWNjd3JjaG9PTzBmRjRoRm5s?= =?utf-8?B?MlcreHlsQTYrTmR5a0Fkc0tJSWJ3Z0RXRmdMVVdlM0w3RW1EaWNYS2xRaU1Q?= =?utf-8?B?Q0ljSmJDSThIL1VqUTBNdTF5dE4xZ2tnUC9NM2VMY21PaWYrTmlON1UzZXlK?= =?utf-8?B?S0lZaDA5eUpQYytqOXlocDlIVzQxQm9idVpKTWZNY3l1VkxUYlVXeDF0VmxM?= =?utf-8?B?cS9Gd0ZBV1FJZUhCSVlFL2pjbGk4dm5Ic0NqQS9ZR0NJM0xTQmlRN0s0NWdC?= =?utf-8?B?Q2U1bnZuNW5QeW80V2NtY0UwYWljRXF6RFczdm4xYXk2UFNxRGdHRFdEem9K?= =?utf-8?B?WWZyYVZRVDRGRmNzdTEyTWtQMXRlK2dxZHF0b1QyaEVoSHZYWStRTW5GK2cv?= =?utf-8?B?dFBJMEF2Z3J4a2pMVDdlUEFyYzdqMXd5S1NsVjhuSTJIYWlkRERyTmR3MHEr?= =?utf-8?B?Q1FWNnBPYXEveE91N1dncEpVZUZZREJDbHBJTmhwTzFSVGU1T3dETlRCQUNV?= =?utf-8?B?eXYxdjl1M2dMQTNQSnBkR3RkOElJUU5KRTlMT1JRNXZUOXYwVU1iWDJYbFFK?= =?utf-8?B?aitURVRZencvaDJBN1EwM2lnVGM3Nnl2dEdRTXk1bXM1NnZJa25COWdjWDBP?= =?utf-8?B?eFNadnQrZWNkY3lkQlgwbHpZaFYvZ09reUJ4KzFPUjBhY2xjZEkvbGNaSVly?= =?utf-8?B?cmluVndpMGlGRnl2RWVmaDJXOEUzbUJ6dnlYdVl2ZjJKOElyOTBxZFZvSWRX?= =?utf-8?Q?7kqLCXGi9459W/Z5amNrlpMe+Q6?= X-Microsoft-Antispam-Message-Info: CuhtKsd4L8MMxOoyQGj9qH49eeOri9j73t7U3T8OB6MjXzsWf3lp3LZlqa7aAuFUVwuxVkyD9oSNUbu4eH2jvtADlIbITdzQCUrxyupUXQKbM5qxiVLKfG77714Q1FI+WEbravDZ3Z7q9vbb5Pb3PFud0UDj7VggwuJ7UiD0PgZo8AzV5SMvvyNv6hSamyyI X-Microsoft-Exchange-Diagnostics: 1; DM5PR1501MB2006; 6:ZA03Y31mrPJEAvxob/xdvGhycrnrWPKj81nbpn6vuIQfgg6ubK84CerT8qnBEgYDutnORwdpIbXpNs4W1Hl0IynmEbbsWfU9W+4s5szagWZNYwgh3Qws28fZEk/PiXqfwThOtRbb2dBA62SB8MSYsvA9zjWZNywlGeFtLdrOxgY4qrwxiJLVa7u5yrzVq1XPs7Uney53+1yt9/Cfo33k3mkaMsI6wIImmKNA9PuFncf/OnzAZBFk/A5+X3HI9ajBpuLq9eK37D0zvxsB2dtNZUefY8bDbrvbQ1QKtoiCJIpG4tPr9jlDAcsog1bFqQH0/Y6kx4eg/2VZ+WBiio+DHNM2c96m43+dzyyOgr+M097sHBkt9ZQg4NpiKIf9dGYsGpRqSt8ZL07TNgVNwCfVgBYWohvWCGs6QlgjdgUPxPiZR8I9W0CNwQknOGW3wGJA3NfSV1P367ttsqBmzlnzFQ==; 5:83MtrKKL/CAix7YHnpyDfjDt8eklRS0shLzekAfWFMNTUiSw5J3Zq+GGmQQBwWSZDr/A89fVUfXV75FHs1I8oxrcgiXhP+7V2JZUs/dJ9Wr7dFnCl5ptZryHKjHnAIHC0UkOLb/OfpGAzD5S9HxwbNT7j/XmDPF7wGuSyz0K7Nc=; 24:EXD1gH49SB/+ZvU5+bWI7CyUelFUfKbpITc+RaBdYY+MvGyeFgEnyzuNY/K/UYG1DDCZQLu8RpGT0VGE0vbS9aD6Y/ZhwAxQu3d6ig9Fi6k= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM5PR1501MB2006; 7:kd13C0Q6AAJC0jy5iZefDZGrUIXLvetr9VhfL1oe3+dkctzcV8/QTYfGlmK4qYYZOMeKXsrzlPcgXhlVDB3jHtEkZT7yHrtGX3WrFZwYs0wniNo+3X6vsX6pL1DTQSjxmjjr+yW7I2lDB6cMQxqPNhOwgP34+Va+SH2xkOu/1HIFtEAwQtcJaba32lw912BpUHqx9e5EXSORmoYH3ke19suaEleaY5ttMhyjADwcYGTXyt8BrB1xEqys22+FzZQz X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2018 18:27:56.9508 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4479e4b4-7da5-41dd-7431-08d59e479e25 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1501MB2006 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes For completeness, here is what I pushed: From 10907ddb20428acfe22964f9f9fb7855c6fca932 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Mon, 9 Apr 2018 13:31:04 -0400 Subject: [PATCH] Add gdb::string_view We had a few times the need for a data structure that does essentially what C++17's std::string_view does, which is to give an std::string-like interface (only the read-only operations) to an arbitrary character buffer. This patch adapts the files copied from libstdc++ by the previous patch to integrate them with GDB. Here's a summary of the changes: * Remove things related to wstring_view, u16string_view and u32string_view (I don't think we need them, but we can always add them later). * Remove usages of _GLIBCXX_BEGIN_NAMESPACE_VERSION and _GLIBCXX_END_NAMESPACE_VERSION. * Put the code in the gdb namespace. I had to add a few "std::" in front of std type usages. * Change __throw_out_of_range_fmt() for error(). * Make gdb::string_view an alias of std::string_view when building with >= c++17. * Remove a bunch of constexpr, because they are not valid in c++11 (e.g. they are not a single return line). * Use std::common_type<_Tp>::type instead of std::common_type_t<_Tp>, because c++11 doesn't have the later. * Remove the #pragma GCC system_header, since that silences some warnings that we might want to have if we're doing something not correctly. * Remove operator ""sv. It would need a lot of work to make all supported compilers happy, and we can easily live without it. * Remove operator<<. It is implemented using __ostream_insert (a libstdc++ internal). Bringing it in might be possible, but I don't think that would be worth the effort, since we don't really use streams at the moment. * Replace internal libstdc++ asserts ( __glibcxx_assert and __glibcxx_requires_string_len) with gdb_assert. * Remove hash helpers, because they use libstdc++ internal functions. If we need them we always import them later. The string_view class in cli/cli-script.c is removed and its usage replaced with the new gdb::string_view. gdb/ChangeLog: * common/gdb_string_view.h: Remove libstdc++ implementation details, adjust to gdb reality. * common/gdb_string_view.tcc: Likewise. * cli/cli-script.c (struct string_view): Remove. (user_args) : Change element type to gdb::string_view. (user_args::insert_args): Adjust. --- gdb/ChangeLog | 9 ++ gdb/cli/cli-script.c | 17 +-- gdb/common/gdb_string_view.h | 298 ++++++++++++----------------------------- gdb/common/gdb_string_view.tcc | 62 ++++----- 4 files changed, 126 insertions(+), 260 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 631f15a..462fc7d 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,14 @@ 2018-04-09 Simon Marchi + * common/gdb_string_view.h: Remove libstdc++ implementation + details, adjust to gdb reality. + * common/gdb_string_view.tcc: Likewise. + * cli/cli-script.c (struct string_view): Remove. + (user_args) : Change element type to gdb::string_view. + (user_args::insert_args): Adjust. + +2018-04-09 Simon Marchi + * common/gdb_string_view.h: New file. * common/gdb_string_view.tcc: New file. diff --git a/gdb/cli/cli-script.c b/gdb/cli/cli-script.c index 366c422..cdfda11 100644 --- a/gdb/cli/cli-script.c +++ b/gdb/cli/cli-script.c @@ -32,6 +32,7 @@ #include "extension.h" #include "interps.h" #include "compile/compile.h" +#include "common/gdb_string_view.h" #include @@ -54,18 +55,6 @@ static int command_nest_depth = 1; /* This is to prevent certain commands being printed twice. */ static int suppress_next_print_command_trace = 0; -/* A non-owning slice of a string. */ - -struct string_view -{ - string_view (const char *str_, size_t len_) - : str (str_), len (len_) - {} - - const char *str; - size_t len; -}; - /* Structure for arguments to user defined functions. */ class user_args @@ -91,7 +80,7 @@ private: std::string m_command_line; /* The arguments. Each element points inside M_COMMAND_LINE. */ - std::vector m_args; + std::vector m_args; }; /* The stack of arguments passed to user defined functions. We need a @@ -827,7 +816,7 @@ user_args::insert_args (const char *line) const error (_("Missing argument %ld in user function."), i); else { - new_line.append (m_args[i].str, m_args[i].len); + new_line.append (m_args[i].data (), m_args[i].length ()); line = tmp; } } diff --git a/gdb/common/gdb_string_view.h b/gdb/common/gdb_string_view.h index e42d5ac..545109c 100644 --- a/gdb/common/gdb_string_view.h +++ b/gdb/common/gdb_string_view.h @@ -1,5 +1,8 @@ // Components for manipulating non-owning sequences of characters -*- C++ -*- +// Note: This file has been stolen from the gcc repo +// (libstdc++-v3/include/experimental/string_view) and has local modifications. + // Copyright (C) 2013-2018 Free Software Foundation, Inc. // // This file is part of the GNU ISO C++ Library. This library is free @@ -22,34 +25,27 @@ // see the files COPYING3 and COPYING.RUNTIME respectively. If not, see // . -/** @file experimental/string_view - * This is a TS C++ Library header. - */ - // // N3762 basic_string_view library // -#ifndef _GLIBCXX_EXPERIMENTAL_STRING_VIEW -#define _GLIBCXX_EXPERIMENTAL_STRING_VIEW 1 +#ifndef GDB_STRING_VIEW_H +#define GDB_STRING_VIEW_H 1 + +#if __cplusplus >= 201703L -#pragma GCC system_header +#include -#if __cplusplus >= 201402L +namespace gdb { + using string_view = std::string_view; +} /* namespace gdb */ + +#else /* __cplusplus < 201703L */ #include #include -#include - -namespace std _GLIBCXX_VISIBILITY(default) -{ -_GLIBCXX_BEGIN_NAMESPACE_VERSION -namespace experimental -{ -inline namespace fundamentals_v1 -{ -#define __cpp_lib_experimental_string_view 201411 +namespace gdb { /** * @class basic_string_view @@ -100,12 +96,12 @@ inline namespace fundamentals_v1 constexpr basic_string_view(const basic_string_view&) noexcept = default; template - basic_string_view(const basic_string<_CharT, _Traits, + basic_string_view(const std::basic_string<_CharT, _Traits, _Allocator>& __str) noexcept : _M_len{__str.length()}, _M_str{__str.data()} { } - constexpr basic_string_view(const _CharT* __str) + /*constexpr*/ basic_string_view(const _CharT* __str) : _M_len{__str == nullptr ? 0 : traits_type::length(__str)}, _M_str{__str} { } @@ -188,10 +184,10 @@ inline namespace fundamentals_v1 { return __pos < this->_M_len ? *(this->_M_str + __pos) - : (__throw_out_of_range_fmt(__N("basic_string_view::at: __pos " - "(which is %zu) >= this->size() " - "(which is %zu)"), - __pos, this->size()), + : (error (_("basic_string_view::at: __pos " + "(which is %zu) >= this->size() " + "(which is %zu)"), + __pos, this->size()), *this->_M_str); } @@ -217,19 +213,19 @@ inline namespace fundamentals_v1 // [string.view.modifiers], modifiers: - constexpr void + /*constexpr*/ void remove_prefix(size_type __n) { - __glibcxx_assert(this->_M_len >= __n); + gdb_assert (this->_M_len >= __n); this->_M_str += __n; this->_M_len -= __n; } - constexpr void + /*constexpr*/ void remove_suffix(size_type __n) { this->_M_len -= __n; } - constexpr void + /*constexpr*/ void swap(basic_string_view& __sv) noexcept { auto __tmp = *this; @@ -241,13 +237,13 @@ inline namespace fundamentals_v1 // [string.view.ops], string operations: template - explicit operator basic_string<_CharT, _Traits, _Allocator>() const + explicit operator std::basic_string<_CharT, _Traits, _Allocator>() const { return { this->_M_str, this->_M_len }; } template> - basic_string<_CharT, _Traits, _Allocator> + std::basic_string<_CharT, _Traits, _Allocator> to_string(const _Allocator& __alloc = _Allocator()) const { return { this->_M_str, this->_M_len, __alloc }; @@ -256,12 +252,12 @@ inline namespace fundamentals_v1 size_type copy(_CharT* __str, size_type __n, size_type __pos = 0) const { - __glibcxx_requires_string_len(__str, __n); + gdb_assert (__str != nullptr || __n == 0); if (__pos > this->_M_len) - __throw_out_of_range_fmt(__N("basic_string_view::copy: __pos " - "(which is %zu) > this->size() " - "(which is %zu)"), - __pos, this->size()); + error (_("basic_string_view::copy: __pos " + "(which is %zu) > this->size() " + "(which is %zu)"), + __pos, this->size()); size_type __rlen{std::min(__n, size_type{this->_M_len - __pos})}; for (auto __begin = this->_M_str + __pos, __end = __begin + __rlen; __begin != __end;) @@ -272,19 +268,19 @@ inline namespace fundamentals_v1 // [string.view.ops], string operations: - constexpr basic_string_view + /*constexpr*/ basic_string_view substr(size_type __pos, size_type __n=npos) const { return __pos <= this->_M_len ? basic_string_view{this->_M_str + __pos, std::min(__n, size_type{this->_M_len - __pos})} - : (__throw_out_of_range_fmt(__N("basic_string_view::substr: __pos " - "(which is %zu) > this->size() " - "(which is %zu)"), - __pos, this->size()), basic_string_view{}); + : (error (_("basic_string_view::substr: __pos " + "(which is %zu) > this->size() " + "(which is %zu)"), + __pos, this->size()), basic_string_view{}); } - constexpr int + /*constexpr*/ int compare(basic_string_view __str) const noexcept { int __ret = traits_type::compare(this->_M_str, __str._M_str, @@ -294,24 +290,24 @@ inline namespace fundamentals_v1 return __ret; } - constexpr int + /*constexpr*/ int compare(size_type __pos1, size_type __n1, basic_string_view __str) const { return this->substr(__pos1, __n1).compare(__str); } - constexpr int + /*constexpr*/ int compare(size_type __pos1, size_type __n1, basic_string_view __str, size_type __pos2, size_type __n2) const { return this->substr(__pos1, __n1).compare(__str.substr(__pos2, __n2)); } - constexpr int + /*constexpr*/ int compare(const _CharT* __str) const noexcept { return this->compare(basic_string_view{__str}); } - constexpr int + /*constexpr*/ int compare(size_type __pos1, size_type __n1, const _CharT* __str) const { return this->substr(__pos1, __n1).compare(basic_string_view{__str}); } - constexpr int + /*constexpr*/ int compare(size_type __pos1, size_type __n1, const _CharT* __str, size_type __n2) const { @@ -319,97 +315,97 @@ inline namespace fundamentals_v1 .compare(basic_string_view(__str, __n2)); } - constexpr size_type + /*constexpr*/ size_type find(basic_string_view __str, size_type __pos = 0) const noexcept { return this->find(__str._M_str, __pos, __str._M_len); } - constexpr size_type + /*constexpr*/ size_type find(_CharT __c, size_type __pos=0) const noexcept; - constexpr size_type + /*constexpr*/ size_type find(const _CharT* __str, size_type __pos, size_type __n) const noexcept; - constexpr size_type + /*constexpr*/ size_type find(const _CharT* __str, size_type __pos=0) const noexcept { return this->find(__str, __pos, traits_type::length(__str)); } - constexpr size_type + /*constexpr*/ size_type rfind(basic_string_view __str, size_type __pos = npos) const noexcept { return this->rfind(__str._M_str, __pos, __str._M_len); } - constexpr size_type + /*constexpr*/ size_type rfind(_CharT __c, size_type __pos = npos) const noexcept; - constexpr size_type + /*constexpr*/ size_type rfind(const _CharT* __str, size_type __pos, size_type __n) const noexcept; - constexpr size_type + /*constexpr*/ size_type rfind(const _CharT* __str, size_type __pos = npos) const noexcept { return this->rfind(__str, __pos, traits_type::length(__str)); } - constexpr size_type + /*constexpr*/ size_type find_first_of(basic_string_view __str, size_type __pos = 0) const noexcept { return this->find_first_of(__str._M_str, __pos, __str._M_len); } - constexpr size_type + /*constexpr*/ size_type find_first_of(_CharT __c, size_type __pos = 0) const noexcept { return this->find(__c, __pos); } - constexpr size_type + /*constexpr*/ size_type find_first_of(const _CharT* __str, size_type __pos, size_type __n) const; - constexpr size_type + /*constexpr*/ size_type find_first_of(const _CharT* __str, size_type __pos = 0) const noexcept { return this->find_first_of(__str, __pos, traits_type::length(__str)); } - constexpr size_type + /*constexpr*/ size_type find_last_of(basic_string_view __str, size_type __pos = npos) const noexcept { return this->find_last_of(__str._M_str, __pos, __str._M_len); } - constexpr size_type + size_type find_last_of(_CharT __c, size_type __pos=npos) const noexcept { return this->rfind(__c, __pos); } - constexpr size_type + /*constexpr*/ size_type find_last_of(const _CharT* __str, size_type __pos, size_type __n) const; - constexpr size_type + /*constexpr*/ size_type find_last_of(const _CharT* __str, size_type __pos = npos) const noexcept { return this->find_last_of(__str, __pos, traits_type::length(__str)); } - constexpr size_type + /*constexpr*/ size_type find_first_not_of(basic_string_view __str, size_type __pos = 0) const noexcept { return this->find_first_not_of(__str._M_str, __pos, __str._M_len); } - constexpr size_type + /*constexpr*/ size_type find_first_not_of(_CharT __c, size_type __pos = 0) const noexcept; - constexpr size_type + /*constexpr*/ size_type find_first_not_of(const _CharT* __str, size_type __pos, size_type __n) const; - constexpr size_type + /*constexpr*/ size_type find_first_not_of(const _CharT* __str, size_type __pos = 0) const noexcept { return this->find_first_not_of(__str, __pos, traits_type::length(__str)); } - constexpr size_type + /*constexpr*/ size_type find_last_not_of(basic_string_view __str, size_type __pos = npos) const noexcept { return this->find_last_not_of(__str._M_str, __pos, __str._M_len); } - constexpr size_type + /*constexpr*/ size_type find_last_not_of(_CharT __c, size_type __pos = npos) const noexcept; - constexpr size_type + /*constexpr*/ size_type find_last_not_of(const _CharT* __str, size_type __pos, size_type __n) const; - constexpr size_type + /*constexpr*/ size_type find_last_not_of(const _CharT* __str, size_type __pos = npos) const noexcept { @@ -441,240 +437,124 @@ inline namespace fundamentals_v1 // argument participates in template argument deduction and the other // argument gets implicitly converted to the deduced type. See n3766.html. template - using __idt = common_type_t<_Tp>; + using __idt = typename std::common_type<_Tp>::type; } template - constexpr bool + /*constexpr*/ bool operator==(basic_string_view<_CharT, _Traits> __x, basic_string_view<_CharT, _Traits> __y) noexcept { return __x.size() == __y.size() && __x.compare(__y) == 0; } template - constexpr bool + /*constexpr*/ bool operator==(basic_string_view<_CharT, _Traits> __x, __detail::__idt> __y) noexcept { return __x.size() == __y.size() && __x.compare(__y) == 0; } template - constexpr bool + /*constexpr*/ bool operator==(__detail::__idt> __x, basic_string_view<_CharT, _Traits> __y) noexcept { return __x.size() == __y.size() && __x.compare(__y) == 0; } template - constexpr bool + /*constexpr*/ bool operator!=(basic_string_view<_CharT, _Traits> __x, basic_string_view<_CharT, _Traits> __y) noexcept { return !(__x == __y); } template - constexpr bool + /*constexpr*/ bool operator!=(basic_string_view<_CharT, _Traits> __x, __detail::__idt> __y) noexcept { return !(__x == __y); } template - constexpr bool + /*constexpr*/ bool operator!=(__detail::__idt> __x, basic_string_view<_CharT, _Traits> __y) noexcept { return !(__x == __y); } template - constexpr bool + /*constexpr*/ bool operator< (basic_string_view<_CharT, _Traits> __x, basic_string_view<_CharT, _Traits> __y) noexcept { return __x.compare(__y) < 0; } template - constexpr bool + /*constexpr*/ bool operator< (basic_string_view<_CharT, _Traits> __x, __detail::__idt> __y) noexcept { return __x.compare(__y) < 0; } template - constexpr bool + /*constexpr*/ bool operator< (__detail::__idt> __x, basic_string_view<_CharT, _Traits> __y) noexcept { return __x.compare(__y) < 0; } template - constexpr bool + /*constexpr*/ bool operator> (basic_string_view<_CharT, _Traits> __x, basic_string_view<_CharT, _Traits> __y) noexcept { return __x.compare(__y) > 0; } template - constexpr bool + /*constexpr*/ bool operator> (basic_string_view<_CharT, _Traits> __x, __detail::__idt> __y) noexcept { return __x.compare(__y) > 0; } template - constexpr bool + /*constexpr*/ bool operator> (__detail::__idt> __x, basic_string_view<_CharT, _Traits> __y) noexcept { return __x.compare(__y) > 0; } template - constexpr bool + /*constexpr*/ bool operator<=(basic_string_view<_CharT, _Traits> __x, basic_string_view<_CharT, _Traits> __y) noexcept { return __x.compare(__y) <= 0; } template - constexpr bool + /*constexpr*/ bool operator<=(basic_string_view<_CharT, _Traits> __x, __detail::__idt> __y) noexcept { return __x.compare(__y) <= 0; } template - constexpr bool + /*constexpr*/ bool operator<=(__detail::__idt> __x, basic_string_view<_CharT, _Traits> __y) noexcept { return __x.compare(__y) <= 0; } template - constexpr bool + /*constexpr*/ bool operator>=(basic_string_view<_CharT, _Traits> __x, basic_string_view<_CharT, _Traits> __y) noexcept { return __x.compare(__y) >= 0; } template - constexpr bool + /*constexpr*/ bool operator>=(basic_string_view<_CharT, _Traits> __x, __detail::__idt> __y) noexcept { return __x.compare(__y) >= 0; } template - constexpr bool + /*constexpr*/ bool operator>=(__detail::__idt> __x, basic_string_view<_CharT, _Traits> __y) noexcept { return __x.compare(__y) >= 0; } - // [string.view.io], Inserters and extractors - template - inline basic_ostream<_CharT, _Traits>& - operator<<(basic_ostream<_CharT, _Traits>& __os, - basic_string_view<_CharT,_Traits> __str) - { return __ostream_insert(__os, __str.data(), __str.size()); } - - // basic_string_view typedef names using string_view = basic_string_view; -#ifdef _GLIBCXX_USE_WCHAR_T - using wstring_view = basic_string_view; -#endif -#ifdef _GLIBCXX_USE_C99_STDINT_TR1 - using u16string_view = basic_string_view; - using u32string_view = basic_string_view; -#endif -} // namespace fundamentals_v1 -} // namespace experimental - - - // [string.view.hash], hash support: - template - struct hash; - - template<> - struct hash - : public __hash_base - { - size_t - operator()(const experimental::string_view& __str) const noexcept - { return std::_Hash_impl::hash(__str.data(), __str.length()); } - }; - - template<> - struct __is_fast_hash> : std::false_type - { }; +} /* namespace gdb */ -#ifdef _GLIBCXX_USE_WCHAR_T - template<> - struct hash - : public __hash_base - { - size_t - operator()(const experimental::wstring_view& __s) const noexcept - { return std::_Hash_impl::hash(__s.data(), - __s.length() * sizeof(wchar_t)); } - }; - - template<> - struct __is_fast_hash> : std::false_type - { }; -#endif - -#ifdef _GLIBCXX_USE_C99_STDINT_TR1 - template<> - struct hash - : public __hash_base - { - size_t - operator()(const experimental::u16string_view& __s) const noexcept - { return std::_Hash_impl::hash(__s.data(), - __s.length() * sizeof(char16_t)); } - }; +#include "gdb_string_view.tcc" - template<> - struct __is_fast_hash> : std::false_type - { }; +#endif // __cplusplus < 201703L - template<> - struct hash - : public __hash_base - { - size_t - operator()(const experimental::u32string_view& __s) const noexcept - { return std::_Hash_impl::hash(__s.data(), - __s.length() * sizeof(char32_t)); } - }; - - template<> - struct __is_fast_hash> : std::false_type - { }; -#endif - -namespace experimental -{ - // I added these EMSR. - inline namespace literals - { - inline namespace string_view_literals - { -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wliteral-suffix" - inline constexpr basic_string_view - operator""sv(const char* __str, size_t __len) noexcept - { return basic_string_view{__str, __len}; } - -#ifdef _GLIBCXX_USE_WCHAR_T - inline constexpr basic_string_view - operator""sv(const wchar_t* __str, size_t __len) noexcept - { return basic_string_view{__str, __len}; } -#endif - -#ifdef _GLIBCXX_USE_C99_STDINT_TR1 - inline constexpr basic_string_view - operator""sv(const char16_t* __str, size_t __len) noexcept - { return basic_string_view{__str, __len}; } - - inline constexpr basic_string_view - operator""sv(const char32_t* __str, size_t __len) noexcept - { return basic_string_view{__str, __len}; } -#endif -#pragma GCC diagnostic pop - } // namespace string_literals - } // namespace literals -} // namespace experimental - -_GLIBCXX_END_NAMESPACE_VERSION -} // namespace std - -#include - -#endif // __cplusplus <= 201103L - -#endif // _GLIBCXX_EXPERIMENTAL_STRING_VIEW +#endif /* GDB_STRING_VIEW_H */ diff --git a/gdb/common/gdb_string_view.tcc b/gdb/common/gdb_string_view.tcc index 579ecec..7df567a 100644 --- a/gdb/common/gdb_string_view.tcc +++ b/gdb/common/gdb_string_view.tcc @@ -1,5 +1,9 @@ // Components for manipulating non-owning sequences of characters -*- C++ -*- +// Note: This file has been stolen from the gcc repo +// (libstdc++-v3/include/experimental/bits/string_view.tcc) and has local +// modifications. + // Copyright (C) 2013-2018 Free Software Foundation, Inc. // // This file is part of the GNU ISO C++ Library. This library is free @@ -31,27 +35,17 @@ // N3762 basic_string_view library // -#ifndef _GLIBCXX_EXPERIMENTAL_STRING_VIEW_TCC -#define _GLIBCXX_EXPERIMENTAL_STRING_VIEW_TCC 1 - -#pragma GCC system_header - -#if __cplusplus >= 201402L - -namespace std _GLIBCXX_VISIBILITY(default) -{ -_GLIBCXX_BEGIN_NAMESPACE_VERSION +#ifndef GDB_STRING_VIEW_TCC +#define GDB_STRING_VIEW_TCC 1 -namespace experimental -{ -inline namespace fundamentals_v1 +namespace gdb { template - constexpr typename basic_string_view<_CharT, _Traits>::size_type + /*constexpr*/ typename basic_string_view<_CharT, _Traits>::size_type basic_string_view<_CharT, _Traits>:: find(const _CharT* __str, size_type __pos, size_type __n) const noexcept { - __glibcxx_requires_string_len(__str, __n); + gdb_assert (__str != nullptr || __n == 0); if (__n == 0) return __pos <= this->_M_len ? __pos : npos; @@ -68,7 +62,7 @@ inline namespace fundamentals_v1 } template - constexpr typename basic_string_view<_CharT, _Traits>::size_type + /*constexpr*/ typename basic_string_view<_CharT, _Traits>::size_type basic_string_view<_CharT, _Traits>:: find(_CharT __c, size_type __pos) const noexcept { @@ -84,11 +78,11 @@ inline namespace fundamentals_v1 } template - constexpr typename basic_string_view<_CharT, _Traits>::size_type + /*constexpr*/ typename basic_string_view<_CharT, _Traits>::size_type basic_string_view<_CharT, _Traits>:: rfind(const _CharT* __str, size_type __pos, size_type __n) const noexcept { - __glibcxx_requires_string_len(__str, __n); + gdb_assert (__str != nullptr || __n == 0); if (__n <= this->_M_len) { @@ -104,7 +98,7 @@ inline namespace fundamentals_v1 } template - constexpr typename basic_string_view<_CharT, _Traits>::size_type + /*constexpr*/ typename basic_string_view<_CharT, _Traits>::size_type basic_string_view<_CharT, _Traits>:: rfind(_CharT __c, size_type __pos) const noexcept { @@ -121,11 +115,11 @@ inline namespace fundamentals_v1 } template - constexpr typename basic_string_view<_CharT, _Traits>::size_type + /*constexpr*/ typename basic_string_view<_CharT, _Traits>::size_type basic_string_view<_CharT, _Traits>:: find_first_of(const _CharT* __str, size_type __pos, size_type __n) const { - __glibcxx_requires_string_len(__str, __n); + gdb_assert (__str != nullptr || __n == 0); for (; __n && __pos < this->_M_len; ++__pos) { const _CharT* __p = traits_type::find(__str, __n, @@ -137,11 +131,11 @@ inline namespace fundamentals_v1 } template - constexpr typename basic_string_view<_CharT, _Traits>::size_type + /*constexpr*/ typename basic_string_view<_CharT, _Traits>::size_type basic_string_view<_CharT, _Traits>:: find_last_of(const _CharT* __str, size_type __pos, size_type __n) const { - __glibcxx_requires_string_len(__str, __n); + gdb_assert (__str != nullptr || __n == 0); size_type __size = this->size(); if (__size && __n) { @@ -158,11 +152,11 @@ inline namespace fundamentals_v1 } template - constexpr typename basic_string_view<_CharT, _Traits>::size_type + /*constexpr*/ typename basic_string_view<_CharT, _Traits>::size_type basic_string_view<_CharT, _Traits>:: find_first_not_of(const _CharT* __str, size_type __pos, size_type __n) const { - __glibcxx_requires_string_len(__str, __n); + gdb_assert (__str != nullptr || __n == 0); for (; __pos < this->_M_len; ++__pos) if (!traits_type::find(__str, __n, this->_M_str[__pos])) return __pos; @@ -170,7 +164,7 @@ inline namespace fundamentals_v1 } template - constexpr typename basic_string_view<_CharT, _Traits>::size_type + /*constexpr*/ typename basic_string_view<_CharT, _Traits>::size_type basic_string_view<_CharT, _Traits>:: find_first_not_of(_CharT __c, size_type __pos) const noexcept { @@ -181,11 +175,11 @@ inline namespace fundamentals_v1 } template - constexpr typename basic_string_view<_CharT, _Traits>::size_type + /*constexpr*/ typename basic_string_view<_CharT, _Traits>::size_type basic_string_view<_CharT, _Traits>:: find_last_not_of(const _CharT* __str, size_type __pos, size_type __n) const { - __glibcxx_requires_string_len(__str, __n); + gdb_assert (__str != nullptr || __n == 0); size_type __size = this->_M_len; if (__size) { @@ -202,7 +196,7 @@ inline namespace fundamentals_v1 } template - constexpr typename basic_string_view<_CharT, _Traits>::size_type + /*constexpr*/ typename basic_string_view<_CharT, _Traits>::size_type basic_string_view<_CharT, _Traits>:: find_last_not_of(_CharT __c, size_type __pos) const noexcept { @@ -220,12 +214,6 @@ inline namespace fundamentals_v1 } return npos; } -} // namespace fundamentals_v1 -} // namespace experimental - -_GLIBCXX_END_NAMESPACE_VERSION -} // namespace std - -#endif // __cplusplus <= 201103L +} // namespace gdb -#endif // _GLIBCXX_EXPERIMENTAL_STRING_VIEW_TCC +#endif // GDB_STRING_VIEW_TCC