[3/3] Remove usage of VEC(char_ptr) in gdbscm_parse_function_args
Commit Message
On 2018-04-01 12:29 PM, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:
>
> Simon> From: Simon Marchi <simon.marchi@polymtl.ca>
> Simon> This is a straightforward replacement, no change in behavior are
> Simon> intended/expected.
>
> Simon> This is the last usage of VEC(char_ptr), so it can now be removed.
>
> I think perhaps the char_ptr typedef could be removed now too.
>
> Tom
>
Indeed! I pushed this:
From ec1f2d91e07522a77cbef7a438e132ff4a2a7839 Mon Sep 17 00:00:00 2001
From: Simon Marchi <simon.marchi@polymtl.ca>
Date: Sun, 1 Apr 2018 14:23:17 -0400
Subject: [PATCH] Remove char_ptr typedef
Now that all instances of VEC(char_ptr) are gone, we can remove the
typedef. There is just one usage left, that is trivial to replace.
Tested by rebuilding on an enable-targets=all build.
gdb/ChangeLog:
* common/gdb_vecs.h (char_ptr): Remove.
* tracepoint.c (encode_actions_1): Remove usage of char_ptr.
---
gdb/ChangeLog | 5 +++++
gdb/common/gdb_vecs.h | 1 -
gdb/tracepoint.c | 2 +-
3 files changed, 6 insertions(+), 2 deletions(-)
Comments
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
Simon> Indeed! I pushed this:
Thanks for doing this.
Tom
@@ -1,3 +1,8 @@
+2018-04-01 Simon Marchi <simon.marchi@polymtl.ca>
+
+ * common/gdb_vecs.h (char_ptr): Remove.
+ * tracepoint.c (encode_actions_1): Remove usage of char_ptr.
+
2018-03-30 Simon Marchi <simon.marchi@polymtl.ca>
* guile/scm-utils.c (gdbscm_parse_function_args): Replace VEC
@@ -22,7 +22,6 @@
#include "vec.h"
-typedef char *char_ptr;
typedef const char *const_char_ptr;
DEF_VEC_P (const_char_ptr);
@@ -1382,7 +1382,7 @@ encode_actions_1 (struct command_line *action,
case OP_VAR_VALUE:
{
struct symbol *sym = exp->elts[2].symbol;
- char_ptr name = (char_ptr) SYMBOL_NATURAL_NAME (sym);
+ const char *name = SYMBOL_NATURAL_NAME (sym);
collect->collect_symbol (exp->elts[2].symbol,
target_gdbarch (),