From patchwork Mon Mar 19 11:03:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wilco Dijkstra X-Patchwork-Id: 26373 Received: (qmail 84155 invoked by alias); 19 Mar 2018 11:03:42 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 84139 invoked by uid 89); 19 Mar 2018 11:03:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR02-HE1-obe.outbound.protection.outlook.com From: Wilco Dijkstra To: Siddhesh Poyarekar , Florian Weimer , "libc-alpha@sourceware.org" CC: nd Subject: Re: [PATCH] Use correct includes in benchtests Date: Mon, 19 Mar 2018 11:03:31 +0000 Message-ID: References: <4ede91d4-1265-1d43-a10f-6b101969f4f4@redhat.com>, In-Reply-To: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Wilco.Dijkstra@arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB6PR0801MB1637; 7:CVVJFRxG/Q5ov40fLz/WbFufMUsS3l84AwWigYKn/IeGWzaGdYaUuYDkRMvctxMvjNwIsd/2x21gwh7Ibi1OezawsnnkWXYfmGzN5xJEs7x4M/TEDBaTII2iQ17/IiH59hRaaO7MJe1OAjkiphZTosBZcyahpaGFTquEqW0uaast3IIRWuf6SGm4nEXDK9Vti4qBA9FGDf9bE/HYH00kxsWgkVFrwH85l9by3pJQ/WKK0AGFqNVBoX9jQag/ru+8 x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: f2e13c67-ede7-4b8d-8e95-08d58d890d47 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(2017052603328)(7153060)(7193020); SRVR:DB6PR0801MB1637; x-ms-traffictypediagnostic: DB6PR0801MB1637: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(250305191791016)(180628864354917)(22074186197030); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(3231221)(944501244)(52105095)(10201501046)(6055026)(6041310)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(6072148)(201708071742011); SRVR:DB6PR0801MB1637; BCL:0; PCL:0; RULEID:; SRVR:DB6PR0801MB1637; x-forefront-prvs: 06167FAD59 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(346002)(39380400002)(376002)(396003)(366004)(39860400002)(377424004)(189003)(199004)(54534003)(26005)(5250100002)(2501003)(6506007)(14454004)(55016002)(110136005)(9686003)(74316002)(76176011)(102836004)(2906002)(8936002)(7696005)(6306002)(6436002)(6246003)(305945005)(53936002)(99286004)(66066001)(478600001)(3660700001)(33656002)(105586002)(7736002)(93886005)(25786009)(3846002)(2950100002)(106356001)(97736004)(72206003)(8676002)(81166006)(81156014)(2900100001)(4326008)(316002)(3280700002)(5660300001)(6116002)(86362001)(575784001)(68736007)(229853002)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0801MB1637; H:DB6PR0801MB2053.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: ENR8y0djgWQfK+fAJFzbhK+sMGAiAfCseWZLX0/EvFA9Ta6fMFjaOjACzHQ45taunluNExjJSAxGVW77oMNRfnJsONTRzpLJhjhjkOVqaJQpQGIGR0T25RHQiKwHxj9ry9biM6FyMjh0WoimRhMTdgTAOhxnoF/vX4/2B/y5dyo85grBpOxwef4fw75alMjgXMNTYt8J0Un0AOXXQjb75xlvHRl/xNm6y0jWHTwdgKllYE6l9CoZSIzx/VZJFTPkf07h25Yy4k42HqZsdNaZL2CeE9rVyQZ3acGW9LkU0TLAsLBO9XIPK525DFVNfn41c2NRLD297aPyzkx6bt+uLQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: f2e13c67-ede7-4b8d-8e95-08d58d890d47 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Mar 2018 11:03:31.4528 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1637 Siddhesh Poyarekar wrote: > There's a bench-timing.h change in f1c8185d345 that wasn't part of the > posted patch, that's what is causing the breakage. That's necessary to fix the use of the attribute by hp-timing.h in some configurations. I've added the undefine which should fix it for all cases: Add an undefine of attribute_hidden since it may be defined in some cases (it must be defined since it is used by some hp-timing configurations). ChangeLog: 2018-03-19 Wilco Dijkstra * benchtests/bench-timing.h (attribute_hidden): Undefine. diff --git a/benchtests/bench-timing.h b/benchtests/bench-timing.h index b9ea04bb02c531f2025ee502c2874bc34dddade6..96cde1e8be2e0c2f40eb80159375dc89ca6a3376 100644 --- a/benchtests/bench-timing.h +++ b/benchtests/bench-timing.h @@ -16,6 +16,7 @@ License along with the GNU C Library; if not, see . */ +#undef attribute_hidden #define attribute_hidden #include #include