Patchwork Use correct includes in benchtests

login
register
mail settings
Submitter Wilco Dijkstra
Date March 19, 2018, 11:03 a.m.
Message ID <DB6PR0801MB20536B2705F04688D0260D3883D40@DB6PR0801MB2053.eurprd08.prod.outlook.com>
Download mbox | patch
Permalink /patch/26373/
State New
Headers show

Comments

Wilco Dijkstra - March 19, 2018, 11:03 a.m.
Siddhesh Poyarekar wrote:

> There's a bench-timing.h change in f1c8185d345 that wasn't part of the
> posted patch, that's what is causing the breakage.

That's necessary to fix the use of the attribute by hp-timing.h in some
configurations. I've added the undefine which should fix it for all cases:

Add an undefine of attribute_hidden since it may be defined in some cases
(it must be defined since it is used by some hp-timing configurations).

ChangeLog:
2018-03-19  Wilco Dijkstra  <wdijkstr@arm.com>

	* benchtests/bench-timing.h (attribute_hidden): Undefine.
--
Florian Weimer - March 19, 2018, 11:09 a.m.
On 03/19/2018 12:03 PM, Wilco Dijkstra wrote:
> 	* benchtests/bench-timing.h (attribute_hidden): Undefine.

Okay, please commit.

Thanks,
Florian

Patch

diff --git a/benchtests/bench-timing.h b/benchtests/bench-timing.h
index b9ea04bb02c531f2025ee502c2874bc34dddade6..96cde1e8be2e0c2f40eb80159375dc89ca6a3376 100644
--- a/benchtests/bench-timing.h
+++ b/benchtests/bench-timing.h
@@ -16,6 +16,7 @@ 
    License along with the GNU C Library; if not, see
    <http://www.gnu.org/licenses/>.  */
 
+#undef attribute_hidden
 #define attribute_hidden
 #include <hp-timing.h>
 #include <stdint.h>