From patchwork Fri Mar 9 15:44:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wilco Dijkstra X-Patchwork-Id: 26250 Received: (qmail 7418 invoked by alias); 9 Mar 2018 15:44:55 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 7405 invoked by uid 89); 9 Mar 2018 15:44:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_ASCII_DIVIDERS, KAM_LOTSOFHASH, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 spammy=hp0, million, 19707, 0535 X-HELO: EUR01-HE1-obe.outbound.protection.outlook.com From: Wilco Dijkstra To: "libc-alpha@sourceware.org" CC: nd Subject: [PATCH 1/6] Remove slow paths from sin/cos Date: Fri, 9 Mar 2018 15:44:49 +0000 Message-ID: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Wilco.Dijkstra@arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB6PR0801MB2085; 6:r+83dTfhEw+jFJ/+67ZT7Bm0f4jtY8Fi5X9j+pE3jrOsZZzi2wFVQIYT5CW0JbcBT2xJqpYEh12NwvbSqyI/hgrIaizghX4H1TnOT/0Q1zgIOC9gue2WumlRpNcRcM2yQZ9l4OGAMgvOJT3mi4fM02wdkKYTN93fjIj9jBT6bnhiHaTFbCCLkUOvmyY021a1p0ZUB1Wva9nRjSK6blxiX7QzkYZijwPTLz3kSSBk2mJT3UgVzW1fXth9GJJbcSFldRw7lvrDqN2VNWcWxH+Y3vhcbnbsqBCKkIBKcZqeUrlLp7tI1f1LbqF52yrET+eP2/33kTYu2aVx5u+8v2giMOrHNZiV14Bi98zQogwqbFTsRB6wD5blKSQWCRn44uVK; 5:XfQaWHlYR8PCV/xDH16UH7aahUQ5gJojHHkC8UpqaHFdEjwGNYk38TaJwAXIuifmsuBF9fzZFX1NGUiCWAm68V0tRbFIRDqYpgCe313z3SPm79g9K6l38kCFzUX1oN923+y9FWF9GU+05/3TfitxtL2lI+7zn9hJPfABu9ZGfTE=; 24:GgwJvmJyRsRb0OwdR0iAMjh6/1fbmUVdb68bm+HZffz0KWyBqxe7skt1J1dczniVa9PfSpgflB4fyY+t5fgAz2WzsJvlbJ647XuB2WIyP9U=; 7:JFFQIB7/ByjYQQIzXlMhG4o+5jlFZSeomPRUcj21qLTUdjjqp4LEikIGLz3vMhHeo+Xu6ZT1+i9NFhGpNCMWIBqn2mg6XQc6tS0TrqMHGk2mqPdglfRHQf5ek8MHc/u92BnpYnnktDKIClSWwBKa89FWeYRAk2/T/T4r0zLRPhkivDhs5mHxS90LmWwauNKLySicjvTUjezyylx3PniJ8seA5hFGHWeJbn5IKI131Nc0KGxUuUvWv/c/gky/8ZGh x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 2735e276-37f9-4e82-fe2f-08d585d4b138 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(2017052603328)(7153060)(7193020); SRVR:DB6PR0801MB2085; x-ms-traffictypediagnostic: DB6PR0801MB2085: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(3231220)(944501244)(52105095)(10201501046)(6055026)(6041310)(20161123558120)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011); SRVR:DB6PR0801MB2085; BCL:0; PCL:0; RULEID:; SRVR:DB6PR0801MB2085; x-forefront-prvs: 0606BBEB39 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(346002)(376002)(396003)(366004)(39380400002)(189003)(199004)(54534003)(377424004)(5660300001)(97736004)(2351001)(106356001)(478600001)(3660700001)(3280700002)(6916009)(81156014)(81166006)(8936002)(8676002)(575784001)(14454004)(7696005)(316002)(86362001)(26005)(72206003)(3846002)(99286004)(6116002)(2501003)(5250100002)(4326008)(25786009)(53936002)(6506007)(105586002)(102836004)(2900100001)(59450400001)(305945005)(68736007)(7736002)(66066001)(2906002)(9686003)(74316002)(5640700003)(55016002)(33656002)(6436002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0801MB2085; H:DB6PR0801MB2053.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: +5Po549fNoCAMfzFNGl2NwY7EnZD0pU9nqILq1kijexQT6IzLbhwWc914ioBeMx/XxhhaeLy6QblXtUr7cc1O18HvVUS6U9V1aqKZDk/7KdLB2CsKST+WhrA2SD94AW74kZCZanEUYroLWyiN1sUs8YFVNYrY3JIVo7mbJa+SkoEKhqCeZqJn+NRe2Wl+TOdboCROq/2yPPJktJB09Anr38NMQM+RM90uunkaT17P8Pa3o63ulKtbA+WWWDbIinh+m8+zv/VTnPp5C3lrgzadJs/evnNjluW+fevYktr1QDEDf3fK7SEXHnK2HtxzFICqef+c60kOJB3bMSB4DGRFg== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2735e276-37f9-4e82-fe2f-08d585d4b138 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Mar 2018 15:44:49.5187 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB2085 This series of patches removes the slow patchs from sin, cos and sincos. Besides greatly simplifying the implementation, the new version is also much faster for inputs up to PI (41% faster) and for large inputs needing range reduction (27% faster). ULP is ~0.55 with no errors found after testing 1.6 billion inputs across most of the range with mpsin and mpcos. The number of incorrectly rounded results (ie. ULP >0.5) is at most ~2750 per million inputs between 0.125 and 0.5, the average is ~850 per million between 0 and PI. Tested on AArch64 and x86_64 with no regressions. The first patch removes the slow paths for the cases where the input is small and doesn't require range reduction. Update ULP tables for sin, cos and sincos on AArch64 and x86_64. ChangeLog: 2018-03-09 Wilco Dijkstra * sysdeps/aarch64/libm-test-ulps: Update ULP for sin, cos, sincos. * sysdeps/ieee754/dbl-64/s_sin.c (__sin): Remove slow paths for small inputs. (__cos): Likewise. * sysdeps/x86_64/fpu/libm-test-ulps: Update ULP for sin, cos, sincos. diff --git a/sysdeps/aarch64/libm-test-ulps b/sysdeps/aarch64/libm-test-ulps index 1f469803be59bb4813370d95c6d091de901e6129..be06085154db24c8fd6cf1bce417028a959aaa27 100644 --- a/sysdeps/aarch64/libm-test-ulps +++ b/sysdeps/aarch64/libm-test-ulps @@ -1012,7 +1012,9 @@ ildouble: 2 ldouble: 2 Function: "cos": +double: 1 float: 1 +idouble: 1 ifloat: 1 ildouble: 1 ldouble: 1 @@ -1970,7 +1972,9 @@ ildouble: 2 ldouble: 2 Function: "sin": +double: 1 float: 1 +idouble: 1 ifloat: 1 ildouble: 1 ldouble: 1 @@ -2000,7 +2004,9 @@ ildouble: 3 ldouble: 3 Function: "sincos": +double: 1 float: 1 +idouble: 1 ifloat: 1 ildouble: 1 ldouble: 1 diff --git a/sysdeps/ieee754/dbl-64/s_sin.c b/sysdeps/ieee754/dbl-64/s_sin.c index 8c589cbd4ab7451a5889e9a474bf4bd36c49d498..9673a461ac592fc2bf3babc755dae336312e4c56 100644 --- a/sysdeps/ieee754/dbl-64/s_sin.c +++ b/sysdeps/ieee754/dbl-64/s_sin.c @@ -448,7 +448,7 @@ SECTION #endif __sin (double x) { - double xx, res, t, cor; + double xx, t, cor; mynumber u; int4 k, m; double retval = 0; @@ -471,26 +471,22 @@ __sin (double x) xx = x * x; /* Taylor series. */ t = POLYNOMIAL (xx) * (xx * x); - res = x + t; - cor = (x - res) + t; - retval = (res == res + 1.07 * cor) ? res : slow (x); + /* Max ULP of x + t is 0.535. */ + retval = x + t; } /* else if (k < 0x3fd00000) */ /*---------------------------- 0.25<|x|< 0.855469---------------------- */ else if (k < 0x3feb6000) { - res = do_sin (x, 0, &cor); - retval = (res == res + 1.096 * cor) ? res : slow1 (x); - retval = __copysign (retval, x); + /* Max ULP is 0.548. */ + retval = __copysign (do_sin (x, 0, &cor), x); } /* else if (k < 0x3feb6000) */ /*----------------------- 0.855469 <|x|<2.426265 ----------------------*/ else if (k < 0x400368fd) { - t = hp0 - fabs (x); - res = do_cos (t, hp1, &cor); - retval = (res == res + 1.020 * cor) ? res : slow2 (x); - retval = __copysign (retval, x); + /* Max ULP is 0.51. */ + retval = __copysign (do_cos (t, hp1, &cor), x); } /* else if (k < 0x400368fd) */ #ifndef IN_SINCOS @@ -541,7 +537,7 @@ SECTION #endif __cos (double x) { - double y, xx, res, cor, a, da; + double y, xx, cor, a, da; mynumber u; int4 k, m; @@ -561,8 +557,8 @@ __cos (double x) else if (k < 0x3feb6000) { /* 2^-27 < |x| < 0.855469 */ - res = do_cos (x, 0, &cor); - retval = (res == res + 1.020 * cor) ? res : cslow2 (x); + /* Max ULP is 0.51. */ + retval = do_cos (x, 0, &cor); } /* else if (k < 0x3feb6000) */ else if (k < 0x400368fd) @@ -571,20 +567,12 @@ __cos (double x) a = y + hp1; da = (y - a) + hp1; xx = a * a; + /* Max ULP is 0.501 if xx < 0.01588 or 0.518 otherwise. + Range reduction uses 106 bits here which is sufficient. */ if (xx < 0.01588) - { - res = TAYLOR_SIN (xx, a, da, cor); - cor = 1.02 * cor + __copysign (1.0e-31, cor); - retval = (res == res + cor) ? res : sloww (a, da, x, true); - } + retval = TAYLOR_SIN (xx, a, da, cor); else - { - res = do_sin (a, da, &cor); - cor = 1.035 * cor + __copysign (1.0e-31, cor); - retval = ((res == res + cor) ? __copysign (res, a) - : sloww1 (a, da, x, true)); - } - + retval = __copysign (do_sin (a, da, &cor), a); } /* else if (k < 0x400368fd) */ diff --git a/sysdeps/x86_64/fpu/libm-test-ulps b/sysdeps/x86_64/fpu/libm-test-ulps index 48e53f7ef2cf814d71d5d0c9f2bb907f594aa7ef..bbb8a4d0754dbe6665682cd8a7f51f7319a14014 100644 --- a/sysdeps/x86_64/fpu/libm-test-ulps +++ b/sysdeps/x86_64/fpu/libm-test-ulps @@ -1262,7 +1262,9 @@ ildouble: 1 ldouble: 1 Function: "cos": +double: 1 float128: 1 +idouble: 1 ifloat128: 1 ildouble: 1 ldouble: 1 @@ -2528,7 +2530,9 @@ Function: "pow_vlen8_avx2": float: 3 Function: "sin": +double: 1 float128: 1 +idouble: 1 ifloat128: 1 ildouble: 1 ldouble: 1 @@ -2578,7 +2582,9 @@ Function: "sin_vlen8_avx2": float: 1 Function: "sincos": +double: 1 float128: 1 +idouble: 1 ifloat128: 1 ildouble: 1 ldouble: 1