From patchwork Wed Mar 7 15:53:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Hayward X-Patchwork-Id: 26225 Received: (qmail 70786 invoked by alias); 7 Mar 2018 15:53:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 70768 invoked by uid 89); 7 Mar 2018 15:53:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.7 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_LOTSOFHASH, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 spammy=so!, Hx-languages-length:2640 X-HELO: EUR01-VE1-obe.outbound.protection.outlook.com Received: from mail-ve1eur01on0072.outbound.protection.outlook.com (HELO EUR01-VE1-obe.outbound.protection.outlook.com) (104.47.1.72) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 Mar 2018 15:53:45 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) by AM3PR08MB0229.eurprd08.prod.outlook.com (10.161.35.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.548.13; Wed, 7 Mar 2018 15:53:42 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::fc60:4b4d:7de8:f8b7]) by AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::fc60:4b4d:7de8:f8b7%16]) with mapi id 15.20.0548.016; Wed, 7 Mar 2018 15:53:41 +0000 From: Alan Hayward To: "gdb-patches@sourceware.org" CC: nd Subject: [PATCH] Remove MAX_REGISTER_SIZE define Date: Wed, 7 Mar 2018 15:53:41 +0000 Message-ID: <5761B350-C237-4774-A305-B12193EF8577@arm.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM3PR08MB0229; 7:TfaxLBlwKbwH6u/vsw8RblvLRXO66ofx57PyeDnBVvm/O97EX7+8DY0Gx5ESkdcxKw3qK2q4kkZ1ySxaiVotgv4Q7AfPCgvTL4OAeZTBkE8GMEQhMYH4uUlPW4n0/GOhGhWjzzL+/qu7tDdaK1dOiawiyU/u2D5L9W8eo6DdGPqCoaCYJOimmETCHtRZi60oTiyFdiDMThbgp1PE3qRQbv2DB1AF7EpC6RwE7cwY0elxAjl6uOxXBBQKSJ6epxc1 x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: bff44e55-7994-45cd-df46-08d5844399bb x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM3PR08MB0229; x-ms-traffictypediagnostic: AM3PR08MB0229: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040501)(2401047)(5005006)(8121501046)(10201501046)(3231220)(944501244)(52105095)(3002001)(93006095)(93001095)(6055026)(6041288)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011); SRVR:AM3PR08MB0229; BCL:0; PCL:0; RULEID:; SRVR:AM3PR08MB0229; x-forefront-prvs: 0604AFA86B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39380400002)(346002)(376002)(396003)(39860400002)(366004)(377424004)(199004)(189003)(26005)(25786009)(4326008)(5640700003)(33656002)(6486002)(6436002)(2501003)(5250100002)(305945005)(7736002)(53936002)(186003)(6512007)(6116002)(3846002)(97736004)(68736007)(14454004)(316002)(6916009)(102836004)(6506007)(72206003)(478600001)(2906002)(106356001)(2351001)(8936002)(3280700002)(83716003)(66066001)(99286004)(86362001)(575784001)(81156014)(81166006)(105586002)(36756003)(2900100001)(8676002)(82746002)(1857600001)(3660700001)(5660300001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM3PR08MB0229; H:AM3PR08MB0101.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: dr1NkjnD22JgpAhePB138tADI/bj9uetWZ791YvAZHUkrDuDS4xCo00ts/ZW40mmwUv8w85d2NOZdObd46XuxofzgaFpusj8grcGy8ygl4H3B8Inn6or94HYHtG/kRSDgg84shxGK1f1OC1owGx0hscniD9qjTKH0DVxDGcWtmD8/5NoMfotQELKKwlNZVyY3P23KWCTjOrBbZ+1PhC867P4tM0Q7pD35vNRufB4Xg+uHg9DK6kiZOasQdtxk9veJ5kceNWp9HRu0U/k5GQsgzrAZmHtCTJqTmUtf4TKmN6I94tMILh7ttzb+LhQMiF5AXqdqrfdV5NuMeUcMg5Rnw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-ID: <1116350802934F46B49E9A28B9155682@eurprd08.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: bff44e55-7994-45cd-df46-08d5844399bb X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Mar 2018 15:53:41.8913 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0229 X-IsSubscribed: yes Many thanks to Yao for helping me remove all the other uses of MAX_REGISTER_SIZE over the last year or so! This patch removes the last uses of MAX_REGISTER_SIZE and deletes the define. Built on x86 and aarch64. Grepped to ensured no more stray MAX_REGISTER_SIZEs left in the code. Alan 2018-03-07 Alan Hayward * defs.h: Remove MAX_REGISTER_SIZE * regcache.c (init_regcache_descr): Remove MAX_REGISTER_SIZE asserts. * python/py-unwind.c (pyuw_sniffer): Likewise. diff --git a/gdb/defs.h b/gdb/defs.h index a924573b57f8322f7b674c0bf0f749ab318983e2..91988758a3a8fb5125624381dfa0277730c6c373 100644 --- a/gdb/defs.h +++ b/gdb/defs.h @@ -531,11 +531,6 @@ enum symbol_needs_kind /* Dynamic target-system-dependent parameters for GDB. */ #include "gdbarch.h" -/* * Maximum size of a register. Something small, but large enough for - all known ISAs. If it turns out to be too small, make it bigger. */ - -enum { MAX_REGISTER_SIZE = 64 }; - /* In findvar.c. */ template> diff --git a/gdb/python/py-unwind.c b/gdb/python/py-unwind.c index a7e3a93ebc48c58661a14c73bd4618d47ffbb81b..906a00447e691bd248ec3a83bd54b80b6b85eeff 100644 --- a/gdb/python/py-unwind.c +++ b/gdb/python/py-unwind.c @@ -583,7 +583,6 @@ pyuw_sniffer (const struct frame_unwind *self, struct frame_info *this_frame, /* `value' validation was done before, just assert. */ gdb_assert (value != NULL); gdb_assert (data_size == TYPE_LENGTH (value_type (value))); - gdb_assert (data_size <= MAX_REGISTER_SIZE); cached_frame->reg[i].data = (gdb_byte *) xmalloc (data_size); memcpy (cached_frame->reg[i].data, value_contents (value), data_size); diff --git a/gdb/regcache.c b/gdb/regcache.c index c73582f66ae38f288b9b68d6d054a7f82ac16e60..ebd0fd3d5f786ad35a80b7ef4aeb445036aae92e 100644 --- a/gdb/regcache.c +++ b/gdb/regcache.c @@ -117,7 +117,6 @@ init_regcache_descr (struct gdbarch *gdbarch) descr->sizeof_register[i] = TYPE_LENGTH (descr->register_type[i]); descr->register_offset[i] = offset; offset += descr->sizeof_register[i]; - gdb_assert (MAX_REGISTER_SIZE >= descr->sizeof_register[i]); } /* Set the real size of the raw register cache buffer. */ descr->sizeof_raw_registers = offset; @@ -127,7 +126,6 @@ init_regcache_descr (struct gdbarch *gdbarch) descr->sizeof_register[i] = TYPE_LENGTH (descr->register_type[i]); descr->register_offset[i] = offset; offset += descr->sizeof_register[i]; - gdb_assert (MAX_REGISTER_SIZE >= descr->sizeof_register[i]); } /* Set the real size of the readonly register cache buffer. */ descr->sizeof_cooked_registers = offset;