From patchwork Tue Mar 6 15:54:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 26214 Received: (qmail 7607 invoked by alias); 6 Mar 2018 15:54:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 7593 invoked by uid 89); 6 Mar 2018 15:54:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.2 spammy=HX-ClientProxiedBy:1096 X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 06 Mar 2018 15:54:40 +0000 Received: from ESESSHC024.ericsson.se (Unknown_Domain [153.88.183.90]) by sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id 8A.9F.11615.DB9BE9A5; Tue, 6 Mar 2018 16:54:37 +0100 (CET) Received: from ESESBMB505.ericsson.se (153.88.183.172) by ESESSHC024.ericsson.se (153.88.183.90) with Microsoft SMTP Server (TLS) id 14.3.352.0; Tue, 6 Mar 2018 16:54:37 +0100 Received: from ESESBMB505.ericsson.se (153.88.183.172) by ESESBMB505.ericsson.se (153.88.183.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.26; Tue, 6 Mar 2018 16:54:36 +0100 Received: from NAM03-DM3-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB505.ericsson.se (153.88.183.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.26 via Frontend Transport; Tue, 6 Mar 2018 16:54:36 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from elxacz23q12.ca.am.ericsson.se (192.75.88.130) by DM5PR1501MB2005.namprd15.prod.outlook.com (2603:10b6:4:a1::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.548.15; Tue, 6 Mar 2018 15:54:32 +0000 From: Simon Marchi To: CC: Simon Marchi Subject: [PATCH] remote-stdio-gdbserver: Pass "target" to remote_exec to delete file Date: Tue, 6 Mar 2018 10:54:11 -0500 Message-ID: <1520351651-8210-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 X-ClientProxiedBy: KL1PR0601CA0019.apcprd06.prod.outlook.com (2603:1096:802:1::29) To DM5PR1501MB2005.namprd15.prod.outlook.com (2603:10b6:4:a1::35) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d31d53de-802e-4fc9-9f93-08d5837a8eb8 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DM5PR1501MB2005; X-Microsoft-Exchange-Diagnostics: 1; DM5PR1501MB2005; 3:7J7m8bcX7aGPIQIWriOqFgaO1INSZfVveN8NannOITcfgFJkWO0c1xy+sg6uHMS7P5yux+GChTFsAgVyX77+SKZrvK2jcwnIKxXButSc9hFQ5BD2SNIaXjoT+YQ6jE8Hjc3ZVMvpxx2Jklw+nOpPEp+TOTfOi1/MnF/k6yx7Jpv6Y/STPgByVmLocXlADsLSJRbuZrTdOqA7DiFCd34Oj/T4qs8RjPKxKQ4u0I8xCsJgz+bUQGJJhnTJgjQWSSkQ; 25:ErcUkxwOODsx0RapD+/ks66hsNqkqXw8YQ5ne/KhoDdyK0m3VTMNUmroLDn7+B/P+VnkrVMIbpHlfHcqlBtxNiS+/DwYH304p5+n8VNTfTlKhTvVkpd4XxLdi7EvuCyvOuzVXjNQMVbLuuvoq7xNq801+hqCtioZWQ1CQ6C9AjB1rQvFmEKUxwVA9410rLTkk/i/7lWLKfLFgspI0XgYQS4UCN4IXTrDwkYYAKg6//eFfJ4Ke7h+fWW8JEyQEGR9qFbi1K/OjB7niq4xCgHSWZGR8JZBOgxNY1nJW67CLToN5EtgXC0dMHZS+KW4M6A47oZHeFBImRV0HSMLOLjOEQ==; 31:wGwJ01fiQ7sA5y2nCmY0vPYDizLLZNyYObnfmI8yH/y2cVZiWAeFlOn+ysxe6PNo/GsTVXwQ+obTBUOm9/tApE++WFjCHGEygZeON9IruUQYMn0B2QiN6l25+l/bQhkApiVYDYUw+qAznSbYznjUhIREXermw/PwX4qxNM2nkEWVelDZtSrYiKgplO8JQDty5SXfY4Vk5ZWd8b1Wc6yc8wDIlKv4XofrGOMYwtveyHk= X-MS-TrafficTypeDiagnostic: DM5PR1501MB2005: X-Microsoft-Exchange-Diagnostics: 1; DM5PR1501MB2005; 20:d46TJWSV/Qv/tWaSEXPJK0Ogdns6qZ5kfK2JOe48RRQ2Jz5RNVhjXVIMpF6r+IbxDYEYLZINN6JMz02vgCXsWery52+VeFSg4epnFo+mM+5frCXpuSKS6xXdZnGnxlVdp7uXB5S13ueAWkRS1wSWEFdhvmydvz6X8PVuNfGirrYOdyO3s/OlFBWkD9NH5OyZLBwqE2k3+j+cgtXdCKxOb6QKP8fFH+7thKVZSLDsYRrPtysG2s0s45WMjReqDAUjHLM+wsqWK094fbhHTvwa25BCqpFRABV+dQxb0n32eUPUOCUJRnkC7DVO0+zFhJJU2gySHq+sj10PhiFcAkpeQm/t4D+ZPNyUEEv7q7A/q8wDtz/9IS/Al4fwp6EwEZaYtrRJeLQD7QfHIE+M6UXwGBBvHJNqvcRGCsVakT4SIlm3pPFMkLqSZiTebB3fdSYoCjoCGC0cTiONMw/+63rdlWygq5DcuYEZ557xQm+mMBpeWugbvdNGEsv69pKueVCP; 4:5D9o+6/j06TDUoXxk7zZggtt8VfC+F1YG4xRMXQ1NNNE/5Qwx2Fy5M0EN4hSHEazDXJ495u2nbK1mmGanUR+5eYp+N3GsX6w8ezd5lAlPftaropLrQNGbEM8jgQnt+IuLvymAGUyw2vLVXsmTnolCkXdDMeXqqiJ8vUYzp8b20fbR4NXwrj0EnZl90bro6oQw5jWtXv4YNmCyXREyRJtuv5mbQgdaZXkRFJsT0P6oQb2gLNvhlqPJ+PBkEwjeIEO/jPLFVebyJ1BK4E6fLveVw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040501)(2401047)(5005006)(8121501046)(3231220)(944501244)(52105095)(3002001)(10201501046)(93006095)(93001095)(6041288)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011); SRVR:DM5PR1501MB2005; BCL:0; PCL:0; RULEID:; SRVR:DM5PR1501MB2005; X-Forefront-PRVS: 06036BD506 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(39380400002)(376002)(366004)(346002)(39860400002)(189003)(199004)(54534003)(305945005)(186003)(16526019)(1857600001)(50466002)(316002)(478600001)(59450400001)(106356001)(966005)(2361001)(48376002)(2351001)(2906002)(86362001)(5660300001)(3846002)(36756003)(4326008)(6116002)(26005)(7736002)(25786009)(386003)(51416003)(81166006)(53936002)(6512007)(16586007)(6486002)(6666003)(107886003)(6506007)(8676002)(8936002)(81156014)(6916009)(68736007)(66066001)(105586002)(6306002)(50226002)(97736004)(52116002)(47776003); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR1501MB2005; H:elxacz23q12.ca.am.ericsson.se; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR1501MB2005; 23:6inkhXaCgB/V7XFEGDF8ZDfZYltM0h/Pn5FTaTA?= =?us-ascii?Q?LW8f1RLggC3L8o9gwNtdk19NtAS98GCiKqgm7B/JoaRhSynIr54JuUG+Phg3?= =?us-ascii?Q?ibDW0pUdzv5qZmBxQehhhlrDeGusGtCdyPNtNHyQSDhLkcdQf30Fv9hupprY?= =?us-ascii?Q?iO4tfX1eufpJ76MdZeBcN2iSk0k0Bmd/NkMfjB9MLeRiFX05VfrL4AZheTs7?= =?us-ascii?Q?/UY61RPAqiOvJlH+7COLMRb2TWbmYI8lYb5wujVuE9144n0eKFc9TyKIpS/n?= =?us-ascii?Q?yMf1BxSXcmAh1YBoXr2zoQNLx2Af0rT6ds+bxA1yEFEwUyyQFIYLB3Tvz+yi?= =?us-ascii?Q?03Ldlmb4PC04TQV+HFtlXu5jBEoTfm5TaUE66iyM4FsUJ249SiIuJn1VYPUs?= =?us-ascii?Q?6pZOsbvpLzu3YVlokSOpRCz2OGL+wWaI/mBFKYhoFJ6pYgI4oSIdafJ+AYmK?= =?us-ascii?Q?ij+PWyWZIiRB4Biyo7rqpVubQbIg23Trb/vGrKtdbmNqthvEG27Nq5c44ZQd?= =?us-ascii?Q?tqEkw+5fRArPf9cKyO5OO4/IrTWNBR5BUeXKechjrBHrLCpQjRHS0mRfD8ku?= =?us-ascii?Q?iO0cLfWhqS1Ky9j6yfnC8E4YgXvQZfjHgJ2b8RrLFcbsxS9PhFFjH15q2Zb6?= =?us-ascii?Q?iXiMKrJWIQcpJlcMhiBCB5HSfraHqZ4XzmnqrqmpjokDLbASqUBvTaF3lJj6?= =?us-ascii?Q?f6mGVc+Nd6qxHQrduVxkTd1Qaxj6FthxT5SQp3bYZZMaN/BTIMj1xRy5vIlH?= =?us-ascii?Q?3PWT0sJWqpN8u6BdcGfItSvuqCx/c6bdYm+CreajYf3RWQJkbfZcqc3CiBDp?= =?us-ascii?Q?RBUHgYZu7fm9yT6QtIj6lXzZONS5Xxe0RRypzz8HCzA85W4epQmeZEh1Aev8?= =?us-ascii?Q?rxyCgi2+m7iT0+Ch5kbdqfWIQR76AXYpx1ql0icxF6X8W1J7tOPbCWE3izW5?= =?us-ascii?Q?nuri7lmzSUiCsLc6hclb6VJmlNs5Dtwito61kBl4SYxtjShvQzOh9o9tM6YZ?= =?us-ascii?Q?+NGYqrK8inLhLXquKbwt+jip1gZLeQVdAoxY1+Tr3NNECjN2h2PzokguQYJP?= =?us-ascii?Q?bitFhoMfnsT1m/nQROfWW5gSwoVWBN24TtcINz4/uMHkDEBUK9NFGDqsCIKp?= =?us-ascii?Q?tmCt40dyS5GmWXJ07I+A74oJQtotZbxxCCoFcAAgmWEMBAzkC4fJL0bJRY2Z?= =?us-ascii?Q?jbiVFiQJc3RiWIPGtVlvhPQhgW462/6zzg5krzkTXPFZ3jc4yNPExSrBhag?= =?us-ascii?Q?=3D=3D?= X-Microsoft-Antispam-Message-Info: 1b8T//pG761JvEoJlewCZWFWHupXCZ0xE1hx4dRo8veAZz4pwpGAR5ir7zBjY0ddiexw/nMVS26geHicsok3y0WdXGQjwKz7XSEIyS+AVdtCr20Xc90PQUuovhPsuwCJArl6OMI7CRGqaTGwGTbCw5JbZMaCMn2TiKvylo13053f5nQIs08k48L2I/yE1UCk X-Microsoft-Exchange-Diagnostics: 1; DM5PR1501MB2005; 6:Tuz395r1IKkeWTr6cJMgS0ToGZDsfX57D5+Ga2vfVR6AMybSAGV3HDubUvZgyPBtbj+GGhocgbAvq7IYX4SpJCk0NVrluISrEZ1gvwyPU+8kg9IvuAi6aNM5vMMUAb+LeCM3NPpFQWPg9yufZIMjfI1CpUiBa+RU+lGmKQkIhCf2lSOjB9+6XYvk6RLSb7YPx1EeVStwO92iiqTyBRNaBHgPEWsyCgL06SUdBGrfxPl85mb6zZOAoG12RTTeRAo0Qc+5U/dyIJ3Grg9gyBl/GwSyDarpLYYA3xkXHYyOsZtw0NeskquM6wkOJ5bxkYrbKuakjF3UKvUgeu92xEe1FmDq7KAYhKrZ3VOBZR1TstE=; 5:72UYeNQ3B+wemOeqOsmzBMu+76ggyDNwTSdZxz088qDaHrUpttt8ChCEg8Jgj6h24yqwpPW6XqLZYEvhWbWwpBjl5jKaCdi1xE06yv7C1v0FpyLZmeewhH//CE2Y++Vw1mhHbJkUsoYPLr26DzyZLZZkwBl7XwavVbJhOA4TPjI=; 24:73zi9vlg8Gp9mAbnfqbtT8HzvC4CBPcnYC8VgEaqAZIEqOvhgZvBOIEv3dwgJRLYPi+OWPPmqPKqjpubPTnB/qWNSQTv0Ucnk3ZZyeUyvNw=; 7:Mo7X78hoUUibBYNYxpKYh3VhHIoLTpyZGQkTx6WaTZhkI07inV9fjjZsESSXvc571o2O2Ocrv5z00KgfypEQTfTXU4h6SdXCAZCMfRH7r9rSmg+88C3v+IDeoUQRm85VTcy0tLRnhmSlCtPVO5kZGgrh3Ixc2dHlLdqPUt/3bFEPVNJB34GsI3URT+sY98Qacs2nCp6bnx97SNQCxnCVbFqUeufmMCGzvKl747qidCKqAqoXIFl3XBRYllRFQjC+ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2018 15:54:32.6505 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d31d53de-802e-4fc9-9f93-08d5837a8eb8 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1501MB2005 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes As described here https://sourceware.org/bugzilla/show_bug.cgi?id=22841 there seems to be situations where the remote-stdio-gdbserver board fails to delete the uploaded binary file. Passing "target" fixes the issue for Christian who reported the bug. I did not experience this problem, but passing "target" to remote_exec still works for me, so I'm fine with changing it. Any objection? gdb/testsuite/ChangeLog: * boards/remote-stdio-gdbserver.exp (${board}_file): Pass "target" to remote_exec. --- gdb/testsuite/boards/remote-stdio-gdbserver.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/boards/remote-stdio-gdbserver.exp b/gdb/testsuite/boards/remote-stdio-gdbserver.exp index aff7902..d559b85 100644 --- a/gdb/testsuite/boards/remote-stdio-gdbserver.exp +++ b/gdb/testsuite/boards/remote-stdio-gdbserver.exp @@ -75,7 +75,7 @@ proc get_target_remote_pipe_cmd { } { proc ${board}_file { dest op args } { if { $op == "delete" } { - return [remote_exec [get_remote_login] "rm -f $args"] + return [remote_exec target "rm -f $args"] } return [eval [list standard_file $dest $op] $args] }