Patchwork [RFA/Darwin] Recognize .plt section

login
register
mail settings
Submitter Xavier Roirand
Date March 5, 2018, 8:54 a.m.
Message ID <1520240062-15255-1-git-send-email-roirand@adacore.com>
Download mbox | patch
Permalink /patch/26195/
State New
Headers show

Comments

Xavier Roirand - March 5, 2018, 8:54 a.m.
Use bfd section name .plt for __TEXT.__stubs so that gdb recognize this
section as a plt.

bfd/ChangeLog: Tristan Gingold  <gingold@adacore.com>

    * mach-o.c (text_section_names_xlat): Add entry for .plt.
---
 bfd/ChangeLog | 5 +++++
 bfd/mach-o.c  | 3 +++
 2 files changed, 8 insertions(+)
Yao Qi - March 5, 2018, 11:47 a.m.
Xavier Roirand <roirand@adacore.com> writes:

Hi Xavier,
this should be posted to binutils mail list.

> +2018-03-02  Tristan Gingold  <gingold@adacore.com>
> +
> +	Pushed by Xavier Roirand <roirand@adacore.com>

Nowadays, in case of author != commiter, we don't write down the name of
committer in ChangeLog.  Any reason you do so?  I noticed that you did
this in several Tristan's patches.

> +	* mach-o.c (text_section_names_xlat): Add entry for .plt.
Joel Brobecker - March 5, 2018, 11:59 a.m.
> > +2018-03-02  Tristan Gingold  <gingold@adacore.com>
> > +
> > +	Pushed by Xavier Roirand <roirand@adacore.com>
> 
> Nowadays, in case of author != commiter, we don't write down the name of
> committer in ChangeLog.  Any reason you do so?  I noticed that you did
> this in several Tristan's patches.

It's something I have been doing on occasions. The idea was that
people working from source packages alone could see who did the push.
But I'm not really attached to it, so this can be skipped if people
prefer.
Pedro Alves - March 5, 2018, 12:32 p.m.
On 03/05/2018 11:59 AM, Joel Brobecker wrote:
>>> +2018-03-02  Tristan Gingold  <gingold@adacore.com>
>>> +
>>> +	Pushed by Xavier Roirand <roirand@adacore.com>
>>
>> Nowadays, in case of author != commiter, we don't write down the name of
>> committer in ChangeLog.  Any reason you do so?  I noticed that you did
>> this in several Tristan's patches.
> 
> It's something I have been doing on occasions. The idea was that
> people working from source packages alone could see who did the push.
> But I'm not really attached to it, so this can be skipped if people
> prefer.

The GNU coding standards has section saying not to do that.  From
<https://www.gnu.org/prep/standards/standards.html>:

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
When you install someone else’s changes, put the contributor’s name in the change
log entry rather than in the text of the entry. In other words, write this:

2002-07-14  John Doe  <jdoe@gnu.org>

        * sewing.c: Make it sew.

rather than this:

2002-07-14  Usual Maintainer  <usual@gnu.org>

        * sewing.c: Make it sew.  Patch by jdoe@gnu.org.

As for the date, that should be the date you applied the change. 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Thanks,
Pedro Alves

Patch

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index e2c5789bdb..9f047d2fca 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@ 
+2018-03-02  Tristan Gingold  <gingold@adacore.com>
+
+	Pushed by Xavier Roirand <roirand@adacore.com>
+	* mach-o.c (text_section_names_xlat): Add entry for .plt.
+
 2018-03-01  Alan Modra  <amodra@gmail.com>
 
 	* elf32-ft32.c (ft32_info_to_howto_rela): Correct range test.
diff --git a/bfd/mach-o.c b/bfd/mach-o.c
index f26be0c73e..18bbd36ddd 100644
--- a/bfd/mach-o.c
+++ b/bfd/mach-o.c
@@ -96,6 +96,9 @@  static const mach_o_section_name_xlat text_section_names_xlat[] =
     {	".text",				"__text",
 	SEC_CODE | SEC_LOAD,			BFD_MACH_O_S_REGULAR,
 	BFD_MACH_O_S_ATTR_PURE_INSTRUCTIONS,	0},
+    {  ".plt",                                 "__stubs",
+	SEC_CODE | SEC_LOAD,                    BFD_MACH_O_S_SYMBOL_STUBS,
+	BFD_MACH_O_S_ATTR_PURE_INSTRUCTIONS,    0},
     {	".const",				"__const",
 	SEC_READONLY | SEC_DATA | SEC_LOAD,	BFD_MACH_O_S_REGULAR,
 	BFD_MACH_O_S_ATTR_NONE,			0},