From patchwork Sun Mar 4 01:53:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Samuel Thibault X-Patchwork-Id: 26183 Received: (qmail 90502 invoked by alias); 4 Mar 2018 01:53:46 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 90431 invoked by uid 89); 4 Mar 2018 01:53:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_HELO_PASS, SPF_NEUTRAL autolearn=ham version=3.3.2 spammy= X-HELO: hera.aquilenet.fr From: Samuel Thibault To: libc-alpha@sourceware.org Cc: Samuel Thibault Subject: [hurd, commited] hurd: Fix inclusion of mach headers in all standards Date: Sun, 4 Mar 2018 02:53:38 +0100 Message-Id: <20180304015338.16544-1-samuel.thibault@ens-lyon.org> mig_support does not actually inline the stpncpy any more. * mach/mach/mig_support.h [defined __USE_GNU]: Do not #error out. * scripts/check-installed-headers.sh: Do not ignore Hurd and Mach headers. --- ChangeLog | 3 +++ mach/mach/mig_support.h | 13 ------------- scripts/check-installed-headers.sh | 8 +------- 3 files changed, 4 insertions(+), 20 deletions(-) diff --git a/ChangeLog b/ChangeLog index 819a8db2cd..33d3008a91 100644 --- a/ChangeLog +++ b/ChangeLog @@ -20,6 +20,9 @@ * mach/Machrules ($(patsubst %,$(objpfx)%.h,$(user-interfaces)): Process mig output through $(migheadersed). * hurd/Makefile (migheadersed): Define variable. + * mach/mach/mig_support.h [defined __USE_GNU]: Do not #error out. + * scripts/check-installed-headers.sh: Do not ignore Hurd and Mach + headers. 2018-03-03 Andreas Schwab diff --git a/mach/mach/mig_support.h b/mach/mach/mig_support.h index 56ec6dfab8..fc17062b6a 100644 --- a/mach/mach/mig_support.h +++ b/mach/mach/mig_support.h @@ -26,19 +26,6 @@ #include #include -#ifndef __USE_GNU -/* The only problem that has come up so far is __stpncpy being undeclared - below because doesn't declare it without __USE_GNU. We could - work around that problem by just adding the declaration there, or by - eliding the inline functions in the absence of __USE_GNU. But either of - these would result in unoptimized calls (because no inline version of - __stpncpy will have been defined), and there may be other niggling - problems lurking. Instead we simply insist on _GNU_SOURCE for - compiling mig output; anyway, that better reflects the fact that mig - output requires nonstandard special support code not found elsewhere. */ -# error mig stubs must be compiled with -D_GNU_SOURCE -#endif - /* MiG initialization. */ extern void __mig_init (void *__first); extern void mig_init (void *__first); diff --git a/scripts/check-installed-headers.sh b/scripts/check-installed-headers.sh index f7f55917f7..4a062e9cda 100644 --- a/scripts/check-installed-headers.sh +++ b/scripts/check-installed-headers.sh @@ -126,13 +126,7 @@ EOF fi ;; esac - ;; - - # Hurd and Mach headers are not standard anyway - (hurd.h | hurd/*.h | faultexc_server.h | \ - mach.h | mach_init.h | mach_error.h | mach-shortcuts.h | mach/* | \ - device/* | lock-intern.h | spin-lock.h | machine-sp.h) - continue;; + ;; esac echo :: "$header"