Patchwork aarch64/strcmp: fix misaligned loop jump target

login
register
mail settings
Submitter Siddhesh Poyarekar
Date Feb. 22, 2018, 9:27 a.m.
Message ID <20180222092714.22768-1-siddhesh@sourceware.org>
Download mbox | patch
Permalink /patch/25996/
State New
Headers show

Comments

Siddhesh Poyarekar - Feb. 22, 2018, 9:27 a.m.
I accidentally set the loop jump back label as misaligned8 instead of
do_misaligned.  The typo is harmless but it's always nice to not have
to unnecessarily execute those two instructions.

The fix is trivial, so I'll commit by the end of the week if nobody
objects.

	* sysdeps/aarch64/strcmp.S (do_misaligned): Jump back to
	do_misaligned, not misaligned8.
---
 sysdeps/aarch64/strcmp.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Szabolcs Nagy - Feb. 22, 2018, 11:42 a.m.
On 22/02/18 09:27, Siddhesh Poyarekar wrote:
> I accidentally set the loop jump back label as misaligned8 instead of
> do_misaligned.  The typo is harmless but it's always nice to not have
> to unnecessarily execute those two instructions.
> 
> The fix is trivial, so I'll commit by the end of the week if nobody
> objects.
> 
> 	* sysdeps/aarch64/strcmp.S (do_misaligned): Jump back to
> 	do_misaligned, not misaligned8.

OK.

> ---
>   sysdeps/aarch64/strcmp.S | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sysdeps/aarch64/strcmp.S b/sysdeps/aarch64/strcmp.S
> index 0b22f168b5..267aa4b551 100644
> --- a/sysdeps/aarch64/strcmp.S
> +++ b/sysdeps/aarch64/strcmp.S
> @@ -158,7 +158,7 @@ L(do_misaligned):
>   	ccmp	data1w, data2w, #0, cs	/* NZCV = 0b0000.  */
>   	b.ne	L(done)
>   	tst	src1, #7
> -	b.ne	L(misaligned8)
> +	b.ne	L(do_misaligned)
>   
>   L(loop_misaligned):
>   	/* Test if we are within the last dword of the end of a 4K page.  If
>

Patch

diff --git a/sysdeps/aarch64/strcmp.S b/sysdeps/aarch64/strcmp.S
index 0b22f168b5..267aa4b551 100644
--- a/sysdeps/aarch64/strcmp.S
+++ b/sysdeps/aarch64/strcmp.S
@@ -158,7 +158,7 @@  L(do_misaligned):
 	ccmp	data1w, data2w, #0, cs	/* NZCV = 0b0000.  */
 	b.ne	L(done)
 	tst	src1, #7
-	b.ne	L(misaligned8)
+	b.ne	L(do_misaligned)
 
 L(loop_misaligned):
 	/* Test if we are within the last dword of the end of a 4K page.  If