diff mbox

Move NPTL-specific code to NPTL-specific header

Message ID 20180218015341.24863-1-samuel.thibault@ens-lyon.org
State Committed, archived
Headers

Commit Message

Samuel Thibault Feb. 18, 2018, 1:53 a.m. UTC 
  * sysdeps/pthread/timer_routines.c: Include <timer_routines.h> instead
	of <nptl/pthreadP.h>
	(thread_attr_compare): Move function to...
	* sysdeps/nptl/timer_routines.h: ... new header.
---
 ChangeLog                        |  4 ++++
 sysdeps/nptl/internaltypes.h     | 25 +++++++++++++++++++++++++
 sysdeps/pthread/timer_routines.c | 27 +--------------------------
 3 files changed, 30 insertions(+), 26 deletions(-)

Comments

Samuel Thibault Feb. 18, 2018, 1:59 a.m. UTC | #1 
Samuel Thibault, on dim. 18 févr. 2018 02:53:41 +0100, wrote:
> 	* sysdeps/pthread/timer_routines.c: Include <timer_routines.h> instead
> 	of <nptl/pthreadP.h>
> 	(thread_attr_compare): Move function to...
> 	* sysdeps/nptl/timer_routines.h: ... new header.


> --- a/sysdeps/nptl/internaltypes.h

Ergl, sorry, I mangled things.

That's the problem of having to play with 3-4 repositories at the same
time...

Samuel
diff mbox

Patch

diff --git a/ChangeLog b/ChangeLog
index 4e8411f9bf..158d4f2474 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -7,6 +7,10 @@ 
 	(__ptsname_r): Move implementation to...
 	(__ptsname_internal): ... new function.  Add filling the STP
 	structure.
+	* sysdeps/pthread/timer_routines.c: Include <timer_routines.h> instead
+	of <nptl/pthreadP.h>
+	(thread_attr_compare): Move function to...
+	* sysdeps/nptl/timer_routines.h: ... new header.
 
 2018-02-17  John David Anglin  <danglin@gcc.gnu.org>
 
diff --git a/sysdeps/nptl/internaltypes.h b/sysdeps/nptl/internaltypes.h
index b29239b1dc..f216fc773a 100644
--- a/sysdeps/nptl/internaltypes.h
+++ b/sysdeps/nptl/internaltypes.h
@@ -41,6 +41,31 @@  struct pthread_attr
   size_t cpusetsize;
 };
 
+/* Compare two pthread_attr_t thread attributes for exact equality.
+   Returns 1 if they are equal, otherwise zero if they are not equal
+   or contain illegal values.  This version is NPTL-specific for
+   performance reason.  One could use the access functions to get the
+   values of all the fields of the attribute structure.  */
+static inline int
+thread_attr_compare (const pthread_attr_t *left, const pthread_attr_t *right)
+{
+  struct pthread_attr *ileft = (struct pthread_attr *) left;
+  struct pthread_attr *iright = (struct pthread_attr *) right;
+
+  return (ileft->flags == iright->flags
+	  && ileft->schedpolicy == iright->schedpolicy
+	  && (ileft->schedparam.sched_priority
+	      == iright->schedparam.sched_priority)
+	  && ileft->guardsize == iright->guardsize
+	  && ileft->stackaddr == iright->stackaddr
+	  && ileft->stacksize == iright->stacksize
+	  && ((ileft->cpuset == NULL && iright->cpuset == NULL)
+	      || (ileft->cpuset != NULL && iright->cpuset != NULL
+		  && ileft->cpusetsize == iright->cpusetsize
+		  && memcmp (ileft->cpuset, iright->cpuset,
+			     ileft->cpusetsize) == 0)));
+}
+
 #define ATTR_FLAG_DETACHSTATE		0x0001
 #define ATTR_FLAG_NOTINHERITSCHED	0x0002
 #define ATTR_FLAG_SCOPEPROCESS		0x0004
diff --git a/sysdeps/pthread/timer_routines.c b/sysdeps/pthread/timer_routines.c
index f059beb4c5..84861b9557 100644
--- a/sysdeps/pthread/timer_routines.c
+++ b/sysdeps/pthread/timer_routines.c
@@ -29,7 +29,7 @@ 
 #include <sys/syscall.h>
 
 #include "posix-timer.h"
-#include <nptl/pthreadP.h>
+#include <internaltypes.h>
 
 
 /* Number of threads used.  */
@@ -482,31 +482,6 @@  __timer_thread_wakeup (struct thread_node *thread)
 }
 
 
-/* Compare two pthread_attr_t thread attributes for exact equality.
-   Returns 1 if they are equal, otherwise zero if they are not equal
-   or contain illegal values.  This version is NPTL-specific for
-   performance reason.  One could use the access functions to get the
-   values of all the fields of the attribute structure.  */
-static int
-thread_attr_compare (const pthread_attr_t *left, const pthread_attr_t *right)
-{
-  struct pthread_attr *ileft = (struct pthread_attr *) left;
-  struct pthread_attr *iright = (struct pthread_attr *) right;
-
-  return (ileft->flags == iright->flags
-	  && ileft->schedpolicy == iright->schedpolicy
-	  && (ileft->schedparam.sched_priority
-	      == iright->schedparam.sched_priority)
-	  && ileft->guardsize == iright->guardsize
-	  && ileft->stackaddr == iright->stackaddr
-	  && ileft->stacksize == iright->stacksize
-	  && ((ileft->cpuset == NULL && iright->cpuset == NULL)
-	      || (ileft->cpuset != NULL && iright->cpuset != NULL
-		  && ileft->cpusetsize == iright->cpusetsize
-		  && memcmp (ileft->cpuset, iright->cpuset,
-			     ileft->cpusetsize) == 0)));
-}
-
 
 /* Search the list of active threads and find one which has matching
    attributes.  Global mutex lock must be held by caller.  */