From patchwork Thu Feb 8 13:49:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Metzger, Markus T" X-Patchwork-Id: 25873 Received: (qmail 2194 invoked by alias); 8 Feb 2018 13:49:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 2106 invoked by uid 89); 8 Feb 2018 13:49:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.7 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, MIME_BASE64_BLANKS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=warned X-HELO: mga12.intel.com Received: from mga12.intel.com (HELO mga12.intel.com) (192.55.52.136) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 08 Feb 2018 13:49:19 +0000 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Feb 2018 05:49:15 -0800 X-ExtLoop1: 1 Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by fmsmga002.fm.intel.com with ESMTP; 08 Feb 2018 05:49:14 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.101]) by IRSMSX109.ger.corp.intel.com ([169.254.13.19]) with mapi id 14.03.0319.002; Thu, 8 Feb 2018 13:49:13 +0000 From: "Metzger, Markus T" To: Pedro Alves , "Eli Zaretskii (eliz@gnu.org)" CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH v2 0/7] improve btrace enable error reporting Date: Thu, 8 Feb 2018 13:49:12 +0000 Message-ID: References: <1516976072-19282-1-git-send-email-markus.t.metzger@intel.com> <2c57146a-7111-4381-3851-bd1ff4d610b9@redhat.com> <9ce0c90a-5c71-0a7d-3779-f826369a95ec@redhat.com> In-Reply-To: <9ce0c90a-5c71-0a7d-3779-f826369a95ec@redhat.com> x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2MwYjY1ZWEtOGQxMC00ZmRkLTlhZTctYTE2NzJjMGQ3ZjU0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJKd0pHWDZvRFlWb1hqQkIzcE5tOUhkeFZNajlmejVUV3h5czFPT0JJeTJZWnZXXC9tXC9sMTZ3WTZHSTZoZjJuT04ifQ== dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action MIME-Version: 1.0 X-IsSubscribed: yes Hello Pedro, Eli, Here's the follow-up patch to change a few existing error messages. > > So you're suggesting to change > > > > "GDB does not support Intel Processor Trace." > > > > into > > > > "Intel Processor Trace support was disabled at compile time." > > > > Correct? > > Correct. > > > > > We're already using the above in a warning in remote.c. I'd change > > that, as well, to be consistent with the new wording. > > commit d635c0d842f95f9f76562a132dcabd9330ff6455 Author: Markus Metzger Date: Thu Feb 8 14:35:44 2018 +0100 btrace: reword error messages Reword some btrace error messages to align with the format discussed in https://sourceware.org/ml/gdb-patches/2018-02/msg00135.html. 2018-02-08 Markus Metzger gdb/ * remote.c (remote_btrace_maybe_reopen): Change error message. * btrace.c (btrace_enable): Likewise. (parse_xml_btrace): Likewise. (parse_xml_btrace_conf): Likewise. Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928 diff --git a/gdb/btrace.c b/gdb/btrace.c index 2b031a4..158d03c 100644 --- a/gdb/btrace.c +++ b/gdb/btrace.c @@ -1579,7 +1579,7 @@ btrace_enable (struct thread_info *tp, const struct btrace_config *conf) #if !defined (HAVE_LIBIPT) if (conf->format == BTRACE_FORMAT_PT) - error (_("GDB does not support Intel Processor Trace.")); + error (_("Intel Processor Trace support was disabled at compile time.")); #endif /* !defined (HAVE_LIBIPT) */ DEBUG ("enable thread %s (%s)", print_thread_id (tp), @@ -2218,7 +2218,8 @@ parse_xml_btrace (struct btrace_data *btrace, const char *buffer) #else /* !defined (HAVE_LIBEXPAT) */ - error (_("Cannot process branch trace. XML parsing is not supported.")); + error (_("Cannot process branch trace. XML support was disabled at " + "compile time.")); #endif /* !defined (HAVE_LIBEXPAT) */ } @@ -2312,7 +2313,8 @@ parse_xml_btrace_conf (struct btrace_config *conf, const char *xml) #else /* !defined (HAVE_LIBEXPAT) */ - error (_("XML parsing is not supported.")); + error (_("Cannot process the branch trace configuration. XML support " + "was disabled at compile time.")); #endif /* !defined (HAVE_LIBEXPAT) */ } diff --git a/gdb/remote.c b/gdb/remote.c index e5680f0..15d6c5b 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -13193,8 +13193,8 @@ remote_btrace_maybe_reopen (void) if (!warned) { warned = 1; - warning (_("GDB does not support Intel Processor Trace. " - "\"record\" will not work in this session.")); + warning (_("Target is recording using Intel Processor Trace " + "but support was disabled at compile time.")); } continue;