From patchwork Mon Feb 5 12:15:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Brobecker X-Patchwork-Id: 25795 Received: (qmail 102616 invoked by alias); 5 Feb 2018 12:15:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 102013 invoked by uid 89); 5 Feb 2018 12:15:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:2291, you! X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 05 Feb 2018 12:15:18 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 867EC5610C for ; Mon, 5 Feb 2018 07:15:14 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id FMRBOHSrNbLz for ; Mon, 5 Feb 2018 07:15:14 -0500 (EST) Received: from tron.gnat.com (tron.gnat.com [205.232.38.10]) by rock.gnat.com (Postfix) with ESMTP id 77AA056107 for ; Mon, 5 Feb 2018 07:15:14 -0500 (EST) Received: by tron.gnat.com (Postfix, from userid 4233) id 736C5379; Mon, 5 Feb 2018 07:15:14 -0500 (EST) From: Joel Brobecker To: gdb-patches@sourceware.org Subject: [pushed/obv] Move comment in gdb/dwarf2read.c::dwarf2_physname Date: Mon, 5 Feb 2018 07:15:13 -0500 Message-Id: <1517832913-72299-1-git-send-email-brobecker@adacore.com> Hello, This commit just moves a comment right next to where it is actually relevant. No actual code change. gdb/ChangeLog: * dwarf2read.c (dwarf2_physname): Move commment. Tested by rebuilding GDB, and pushed to master Thank you!, diff --git a/gdb/ChangeLog b/gdb/ChangeLog index b341da9..7850982 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2018-02-05 Joel Brobecker + + * dwarf2read.c (dwarf2_physname): Move commment. + 2018-02-01 Leszek Swirski * varobj.c (varobj_formatted_print_options): Allow recursive diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c index 51d0f39..d651725 100644 --- a/gdb/dwarf2read.c +++ b/gdb/dwarf2read.c @@ -11141,14 +11141,6 @@ dwarf2_physname (const char *name, struct die_info *die, struct dwarf2_cu *cu) gdb::unique_xmalloc_ptr demangled; if (mangled != NULL) { - /* Use DMGL_RET_DROP for C++ template functions to suppress their return - type. It is easier for GDB users to search for such functions as - `name(params)' than `long name(params)'. In such case the minimal - symbol names do not match the full symbol names but for template - functions there is never a need to look up their definition from their - declaration so the only disadvantage remains the minimal symbol - variant `long name(params)' does not have the proper inferior type. - */ if (cu->language == language_go) { @@ -11158,6 +11150,14 @@ dwarf2_physname (const char *name, struct die_info *die, struct dwarf2_cu *cu) } else { + /* Use DMGL_RET_DROP for C++ template functions to suppress + their return type. It is easier for GDB users to search + for such functions as `name(params)' than `long name(params)'. + In such case the minimal symbol names do not match the full + symbol names but for template functions there is never a need + to look up their definition from their declaration so + the only disadvantage remains the minimal symbol variant + `long name(params)' does not have the proper inferior type. */ demangled.reset (gdb_demangle (mangled, (DMGL_PARAMS | DMGL_ANSI | DMGL_RET_DROP)));