From patchwork Thu Feb 1 16:50:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 25726 Received: (qmail 16521 invoked by alias); 1 Feb 2018 16:50:41 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 16505 invoked by uid 89); 1 Feb 2018 16:50:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, MIME_BASE64_BLANKS, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-qt0-f172.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TtLBE8nzj/S6xeDN7UaeCAY2JpCVxKyDuv31sHy6ZEc=; b=VwzWQHCLo4c9pXp1AfoLWo3NnNSoQ+bnRZflqGzCybAig8ARrB47/TwQSIM7SNm1eD 8jY0X+yKw0nsCGgrvdQLJ8HBCyTLRKAS+mR1/4EVSYSqSJdIvk7rxdINa82yDmaSFLm1 xUiK2w6uaNd9MMaUNe/PlPZFneADWcVxg/JaoplZSPmq/c1JGkxWuTjFq8fIEagwbkSh JpJUeQCwPX2kzBdUvfhLVX9PasDMNKMWxLvaPOVSLXpBsGMky2IQ4iy7xahLa37V3led gMun4Ty7rG9m0JfZ6IUgWY2wKpD66QL1tCJhwQaAw3PsF4kkIZd+KW9jzHQYw7piRhCE n5jQ== X-Gm-Message-State: AKwxytex07lUbpsIs0DrHYF82Ush8tyd/oiy4+EQJRJIfdIUJyWmts2Y aoZRzEbnj4wM2/Jl5cttvCcdomsRizg= X-Google-Smtp-Source: AH8x226mp7BdxSFrOh2CJnVhIPHiJ1zlSSWVu2Jx517mgJ4BDsBLQtm1j/VFr2WRaBOrtksfJ+1vQg== X-Received: by 10.200.15.18 with SMTP id e18mr28344621qtk.23.1517503833684; Thu, 01 Feb 2018 08:50:33 -0800 (PST) Subject: Re: RFC: remove the "tile" architecture from glibc To: Joseph Myers Cc: libc-alpha@sourceware.org References: <1a57be83-3349-5450-ee4f-d2a33569a728@mellanox.com> <995aac59-2f9d-2a6a-2b5c-b827410ad295@physik.fu-berlin.de> <38170271-e17f-0a7e-7dd2-06fa6ddfae62@physik.fu-berlin.de> <752f1200-5b98-d624-6fc8-30983d171750@linaro.org> From: Adhemerval Zanella Message-ID: <40905d93-8648-e99c-dba6-641831dc25f6@linaro.org> Date: Thu, 1 Feb 2018 14:50:28 -0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: On 01/02/2018 11:49, Joseph Myers wrote: > On Thu, 1 Feb 2018, Adhemerval Zanella wrote: > >> Trying to build/run glibc testsuite against sh4 own toolchain I am facing >> an build issue for some tests: >> >> --- >> gcc -nostdlib -nostartfiles -o /home/azanella/glibc/glibc-git-build/assert/tst-assert-c++ -Wl,-z,combreloc -Wl,-z,relro -Wl,--hash-style=both /home/azanella/glibc/glibc-git-build/csu/crt1.o /home/azanella/glibc/glibc-git-build/csu/crti.o `gcc --print-file-name=crtbegin.o` /home/azanella/glibc/glibc-git-build/assert/tst-assert-c++.o /home/azanella/glibc/glibc-git-build/support/libsupport_nonshared.a -lstdc++ -Wl,-dynamic-linker=/lib/ld-linux.so.2 -Wl,-rpath-link=/home/azanella/glibc/glibc-git-build:/home/azanella/glibc/glibc-git-build/math:/home/azanella/glibc/glibc-git-build/elf:/home/azanella/glibc/glibc-git-build/dlfcn:/home/azanella/glibc/glibc-git-build/nss:/home/azanella/glibc/glibc-git-build/nis:/home/azanella/glibc/glibc-git-build/rt:/home/azanella/glibc/glibc-git-build/resolv:/home/azanella/glibc/glibc-git-build/crypt:/home/azanella/glibc/glibc-git-build/mathvec:/home/azanella/glibc/glibc-git-build/support:/home/azanella/glibc/glibc-git-build/nptl /home/azanella/glibc/glibc-git-build/libc.so.6 /home/azanella/glibc/glibc-git-build/libc_nonshared.a -Wl,--as-needed /home/azanella/glibc/glibc-git-build/elf/ld.so -Wl,--no-as-needed -lgcc -Wl,--as-needed -lgcc_s -Wl,--no-as-needed `gcc --print-file-name=crtend.o` /home/azanella/glibc/glibc-git-build/csu/crtn.o >> /usr/lib/gcc/sh4-linux-gnu/7/libgcc_s.so.1: undefined reference to `__fpscr_values@GLIBC_2.2' >> collect2: error: ld returned 1 exit status > > I think some distributions have a local glibc patch related to > __fpscr_values, so a newly built glibc may be ABI-incompatible with > binaries built against such a patched glibc. (The use of __fpscr_values > is fundamentally flawed, but that was supposed to be fixed for GCC 5 - see > and its duplicate > .) > I do think it is the case, checking the debian package addendum from libc6-dev [1] I noted it indeed adds this patch: $ cat local-fpcscr_values.diff I will check glibc with patch applied and try to rebuild a canadian cross to check against a baseline toolchain. [1] https://packages.debian.org/it/sid/libc6-dev --- a/sysdeps/unix/sysv/linux/sh/sysdep.S +++ b/sysdeps/unix/sysv/linux/sh/sysdep.S @@ -30,3 +30,14 @@ #define __syscall_error __syscall_error_1 #include + + .data + .align 3 + .globl ___fpscr_values + .type ___fpscr_values, @object + .size ___fpscr_values, 8 +___fpscr_values: + .long 0 + .long 0x80000 +weak_alias (___fpscr_values, __fpscr_values) + --- a/sysdeps/unix/sysv/linux/sh/Versions +++ b/sysdeps/unix/sysv/linux/sh/Versions @@ -2,6 +2,7 @@ GLIBC_2.2 { # functions used in other libraries __xstat64; __fxstat64; __lxstat64; + __fpscr_values; # a* alphasort64; --- a/sysdeps/unix/sysv/linux/sh/libc.abilist +++ b/sysdeps/unix/sysv/linux/sh/libc.abilist @@ -267,6 +267,7 @@ GLIBC_2.2 __flbf F GLIBC_2.2 __fork F GLIBC_2.2 __fpending F +GLIBC_2.2 __fpscr_values D 0x8 GLIBC_2.2 __fpu_control D 0x4 GLIBC_2.2 __fpurge F GLIBC_2.2 __freadable F