From patchwork Thu Feb 1 15:12:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 25724 Received: (qmail 79787 invoked by alias); 1 Feb 2018 15:12:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 79778 invoked by uid 89); 1 Feb 2018 15:12:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=1446, Hx-spam-relays-external:209.85.128.196, H*RU:209.85.128.196, H*r:sk:static. X-HELO: mail-wr0-f196.google.com Received: from mail-wr0-f196.google.com (HELO mail-wr0-f196.google.com) (209.85.128.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Feb 2018 15:12:54 +0000 Received: by mail-wr0-f196.google.com with SMTP id v15so19350475wrb.8 for ; Thu, 01 Feb 2018 07:12:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=j4FPhxBzmpE9mgsjlG1AP/wn5Nh/lZtHjcvwR37InqQ=; b=D5fa2I8Ab0xspWAwrahjdISYpcMRic2KAXDEKK2Slail0th8RBllL6FUJ54qMdK7WX VGAjwC4Vwu9QnN8ea3Z0I0cU2i8TphI1dY6W4eSPjUhvHag+fywYH8EQWdQ6dDxUcEVS ufwJ9DheB2pheWWrfi7qy/d4JlZSKHG4WDEjUgMT2CHPKVw2BygqRFolMmSNuCx9X6o9 lPIoDq8GaO8moPLUx3XPV9BOGGTcX05Vo7RhL2QkgZyCQ4tZiJ9AOHbppuZoQ5g5p9BU 9RiUasqFTY09mFckPQ21HHZZ1eWwXo9Tn5ZSmMHsdhli08CWEfep4aeH/BuVCbI/H6Br UzFA== X-Gm-Message-State: AKwxytevX5VoNSw4eBy1vqtOq6lm6+KWdXvbPHoYVs7FILNz4LQwjyk3 K3lyPUH/C6zibu80YAon2jwyPw== X-Google-Smtp-Source: AH8x226QklIIk6JGHFFrItYh2QUtVOIMPjhZNQj9EQPhMgt+vDVd5c5Nc+cXzDhi7z2dKio4YA5fWg== X-Received: by 10.223.184.28 with SMTP id h28mr22571488wrf.215.1517497972365; Thu, 01 Feb 2018 07:12:52 -0800 (PST) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id e6sm19681534wra.41.2018.02.01.07.12.51 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 01 Feb 2018 07:12:51 -0800 (PST) From: Yao Qi To: Eli Zaretskii Cc: simon.marchi@ericsson.com, gdb-patches@sourceware.org Subject: Re: [ANNOUNCEMENT] GDB 8.1 release branch created! References: <83h8rlyakm.fsf@gnu.org> <83lggvupt6.fsf@gnu.org> <83lgglnadl.fsf@gnu.org> <83fu6sln4o.fsf@gnu.org> <3d75778f-5c91-5680-b9fa-c2f2c902ff67@ericsson.com> <838tcklaev.fsf@gnu.org> <83607njlsh.fsf@gnu.org> Date: Thu, 01 Feb 2018 15:12:47 +0000 In-Reply-To: <83607njlsh.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 27 Jan 2018 18:42:22 +0200") Message-ID: <86wozwbv68.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 X-IsSubscribed: yes Eli Zaretskii writes: > No further comments, so I went ahead and pushed the change, without > the __cplusplus part, to master, and then cherry-picked to > gdb-8.1-branch. Hi Eli, Is it intended to include error messages in the changelog entry? If not, can we remove it? in the patch below, 2018-01-27 Eli Zaretskii Avoid compilation errors in MinGW native builds The error is triggered by including python-internal.h, and the error message is: In file included from d:\usr\lib\gcc\mingw32\6.3.0\include\c++\math.h:36:0, from build-gnulib/import/math.h:27, from d:/usr/Python26/include/pyport.h:235, from d:/usr/Python26/include/Python.h:58, from python/python-internal.h:94, from python/py-arch.c:24: d:\usr\lib\gcc\mingw32\6.3.0\include\c++\cmath:1157:11: error: '::hypot' has not been declared using ::hypot; ^~~~~ This happens because Python headers define 'hypot' to expand t '_hypot' in the Windows builds. * python/python-internal.h (_hypot) [__MINGW32__]: Define back to 'hypoth'. This avoids a compilation error. diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 5c3338f..40f4008 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -144,23 +144,6 @@ 2018-01-27 Eli Zaretskii - Avoid compilation errors in MinGW native builds - - The error is triggered by including python-internal.h, and the - error message is: - - In file included from d:\usr\lib\gcc\mingw32\6.3.0\include\c++\math.h:36:0, - from build-gnulib/import/math.h:27, - from d:/usr/Python26/include/pyport.h:235, - from d:/usr/Python26/include/Python.h:58, - from python/python-internal.h:94, - from python/py-arch.c:24: - d:\usr\lib\gcc\mingw32\6.3.0\include\c++\cmath:1157:11: error: '::hypot' has not been declared - using ::hypot; - ^~~~~ - - This happens because Python headers define 'hypot' to expand t - '_hypot' in the Windows builds. * python/python-internal.h (_hypot) [__MINGW32__]: Define back to 'hypoth'. This avoids a compilation error.