From patchwork Thu Feb 1 15:09:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 25723 Received: (qmail 64193 invoked by alias); 1 Feb 2018 15:09:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 64177 invoked by uid 89); 1 Feb 2018 15:09:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:sk:static. X-HELO: mail-wm0-f48.google.com Received: from mail-wm0-f48.google.com (HELO mail-wm0-f48.google.com) (74.125.82.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Feb 2018 15:09:35 +0000 Received: by mail-wm0-f48.google.com with SMTP id v71so6361500wmv.2 for ; Thu, 01 Feb 2018 07:09:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=yi1l8ULV63vPE5AWDaslIyIOlEP5Pdf2FTOVtOHWN8I=; b=uZXaaKWg1lBW+SPkhv0Y/dUxYq02uSFCHpF+2pEI+gW0280V9K6dBeItz8SpGXT5aW o+yHxhD+0dqI6KMey7j5Z6rV+1X5utAXPiXHsGDS23TPhjYA6B6L3XQAkQR70Blr6gne sWXYD4DHMlLtmgJCiFf2xBK8Wg83kx/wpgxaQJC5pwsZENk1rMo32iDENExq7ySzqdXM 0gCYGRZxdOkrlEblCRuFSpwH4o7PrPDD9thNfbp84grdhcG49GfzXJhh70zRfPai1peT uWlVulLmdJ5bH+3TV/aI09TcMrz2wrXEICr2QAWje/BSCCVhGrAXk8ZG4Sa8WBKmmsDB QhoQ== X-Gm-Message-State: AKwxytdjJxlZDeCuh+6+mFUDwnTcNnLo9hvpnhJWpyL7LqaFogSSQxY0 19AVG8Qq12EV/qMoQa30KUJ8Ow== X-Google-Smtp-Source: AH8x227wf/Cz1FBssP2IIrEPASlsyb74kzIXOeimZfiaiD2/5MAJlo6aNwHvq/VKLyW7oYdZBqXCRw== X-Received: by 10.28.14.129 with SMTP id 123mr20758393wmo.111.1517497773449; Thu, 01 Feb 2018 07:09:33 -0800 (PST) Received: from E107787-LIN.cambridge.arm.com (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id g8sm2358499wrb.88.2018.02.01.07.09.32 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 01 Feb 2018 07:09:32 -0800 (PST) From: Yao Qi X-Google-Original-From: Yao Qi To: gdb-patches@sourceware.org Subject: [PATCH OBV] set ret signed in arm_record_extension_space Date: Thu, 1 Feb 2018 15:09:29 +0000 Message-Id: <1517497769-19393-1-git-send-email-yao.qi@linaro.org> X-IsSubscribed: yes Variable 'ret' should be int rather than unsigned, as it can be -1. gdb: 2018-02-01 Yao Qi * arm-tdep.c (arm_record_extension_space): Change ret to signed. --- gdb/ChangeLog | 4 ++++ gdb/arm-tdep.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 90986ef..5c3338f 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2018-02-01 Yao Qi + + * arm-tdep.c (arm_record_extension_space): Change ret to signed. + 2018-01-31 Nikola Prica * rs6000-tdep.c (skip_prologue): Remove shifting for lr_reg and diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c index 2e43489..d991e7e 100644 --- a/gdb/arm-tdep.c +++ b/gdb/arm-tdep.c @@ -9964,7 +9964,7 @@ arm_record_strx (insn_decode_record *arm_insn_r, uint32_t *record_buf, static int arm_record_extension_space (insn_decode_record *arm_insn_r) { - uint32_t ret = 0; /* Return value: -1:record failure ; 0:success */ + int ret = 0; /* Return value: -1:record failure ; 0:success */ uint32_t opcode1 = 0, opcode2 = 0, insn_op1 = 0; uint32_t record_buf[8], record_buf_mem[8]; uint32_t reg_src1 = 0;