Patchwork [PUSHED,OBV] Use the correct value for the offset of 'kve_protection'.

login
register
mail settings
Submitter John Baldwin
Date Jan. 12, 2018, 8:13 p.m.
Message ID <20180112201306.12844-1-jhb@FreeBSD.org>
Download mbox | patch
Permalink /patch/25368/
State New
Headers show

Comments

John Baldwin - Jan. 12, 2018, 8:13 p.m.
I had forgotten to convert the decimal output of 'ptype /o' to hex
(but still used a 0x prefix) for the KVE_PROTECTION constant defining
the offset of the 'kve_protection' field in the 'kinfo_vmentry'
structure.  This resulted in garbage permissions for entries in 'info
proc mappings' for FreeBSD core dumps.

gdb/ChangeLog:

	* fbsd-tdep.c (KVE_PROTECTION): Correct value.
---
 gdb/ChangeLog   | 4 ++++
 gdb/fbsd-tdep.c | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 66ca03d0ec..1c52f5f17b 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@ 
+2018-01-12  John Baldwin  <jhb@FreeBSD.org>
+
+	* fbsd-tdep.c (KVE_PROTECTION): Correct value.
+
 2018-01-12  Andreas Arnez  <arnez@linux.vnet.ibm.com>
 
 	* infrun.c (keep_going_pass_signal): Clear step-over info when
diff --git a/gdb/fbsd-tdep.c b/gdb/fbsd-tdep.c
index 8aa0243d54..e49a9aff09 100644
--- a/gdb/fbsd-tdep.c
+++ b/gdb/fbsd-tdep.c
@@ -62,7 +62,7 @@ 
 #define	KVE_END			0x10
 #define	KVE_OFFSET		0x18
 #define	KVE_FLAGS		0x2c
-#define	KVE_PROTECTION		0x56
+#define	KVE_PROTECTION		0x38
 #define	KVE_PATH		0x88
 
 /* Flags in the 'kve_protection' field in struct kinfo_vmentry.  These