Patchwork [RFA,6/6] Remove symbolp typedef

login
register
mail settings
Submitter Tom Tromey
Date Jan. 6, 2018, 12:26 a.m.
Message ID <20180106002621.21099-7-tom@tromey.com>
Download mbox | patch
Permalink /patch/25242/
State New
Headers show

Comments

Tom Tromey - Jan. 6, 2018, 12:26 a.m.
This removes the symbolp typedef from dwarf2read.c.  It is no longer
used.

2018-01-05  Tom Tromey  <tom@tromey.com>

	* dwarf2read.c (symbolp): Remove typedef.  Don't instantiate VEC.
---
 gdb/ChangeLog    | 4 ++++
 gdb/dwarf2read.c | 3 ---
 2 files changed, 4 insertions(+), 3 deletions(-)
Simon Marchi - Jan. 16, 2018, 3:33 p.m.
On 2018-01-05 07:26 PM, Tom Tromey wrote:
> This removes the symbolp typedef from dwarf2read.c.  It is no longer
> used.
> 
> 2018-01-05  Tom Tromey  <tom@tromey.com>
> 
> 	* dwarf2read.c (symbolp): Remove typedef.  Don't instantiate VEC.
> ---
>  gdb/ChangeLog    | 4 ++++
>  gdb/dwarf2read.c | 3 ---
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index e9b6023047..f8aa10d50a 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,5 +1,9 @@
>  2018-01-05  Tom Tromey  <tom@tromey.com>
>  
> +	* dwarf2read.c (symbolp): Remove typedef.  Don't instantiate VEC.
> +
> +2018-01-05  Tom Tromey  <tom@tromey.com>
> +
>  	* gdbtypes.h (add_dyn_prop): Remove objfile parameter.
>  	* gdbtypes.c (add_dyn_prop): Remove objfile parameter.
>  	(create_array_type_with_stride): Update.
> diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
> index 3807251970..93e2419cc9 100644
> --- a/gdb/dwarf2read.c
> +++ b/gdb/dwarf2read.c
> @@ -87,9 +87,6 @@
>  #include <set>
>  #include <forward_list>
>  
> -typedef struct symbol *symbolp;
> -DEF_VEC_P (symbolp);
> -
>  /* When == 1, print basic high level tracing messages.
>     When > 1, be more verbose.
>     This is in contrast to the low level DIE reading of dwarf_die_debug.  */
> 

Yay, LGTM.

Simon

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index e9b6023047..f8aa10d50a 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@ 
 2018-01-05  Tom Tromey  <tom@tromey.com>
 
+	* dwarf2read.c (symbolp): Remove typedef.  Don't instantiate VEC.
+
+2018-01-05  Tom Tromey  <tom@tromey.com>
+
 	* gdbtypes.h (add_dyn_prop): Remove objfile parameter.
 	* gdbtypes.c (add_dyn_prop): Remove objfile parameter.
 	(create_array_type_with_stride): Update.
diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index 3807251970..93e2419cc9 100644
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -87,9 +87,6 @@ 
 #include <set>
 #include <forward_list>
 
-typedef struct symbol *symbolp;
-DEF_VEC_P (symbolp);
-
 /* When == 1, print basic high level tracing messages.
    When > 1, be more verbose.
    This is in contrast to the low level DIE reading of dwarf_die_debug.  */