From patchwork Sun Dec 31 14:59:44 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 25162 Received: (qmail 61910 invoked by alias); 31 Dec 2017 15:00:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 61798 invoked by uid 89); 31 Dec 2017 15:00:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:sk:EUR01-D X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 31 Dec 2017 15:00:00 +0000 Received: from ESESSHC001.ericsson.se (Unknown_Domain [153.88.183.21]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id AA.AD.14322.E6BF84A5; Sun, 31 Dec 2017 15:59:58 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.21) with Microsoft SMTP Server (TLS) id 14.3.352.0; Sun, 31 Dec 2017 15:59:57 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from elxacz23q12.lan (192.222.251.162) by DBXPR07MB318.eurprd07.prod.outlook.com (2a01:111:e400:941d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.386.4; Sun, 31 Dec 2017 14:59:55 +0000 From: Simon Marchi To: CC: Simon Marchi Subject: [PATCH 1/2] linux-nat: Remove unnecessary xstrdup Date: Sun, 31 Dec 2017 09:59:44 -0500 Message-ID: <1514732385-5506-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 X-ClientProxiedBy: BN6PR11CA0072.namprd11.prod.outlook.com (2603:10b6:404:f7::34) To DBXPR07MB318.eurprd07.prod.outlook.com (2a01:111:e400:941d::12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3cd55e6a-5f5d-4e29-22f8-08d5505f27ea X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060); SRVR:DBXPR07MB318; X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB318; 3:j3fkiKIo8z9U+T3aDa5s4iZoA/bq2v1po509dNjW6g5lkUOwqNtGjj7bY/ASREoz5tH6LFb5CFtDCvCnDZM/zN9tmDvr0gC14mD831IpkEyU0/eb8TnhOdGSI8Tlc5KydRkjuAZNeAReihmiw7EnS6Cmz4C2V/i636PT7VIt4Ehkz3/ToQya3HcCzU83/wBOJr/GXj/0wfgGZeS0pBQZz7Bs/pg99YN4ksnXJZJGeDjsijwZdqnLXr7U2Itc7vTV; 25:3cVwdgwCXt3sbKdekrarGVfwRPW+8GBXwptg0mlmH8ZrGcaendxgz/QzPoHGuhBdeNDDFOD0KuvzzUT3zEFIn0vRwsHmymtcTGoST1092ehhQGALFl/pR5YzEId116V4/EUMU1MuCpY/wmtTppAgdTOh7Ocu+78JaSorla4R/i4Q2gpmA469xbB6+mafqF2/mfB5wxOgbpzPCaKsreoH9+9s7i9VFxEWErkgk/F1h59vB8gV/p0l9VLEhcf01l1LsqSUyWhWuD7FVNy/VxFDLeGb5MM/E3DfDnTxtSjzJuR/HZP3s3qtRZ+8scDhzdRJRfK5865+IO9tY1HF+haiGTBMFZFmbZEVOoEYfNP8C/M=; 31:JgFeUT2vndeupEgXQwgYUEDztSffG99SwADYE6FLdS38DQrveJGTGVWXbR3/WFGh7TaYsYxM7XtiKSir0i0jJjlpnA+8JJk9LolgNW5h9GXgRmww1V13fsOEFtGhz6/gRg64CN3VUJ8Y/k5R8EbIZwG2D9/9qKS+lQzwtTR7d63OhTK7FrKNBQLS91/jFe7cGfMe+M/mlR/zx7mGmt3iXf1fdm0DWD8oXm+ohZ5PYOM= X-MS-TrafficTypeDiagnostic: DBXPR07MB318: X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB318; 20:YIRg/Iaq3KD2Flmv1HwGS4EBHj+/04nkOA1ggfIIgMechb7RfQI12bX3Vv3VDL2vYqrpKMVYdhzP9vVITRJsi3GxXkSa5TrtGuJODfKiq8fDqRZ2lnuI/KfthW/Po0o8khi8L8SrCrJIKWL9bmpr37loyjsXkhX9F/v/x4DWqXfc1liyn+E1HxiFXWE9oaclEP5tKMgEMc/0mf9X7Z9tJWanWifs78CYnw/tgEVaKcBfzA3tOaz0KtCh26bYwofmUtIe1UWF0VEiUNrSsBTZ8M/dUznq4W67kqAGFZN4B/W7g7lNBZw3Stqahriq04HLwJ42nOzF3EGg31DfC9xnRlL3IMoZEAykl1upi3CwlW+7sA6DeuFWuKBExZJZKwfKScxgXY+lDUuDzDaVwtfGk+Opf5UBvPSIdgqXoCNm7sws4S47GHzyzW0V+UcrY4/xtKI4+4xPgFY6ZnoXK3ln3Ak7Wm4zEGe9J4+nCq14aMBTOTIz/aL200cd7GZ1QV1f; 4:9jkuQUIZxd7/8GGaXQaPcHSkF87qtvVqmC1z+TB58Q1rx6SmBlCN8sh5kg2IW5vpcuxgTB0OCJmfatslkxjVNHqbEuSg0cEu15twuyIyM5ierW81RWugR3eISi5qCkb1jBEPAN7+Sft2Al449/7oyXCadUwRYqQRWJOm4t0E20h0GLfa3mVG8t+a0EWC0nOHusGOYAqF81xo/nawDBPyb5nE2RcMDuYGS2Ju8YrVTwNqktnrT68ONpoXvbUJ/PY739G7LS+gkma2hGjv6KqOmg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(3231023)(944501075)(6041268)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123564045)(6072148)(201708071742011); SRVR:DBXPR07MB318; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:DBXPR07MB318; X-Forefront-PRVS: 0538A71254 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(39860400002)(396003)(346002)(376002)(39380400002)(54534003)(199004)(189003)(386003)(36756003)(6116002)(106356001)(50226002)(69596002)(68736007)(6916009)(6506007)(97736004)(47776003)(59450400001)(52116002)(6512007)(51416003)(8936002)(66066001)(3846002)(2906002)(81156014)(305945005)(7736002)(81166006)(48376002)(5660300001)(8676002)(21086003)(316002)(53936002)(6486002)(478600001)(16586007)(25786009)(6666003)(86362001)(16526018)(107886003)(50466002)(2361001)(105586002)(5890100001)(4326008)(2351001)(129583001); DIR:OUT; SFP:1101; SCL:1; SRVR:DBXPR07MB318; H:elxacz23q12.lan; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DBXPR07MB318; 23:cAG6DUW8Z61Y+JiNuMM78wELyZHTaTs2tAcDLwe9A4?= =?us-ascii?Q?xzGRNMYdxmxgufM0FrFwplOI8mJ121WCjRw6GKQ2oMb1IE1V7e6rjT8/ZFMZ?= =?us-ascii?Q?UrfqEtlszX8dnWGR5RMp3nukE1hH3Ai/ssEyUmUgRmIMITBzDMjKgI/ws7IA?= =?us-ascii?Q?z+9qJ621BcnFUI7HRxe7mqd5LOL4ZXUXqUZCfsoIiBlPATYITHZmt6zfsoy9?= =?us-ascii?Q?CVQztu1j/p5P0kon4AS0vuXed5+9CE3WwJQTDCZ6VX/3FeFASkRHyRUQ7Xoq?= =?us-ascii?Q?XBwlM3x7GxZDFdNQ3q8MHAWMwqenPlB8KbuaBDSOGFeN9OqscYIoGS33M2V+?= =?us-ascii?Q?3wxGcr/pO+BzhDUtPHnAeSE72FtmT/NAkdXDMTKLcden1gjpZl3qxtat0h7a?= =?us-ascii?Q?fCvUJzhBlfzR9xZK19qBD8C9lF781QgBP4l3WKCWqDGnj3qRUnLNyH9uPqOj?= =?us-ascii?Q?d351r4v7B88g9V1mbGgONhovcquNDdUw+BPFxxNZota8LEPGknYxR9kYMdB0?= =?us-ascii?Q?ybUekcEAnefaNwU9KftNmUnqboDeN+UVxaJdFZeZfm/PBWw+blrWYnPWje+B?= =?us-ascii?Q?LXwDrOQtjWp4uka8GdttnbRz1JbSLv5QhNIPkaqYhUsWxCQ/Ie3lhPJQ4Ut7?= =?us-ascii?Q?64AP9XnQrf8NCuAqj/GXzCuPN0MZ0YNBn/150EoslyW885uPa0tUKhoNVqOE?= =?us-ascii?Q?KlNpv5izHHlfvceOexGLc36pqnpwaAM2abrLqlM9/UMLGjzxFs/M7rFgfrgU?= =?us-ascii?Q?+3iBT6NCenJdEABNIbQn0zXOpsdfHVLlbgWLmzuO9z0yg8tcqRZMhIMh8PLs?= =?us-ascii?Q?BfuRUlyg3/vdL0NHJ21tl5BVtnIe4cE/S13/czSmldbaOqOsgmlpFckkEZvP?= =?us-ascii?Q?N26BYMcivkpBlky1bdRzN93WwVsYWwNGwBS1mDN5BZoeBgZ0lE6y3oxKe7rP?= =?us-ascii?Q?pN+YZfZ0UwpDgIsMq8m9i+Y1lw5AVjbHiom4aN0NgUf7gcuXL7RX0fDBHWRf?= =?us-ascii?Q?wiZmD/wZkGepRZDD/HDnZzlksKmUi2pP7kEZwtfz9iBWPPSvzo06rjBXwuWz?= =?us-ascii?Q?lnOI24spbhQ5whPBuRO47rt+EuX0sab47fKA7UYiPDje1/fbcc+g6YOU1hP4?= =?us-ascii?Q?QJtCb7bI/Rkyj0T0lQ+nI8f5JE+VpACWuGQM6nP2cdQgiIVi13ATuz/aShh2?= =?us-ascii?Q?XL+U7by8TPX+IcEpG2VN58e75DxVm9V/jUGXnMv6FtfIvrt25oZgCUug=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB318; 6:5fskUGjnCFuGvIJ77n/iGjK8ciHA2I3Cd8o3hJ/qMngs+k7l1n+kbiinvPQbqDp9mhkDgotwWaYE9hw2sU1qzzutXF30UT52YzoARnWZ1wiRbEJePRDvyKiAOcG2LalpAsD+olWKszGcw3Of1uRUro9taT8mQE94hw9aKd3KX+P0/Q1Uo25YgRyNRX5gWaUU7sGtjft6/X2w+dpE8ZU+NPbZ7Ql8P3hl3OX1no0UzglBwpSZaqJ1J7r0NURsc2lVAq3o+CbFjNG2iIFBbq/8ftajwvpCJJappVg9LVX526KovXJPWEhB5+npvuVJQCCgE/wS5Q7anR1IWAepneff6DEdRkzScqs+bTqQoObhLeQ=; 5:+yZWCRPTiushwWJSZr9rdARhGnutiOkwtwukcJrLHKA0CvRcD2kPvKhQ66knDyVAd0Z9Eer5D+RK/1SHQsy0WIVgN1F/Ju715OH9TzBvNw9ml3Qi8hyolSIAecPH/X114NEfhEEXOa+fpyjR46/4nE0GDKyRK59sRwyJ0CsewDA=; 24:IpwTipXsriiDMmgPtv8vCzE0ToIyv4aiFn+P2tSk6S1QaZeQJ1FL85QI+HtgLoprATtN8+GK+FUoE2UI/xCtk/R7q4YfBZR9+60ZxexVIlE=; 7:iH22Sw9zsothclW3sRSMqzVT/AthNpSKwhFbh0BPUbLbUCi8D7daZmdNfi+iuOMHcR+JDUrQB5EMufxzl4PW3O8omaegHZH5AFZNxeW7dxHFIJYWS+J5U3osRDh96MEfrccOTAUT+k8z7CXTiBLauWEJe26hnldddYBtFE+ot+I8S2qm0k0LPjuwqIXRY88vt/lc5gq9oDIWA6kxbaaZS2iDSwfNuyTDYSmu0A8In1/cX5Rhb9vI4sP/UnyF6MUT SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Dec 2017 14:59:55.9095 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3cd55e6a-5f5d-4e29-22f8-08d5505f27ea X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBXPR07MB318 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes I think this xstrdup is not useful. We can pass ex.message directly to throw_error instead. gdb/ChangeLog: * linux-nat.c (linux_nat_attach): Remove xstrdup. --- gdb/linux-nat.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c index b8f3108..1d1d6d3 100644 --- a/gdb/linux-nat.c +++ b/gdb/linux-nat.c @@ -1224,10 +1224,7 @@ linux_nat_attach (struct target_ops *ops, const char *args, int from_tty) { pid_t pid = parse_pid_to_attach (args); struct buffer buffer; - char *message, *buffer_s; - - message = xstrdup (ex.message); - make_cleanup (xfree, message); + char *buffer_s; buffer_init (&buffer); linux_ptrace_attach_fail_reason (pid, &buffer); @@ -1237,9 +1234,9 @@ linux_nat_attach (struct target_ops *ops, const char *args, int from_tty) make_cleanup (xfree, buffer_s); if (*buffer_s != '\0') - throw_error (ex.error, "warning: %s\n%s", buffer_s, message); + throw_error (ex.error, "warning: %s\n%s", buffer_s, ex.message); else - throw_error (ex.error, "%s", message); + throw_error (ex.error, "%s", ex.message); } END_CATCH