From patchwork Sat Dec 30 05:11:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 25147 Received: (qmail 125930 invoked by alias); 30 Dec 2017 05:13:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 125261 invoked by uid 89); 30 Dec 2017 05:11:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 30 Dec 2017 05:11:36 +0000 Received: from ESESSHC005.ericsson.se (Unknown_Domain [153.88.183.33]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id 1A.1C.31026.500274A5; Sat, 30 Dec 2017 06:11:34 +0100 (CET) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.33) with Microsoft SMTP Server (TLS) id 14.3.352.0; Sat, 30 Dec 2017 06:11:19 +0100 Received: from elxacz23q12.lan (192.222.251.162) by AMSPR07MB310.eurprd07.prod.outlook.com (2a01:111:e400:802f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.366.3; Sat, 30 Dec 2017 05:11:17 +0000 From: Simon Marchi To: CC: Simon Marchi Subject: [pushed] Make mapped_debug_names and mapped_index final Date: Sat, 30 Dec 2017 00:11:06 -0500 Message-ID: <1514610666-10842-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 X-ClientProxiedBy: BN6PR1301CA0023.namprd13.prod.outlook.com (2603:10b6:405:29::36) To AMSPR07MB310.eurprd07.prod.outlook.com (2a01:111:e400:802f::20) X-MS-Office365-Filtering-Correlation-Id: 5704184a-c5a5-44b6-4e1a-08d54f43c24e X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020020)(4534040)(4602075)(4627136)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060); SRVR:AMSPR07MB310; X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB310; 3:cD94yUeKeVa+ks4G+wSxmDhQT6upMOF0quL/JuTiksj9zz0wNpv0MARNb2RBl9H0McESNBx7qKWt5oiFMMuB2cB+etmZdehjAc3RQZar5GXSfdAcgVVnu8ypVvt81XhQpyMmeStgg18A5QeO90Wgdpkkxp3ICq9wXxyoI6duD1KytMd/gkNvQTonRYtXIQgGrz6nRsZZ0QjZVqUhW3NJtN1lvCB/uYDGCYm4f2pUOtWTP2nvJd1u4IbbGqu9cXym; 25:MPgIhxvNuNnL+nMWqSlWWdLohEH883iYMf+oqaYXwjkGmofIau3834r7wUQ4Ct0aN5hyDOLztTjVZBFfouvB+Dp4ajiVbGBcfmtwrKyRJ98zX6Vm6pvuqrTXsBVnNJIb/pw9t++v5R5bqrE6WqntOSkswDComiXDYPCs/zPqtAbXkerR1NoIGcnjlIXzBe5xUvbxJWOjk8DUN4f1WI/mrFdkPcXoLdZqj+Y03ya7kwXIshBJNaKPO+qHbMkUCRs/0X66h4cfbuJ4UjSP4ZV+j8yfb8Jlf+55dbIiltKqfAGZkmGW45ov8ewYdAiEXLQvVt/4ql/hq9odxVXkWJBxAS6RDz8o9Ja0o2MGXwgnfP0=; 31:V95DXHazXOerPcnaTI5GaF/E9c5L7nlpD7DJV9FKLNybFgqmU8E8U3Nharjfx0LoeVqez45jsTQHJp7cqgyPcObfmq1jzNkmgWYfl8PWG8SG/H/Nv6Z/aLpJmj131NdlWctJ9aUQX75hVKeQ/K4e4jwonr0wk7Io7B1oN8qF/Kqt8Z0NEt6yVR1ewvayUl3IVgQ/zAC+r3ZDcl4Mlj/HTQnx7QMXwCsHLTcn4jytRBs= X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMSPR07MB310: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB310; 20:HzFTOt5N2OG0p5pZ5eGJxYp8FJUagvYUEojNOvGxzZv1D4nmdixDQ8S6BVaBGmwbRsIu/YcgRsEHrC3DiN6/rhVJHIcBoxr4zzm0oCAbu7x2p/i2zMqQZJwblfXHPAstlA9DrVhFyZi1q9bSTQJadU7QAbz3AddJj5JcCgA/8K6/yBVwAYmDUcPEVTKhpqCwRjNZPAZgTfmzxLfvqqz5YRm8fMQCJcy39RP8fYfWhxfcTB5domRxIZ5/89vAubfpVs1wqN+Q6hIDmFVrtLuUkKCruORXxZlR6Lpyw1M1kinNPQOvDrDjZ9Ei4zpRH/OM6RPyM+J6I6IeLR1aQ/vpbSAwinZBvyvP/0zvR+MFVxlc+pRcoZOXG78ARHArVOyVC0hkpODW4iTmXXnQaXBO/894Z6eRS0JgfdFiUaOrt0uQ7ovGo16uEENd/o5F+7Bps7GwI3X0bnBCtxhGesDZ9yyQodhf8gJ38a/s7yU021hUVaiZFsQaY4lQLhyDr2Jf; 4:jdvhxZHFriHIe9b1PA8FPPcaERBPbrlXTIfa423pPh0vxAUBS7sENWRKFlnNd3ImS7H5uy5tIBySDwJ3aRAt4jK1DQ9DZ9o5nquXcMJ0WxHtl5S/EemLtXE8GLjdgdGWnPZFHbxQjP4IDQ4KMCP7wL/HWZUgVvPk00LfTZ8rt8mRrMOIQTIfKP32mqTYyZOIIgBW1Z7X3Y75Dg5azc3E8IW/sF7hjUtlihqE95PMokNETuE4eB9q9cDiCCMMouXeyz2Vyj9XlzovXZ80QNB/jFVwcrog3r1xabGww8b/5PhPhX1WSss6bkI5KcgoD2UL X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(37575265505322); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231023)(944501075)(6041268)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011); SRVR:AMSPR07MB310; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:AMSPR07MB310; X-Forefront-PRVS: 05373A0663 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(39380400002)(376002)(396003)(366004)(39860400002)(199004)(189003)(54534003)(377424004)(6486002)(105586002)(6916009)(6512007)(5660300001)(69596002)(50466002)(2361001)(48376002)(51416003)(6666003)(6116002)(59450400001)(81166006)(81156014)(106356001)(3846002)(2351001)(36756003)(53936002)(52116002)(86362001)(107886003)(2906002)(68736007)(316002)(478600001)(8676002)(66066001)(7736002)(305945005)(47776003)(16586007)(8936002)(6506007)(21086003)(386003)(97736004)(16526018)(50226002)(4326008)(25786009)(4001150100001); DIR:OUT; SFP:1101; SCL:1; SRVR:AMSPR07MB310; H:elxacz23q12.lan; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AMSPR07MB310; 23:kgvxtSq+1IqlYDOFZcqnlhWEM6c7s+yIr71EbalqKo?= =?us-ascii?Q?KBYwwNPrxMzWP1AKNyWehcEgxnlwjmcOo0et4wQGM390Sxtu94jBaBWNLTXZ?= =?us-ascii?Q?KjeQDDzeJY+bPhQd0iTXTf8O7hgrvUHbTYWC9ygIlHCfX9idARKSBRC4tVeE?= =?us-ascii?Q?D/KKJaEr3gewUDJG0sfvojdJCBGCpAEtcX3dAtihEbNjgg+Kx+0lH7Rs0FGi?= =?us-ascii?Q?zTMVo41XImewxo5TesHNoDQFfPTD10lwL8c4ldtzC76oxMnkc/wgsIxL1MPB?= =?us-ascii?Q?QpHvxkamdFEulpgCpQUsRBa5L5nraRZ7azVlDaNnb83eTqE3LiwuDorZCPdZ?= =?us-ascii?Q?UuyeMTeeBas1ZiL0Z65toKL2zYgVpOkWAsMOLDMe5s5Z1ZDXcgH1Bmeoi9c1?= =?us-ascii?Q?HVI3VbCNVZo/qdSZEbrp0o/xQ0RtmmTufIYawIUi1vLgO2MBYQSL2mt3nBqt?= =?us-ascii?Q?ch3YQ88Vov7QSsxvIGcMtP8Z+njH+MEN+DrcYO8pONLShEYXCB1wNXpuOHMf?= =?us-ascii?Q?dNa6a4zV0T6xBzEqR7eaGfFhGsiqIB7gsm/cBk2OLik9DrkdJVYMmXRTJokF?= =?us-ascii?Q?cL8prbXCOpS0XizM654ErUrI2HuDVzGVR6ZQrkKu2+MptLdofrJq3UwZagiD?= =?us-ascii?Q?NYvUiO+NnmSh6QmCrCPtyQtrkfXKBg6ofVg+4Iypkap6l8wrPSZubRa8ha7V?= =?us-ascii?Q?UBCflw6uPAC2ZlAoXQTx1v6VcJfTJWsyww4pywgKDA48mI/z5YXH0DdG11l9?= =?us-ascii?Q?2wo0hN3Mgh31zK5DEHT7XImEAxN1LiJn3WcMFoN6Ka86uWanth7dTMHMbLlK?= =?us-ascii?Q?lz5tZ0QKdMFvd3KU0bQPXCrZc96Y3a1TLUIXPB5QmSH99QTnExDofWzl34bk?= =?us-ascii?Q?XyQyK5dn0x3fuNqOdWX+HjCZA0/8namvSovMmoecoDod14yyn4cvS7fMWhvT?= =?us-ascii?Q?fkiNRuYgnqdMkDCsj9gD7G6vbqtFnlLZqXrhaha8x2pyF6v9UulHA6+ufsRQ?= =?us-ascii?Q?5wuBNqJU2d2nRoiyH96qKgZ8XFr82b5znZ0p7x1zVgYc9AEofikmZrBq1jAd?= =?us-ascii?Q?6DiiuRNgTAPKLh5UK/fvtLMUzi6y4urr9gjl8jF3H0qOkeExzNvuvQkeF2iy?= =?us-ascii?Q?NkcAz5v/68LMSsICHX2ytR7BfJ5Z7VcXU5x8W9tU+gJAQuUurjtLPEBt3grn?= =?us-ascii?Q?txcLSNA+SF2zpnUAu4tIhbif08PmD88JRSNuXLQRfxG07yL9F36prTRw=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB310; 6:AQ4go9+vxYHdZXWtKdCqOZdKncfyP15OHvxbpaEm0kWB2+i4yOB6kMODPbUEoFRMxJAtCPYj+F+uf3bY82jxwzvM25tHxeDOqWdR/8bQQQz5yRKPUywqCaZGgC/sH70/B0Q3h+1hmIFw1ODe96zD2g3DkPjj9FOsxZToTEqTnnSIJt7eUB8ty9M4lCWT1nS/ZmLzYJuwLgzplNeps/6JWCnlpHhMY8I4t5xC5mFeUGZvhjNKHUsz9nEYrx2eVtGOaVJk1oP/sJVvmCaMgYihKIodLeIUMxV5LBWTPlZJHFn+/Y6ulO2XhqVbgXF4w0GnUNfQSd+WR64UxVbGaPFNZVNXUYGC7K5J+H38PoaAFTA=; 5:KUvuUOYAMk0bfVrlpzALe/UuFdFhM2VSijkdq9z+El9WkGIvKb8SZNN8jn/qCKn/0gQdFdLksvIagHZSWUqn2w3plyPzti0coHa/nXQz7f1NwBFtuWrt4xdMnFkNIxtGuilt+Zsz0IAFInw15IG+dmXDwzDP+2Okc9MCQkLvB04=; 24:XwpdN/Y0EcWRVNbdTaS572cxijir58ELwdGtm3Tm6N/4rW4uFcS5jC/lXjqD2cgBWSw2XpkIj6xuvu996goEx4FcOrviwN0mCAh+UnZUr6k=; 7:VFs8sS7lZ9MP6D1sNN0czg1H3qyS6Y6hAG3tupauXziq334bYjG/R0wrb1ZSTh4cmePXUIQvWA/u/8v/aKE3NuweiYpdyOd1vYlwfDWku/CDPGLP23/mJBNsy1kbvOqlEXP8iRpO9PF3YISj3ArjvgvZ4sCQxLuB57FUkU3I4RkQ1RvEAAJLB1lD93NXoGPWoiAZcd1GbV/ANBiYNiUaBLbK4v44DB6O2EnQHhe7xUqx+YF2LPup1YCpbhn+RRVG SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Dec 2017 05:11:17.8170 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5704184a-c5a5-44b6-4e1a-08d54f43c24e X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR07MB310 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes When compiling with Clang 6, I see these warnings: /home/emaisin/src/binutils-gdb/gdb/dwarf2read.c:25421:5: error: destructor called on non-final 'mapped_index' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor] data->index_table->~mapped_index (); ^ In file included from /home/emaisin/src/binutils-gdb/gdb/dwarf2read.c:31: In file included from /home/emaisin/src/binutils-gdb/gdb/defs.h:28: In file included from /home/emaisin/src/binutils-gdb/gdb/common/common-defs.h:92: In file included from /home/emaisin/src/binutils-gdb/gdb/common/gdb_unique_ptr.h:23: In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/memory:81: /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/unique_ptr.h:76:2: error: delete called on non-final 'mapped_debug_names' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor] delete __ptr; ^ /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/unique_ptr.h:236:4: note: in instantiation of member function 'std::default_delete::operator()' requested here get_deleter()(__ptr); ^ /home/emaisin/src/binutils-gdb/gdb/dwarf2read.c:2374:21: note: in instantiation of member function 'std::unique_ptr >::~unique_ptr' requested here dwarf2_per_objfile::dwarf2_per_objfile (struct objfile *objfile_, ^ This patch silences these warnings by making the classes final. gdb/ChangeLog: * dwarf2read.c (struct mapped_debug_names): Make final. (struct mapped_index): Make final. --- gdb/ChangeLog | 5 +++++ gdb/dwarf2read.c | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 9cc060e..b94384b 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2017-12-30 Simon Marchi + + * dwarf2read.c (struct mapped_debug_names): Make final. + (struct mapped_index): Make final. + 2017-12-29 Simon Marchi * common/diagnostics.h diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c index 484cbce..85e33f0 100644 --- a/gdb/dwarf2read.c +++ b/gdb/dwarf2read.c @@ -277,7 +277,7 @@ protected: /* A description of the mapped index. The file format is described in a comment by the code that writes the index. */ -struct mapped_index : public mapped_index_base +struct mapped_index final : public mapped_index_base { /* A slot/bucket in the symbol table hash. */ struct symbol_table_slot @@ -318,7 +318,7 @@ struct mapped_index : public mapped_index_base /* A description of the mapped .debug_names. Uninitialized map has CU_COUNT 0. */ -struct mapped_debug_names : public mapped_index_base +struct mapped_debug_names final : public mapped_index_base { bfd_endian dwarf5_byte_order; bool dwarf5_is_dwarf64;