From patchwork Tue Dec 19 18:54:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 25022 Received: (qmail 11357 invoked by alias); 19 Dec 2017 18:54:52 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 10935 invoked by uid 89); 19 Dec 2017 18:54:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1634 X-HELO: mail-qk0-f195.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=c+sWJjzAY+plgTluurT5BSiQfOyN3nLbeN5In+6Bs4Q=; b=Zju1xTUXQh+dunnW2HrPecSKT9zPJyAtGnHnxtiCC+pXXFVWgmpieR1WkckfXngeY5 ya0kRAoynRD+QYo4XFWUtce5DA4TPtP1qqdqO3Qyxr7g0abUyN5vQXXf2TQZC8QuhYjX 4woM9MyE+RYPLmjMmayO9fama1CgGCzfuf7JAZZ6+yPZjfYZFFfrCOeDbHrInHyTrRR5 IZmxFSjvWDTlzwe8izbjzu0uaWeOB3JeCfAXJFsxTI+u4uQO2S6rcV6lEg+lWYcE4cJY 9KASYlCK4d6i3dY50BKHD1T8QbIfkKmd9S+tjWHqRoP2Fs/I0ylUdVn5tyrSItwK8mln bXHg== X-Gm-Message-State: AKGB3mIU40FRHxNixcm59jigmOfnMgS8EesppEyAgcFIgdTWZtWEzYKs EF6nnkeuuhpcRumE5LV+DXt/8aDkVGE= X-Google-Smtp-Source: ACJfBouByJb3MvROSiSUA+JZ0Z8yJuLJPIRhKsnZV8rRSfrOqfUsICtN1l4Coe1L93p0M2WZd8nVrA== X-Received: by 10.55.160.18 with SMTP id j18mr6236780qke.351.1513709688463; Tue, 19 Dec 2017 10:54:48 -0800 (PST) Subject: Re: [PATCH] aarch64: Optimized memset for falkor To: libc-alpha@sourceware.org References: <1510651584-21402-1-git-send-email-siddhesh@sourceware.org> <5A12CD7F.9040601@arm.com> <5A395CA6.3040602@arm.com> From: Adhemerval Zanella Message-ID: Date: Tue, 19 Dec 2017 16:54:43 -0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <5A395CA6.3040602@arm.com> On 19/12/2017 16:38, Szabolcs Nagy wrote: > On 20/11/17 12:57, Siddhesh Poyarekar wrote: >> On Monday 20 November 2017 06:11 PM, Szabolcs Nagy wrote: >>> On 14/11/17 09:26, Siddhesh Poyarekar wrote: >>>> +libc_ifunc (__libc_memset, (IS_FALKOR (midr) && zva_size == 64 >>>> + ? __memset_falkor >>>> + : __memset_generic)); >>> >>> the falkor code is probably slightly better for >>> most of the zva==64 targets too, but this way >>> is probably the least risky and the logic can >>> be changed later if necessary. >>> >>> i don't see a way to fix falkor with smaller >>> impact on other cores. >>> >>> so this is OK to commit. >> >> Thanks, pushed. >> > > this broke --disable-multi-arch build > string/rtld-memset.os is missing then > i don't yet know the cause > > aarch64-none-linux-gnu-gcc -nostdlib -nostartfiles -shared -o B/elf/ld.so.new \ > -Wl,-z,combreloc -Wl,-z,relro -Wl,--hash-style=both -Wl,-z,defs \ > B/elf/librtld.os -Wl,--version-script=B/ld.map \ > -Wl,-soname=ld-linux-aarch64.so.1 \ > -Wl,-defsym=_begin=0 > B/elf/librtld.os: In function `_dl_map_segments': > S/elf/./dl-map-segments.h:131: undefined reference to `memset' > ... > collect2: error: ld returned 1 exit status > make[2]: *** [B/elf/ld.so] Error 1 > This should fix it: diff --git a/sysdeps/aarch64/memset.S b/sysdeps/aarch64/memset.S index 45fb0a8..7f5127f 100644 --- a/sysdeps/aarch64/memset.S +++ b/sysdeps/aarch64/memset.S @@ -19,6 +19,10 @@ #include #include "memset-reg.h" +#ifndef MEMSET +# define MEMSET memset +#endif + /* Assumptions: * * ARMv8-a, AArch64, unaligned accesses