From patchwork Tue Dec 12 20:57:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Steve Ellcey X-Patchwork-Id: 24895 Received: (qmail 79172 invoked by alias); 12 Dec 2017 20:57:37 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 79159 invoked by uid 89); 12 Dec 2017 20:57:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: NAM01-BN3-obe.outbound.protection.outlook.com Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Steve.Ellcey@cavium.com; Message-ID: <1513112247.23303.55.camel@cavium.com> Subject: [Patch] Use memcpy instead of strncpy in nscd/nscd.h to fix build problem with ToT GCC From: Steve Ellcey Reply-To: sellcey@cavium.com To: libc-alpha Date: Tue, 12 Dec 2017 12:57:27 -0800 Mime-Version: 1.0 X-ClientProxiedBy: BN6PR16CA0023.namprd16.prod.outlook.com (10.172.212.161) To CY1PR0701MB2041.namprd07.prod.outlook.com (10.163.142.140) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d351b669-ba23-49ce-44d6-08d541a2f64f X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307); SRVR:CY1PR0701MB2041; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB2041; 3:ZjcJftXDwSYY8O2dAdmusyQCaLZRohMMYLzmOQt5DquR7ky4eV0Z2lDeQK5VElTQNOfgq4ryzbgORh4UMrzz4J7sWXWxroSHjcU7hPevDsaJnaLK6mWsCK9epeKagc4722tocrXaQ22lq6bsqMiw5CYHDldrDn8WF9MFgxkcGaduVqsi1lgyV4yjfkxUuLjIrKKlKNQayU1yVCqtj5SWXLOkzLqj63mZJurdnfWunetgrSocDCfREvHDnG9rBy8I; 25:x4Lminec85+uTBSsYjsJ2CuHdKX+NishG8uv2fYmRLXoPew6lMJfRU8T/hTe3oS7m8cGqZjmXbDdCcvj7FVNCFsJkEbcJ31eF5g/P81NKQygNI/YhplrdpI6DSy7X88ttNWXpPS4+DC65Bq5TGkWE/wU1NgKvocW6wZnwCSX9WOfN3/ugZVtGVVUYOyUGwnkbUaDfT8XFUv2ikS9cKJf2YKgE2ouP2Q7TvV57t0b/DPsvnM7EsjYWF8ncnoFxyGdIAy4ohM7HinsHm3jQaUCgEPTQk2G81I7iFfjTqQVBbHcsGw3gsonPXW7cKBgmBQsb33Ez15Lj5N8etWKZWY+YJWao7SNDGqo52t6BqOFj6Y=; 31:peAsUu22AtKKRZb/fSGO+MtRihyHdd5FBd71WLyIfGIo+gzK6KBYbpvWAMUTUaAs1B1mNfEVXkoRyuwICpf4p0CXHZ/mL5yeNtvGQIwe8yGRh59nAafou8XDVIS0HX1qF5DYTVFmIGGdxRu7A/vcU0xZ648aMSAaJVF3TTL8HxPQB10SNP4zA2YlUXxY8kbKZjrI4GEuoN0TfHSJBCGGLp+OaXJ+dkvGsybYyijSwOY= X-MS-TrafficTypeDiagnostic: CY1PR0701MB2041: X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB2041; 20:pr7z3SYcv7cUPmB86bPqaUOu0ChR6i90X9ke+W+Kl78OgtOt673kG57Remt0kb5Pbi+vH5hpSY0Wn7glXKAJrP+u9cr+6E7G7PKX2fs6w50dWmzZwsJH5DtvH5d2IB388ROLWizxizJ948xcy9jwy/nHNg9XrY0fcLgAjHbtyH8Mlm3OmJrIlqeveSo4LSAs2JXPI4LW6rz0BCoOy6RrEeUiGPqEF/SUNSYJUFCKoSQCsySrgCJ4kC/Emfub2/gV47vQZjVldQXrOTlXNwz+NjDAwXdflSOzGByOXdCPcqaizbjGqjeaLLVifMMvrn5rMmCstkmRuKNOan1RaWHJ4S/Mv27MzSypvdo0yEWfOAUzlYbjIrll8antooSGlBU2WNotDKwS/cFVrTKcSaxd6iSKCo56S6OSVX/iCtVxbuzWjgPty+I0wD7TpbJAyc6zM3RZaquZ2uLBZDv9WykmtrMApcyEGSgu/1Zc/h+uL2U80L4iIJqcDngbgVbIg2h7; 4:S4VEllEGwcPidtTOrvrjqLjGDnpoO5HLrYt9Lh1TblOZudcpoSGNk4+1h7juDeoG0eK9EJyaJsIUYgkuGOkC7yKVigOMCCPV5FEEUPTjeV6qjmwShVfPCjr2xnwUK2xFHLhcpPjH0OtgGsPydOAYEZNnryWQ8mYg8l/6e1lZObgqX/JAbQ9jYUG/3Q92tEpWD1K8fu7E7+us31k7KaO07+Hnd8G390Ts9UiLYwQfodnvQUXZSM5rDYYMaX9lyAdIvtjSvfQmRfGX+33xQXKBLw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3231023)(3002001)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123560025)(20161123558100)(20161123555025)(20161123562025)(6072148)(201708071742011); SRVR:CY1PR0701MB2041; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:CY1PR0701MB2041; X-Forefront-PRVS: 051900244E X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(346002)(366004)(199004)(189003)(377424004)(59450400001)(23676004)(6486002)(5820100001)(53416004)(52116002)(575784001)(106356001)(6116002)(72206003)(6512007)(97736004)(53936002)(69596002)(3846002)(478600001)(36756003)(47776003)(6666003)(6916009)(316002)(16526018)(4001150100001)(7736002)(66066001)(50466002)(305945005)(8936002)(68736007)(25786009)(103116003)(8676002)(81156014)(81166006)(5660300001)(2870700001)(2906002)(105586002)(3450700001)(43066004)(50226002)(386003)(6506007)(99106002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0701MB2041; H:sellcey-dt.caveonetworks.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjA3MDFNQjIwNDE7MjM6bHc0bXFLaW9oYktKNzAzR1pUN2ozRzJW?= =?utf-8?B?VmVqNlc3b2RYUTlPZGtWTS9WbnJzSW9EVWFqYXlkb1VMVzROU2JwaU5XUmtJ?= =?utf-8?B?YzdtTEJ5eHlWaW9tY2dGZ204UTA5VGEwYUM3ZGRhL1gwdzZZaDNnbDVQclRx?= =?utf-8?B?b1VYUFFDOFNlbnEyaDNuWXhMZ0VWNzVXZ3lxeHFyOVhPVE9UeXlSa2JpajlC?= =?utf-8?B?ZkJzUVJWS0Q2eCtXT21leUxOb2NzMUZPUzZrV005bHFyQzljNDRMazN3Y2x5?= =?utf-8?B?TlA5NktST09URExXSDdXcFRpWkx4TWo1U09yczEvVUZVSDA4VlgydHVQVlhv?= =?utf-8?B?bkRRaHZzU0RReGFHTkgrd2dIaGdzTWpzbGtHOWp6S2xMZU9KM3BNZTR4eHpC?= =?utf-8?B?a2dqSUV6QnNhVEhmMWgwSFpMaGtUM0swbmdMYUMwQUVxd01FZVplVC9xMDFp?= =?utf-8?B?dEJ6QUZHZGFuR2RGbitYRFFEdnN1Z0hiK1Z0ZHMvakJJVkdDMXBYcHNtbTY2?= =?utf-8?B?QUdZeW94ckF1YkNRY2YzOXpzeURweHI2RjU0SE9NbGl3Qm9IQVlzc291bWVJ?= =?utf-8?B?eDhhcnNhVjVRWk5na1hsSjhEd0RqVno1OXZWMVk2TU82eVJwaFVOTGJHRVRE?= =?utf-8?B?WlhuaFBFQUNFbWRNOXFtZjN4L0NPNGdPdG04NnQzNkFHcEpkV1pXNnI2K1BM?= =?utf-8?B?MUt5d210R0JGOVFVVXBac2ZDRXY3MG5kbURESWhwazFSYUdxNkk1bGlHRDcr?= =?utf-8?B?RktXUUhNRjBXazNIY3ZvSEtkTEpZRUpuN3pOWEdSZDBkWWh4UnFpekxPeU1k?= =?utf-8?B?VTZ0cnhKR1dHYk9nbng3YUhkMHhXdU9wSnZDZEg1aCtJelNxWUZPVzNYL25h?= =?utf-8?B?dnM5dnVFQlNLZzlSSzFYNkFuM1ppUTg0cmJzL1lmd1JERmErNHNpUWhOdVFt?= =?utf-8?B?d1dPNnVXV1RobTZ2ZGdVUHFwcTVXSVYvSUNhQlU4VE0wUkk2dXJuNlRUamxN?= =?utf-8?B?b0dBLzk1WTM2R29rSjg5VzRsS2g5R3lvT0RsdXdWei96aWZxTldDR0F1bEpw?= =?utf-8?B?RDdQS0FSS0RoY21JUlluSE1QTkdGcjNhN051bmFpK0p6eDlJWTllTWtuWWcx?= =?utf-8?B?MHliNGtkUVVZdzJhaythQlVteUZKODJITzdvS3JhVG56aEd0NHJYSzJVM0dJ?= =?utf-8?B?a3llK1JxMFlLeDZ2YmpQVDBESkRVcE5yQUxITkJQbE1hUkExbk9raWlvMWxs?= =?utf-8?B?QkthOHNaVGZQc2w1R25jOWVvZ2RlYWluRDZsc25nSFNHc0hpTlBiNTl1clRP?= =?utf-8?B?VzI3Qmw3SEFvZTVoUDVyNkVqRnU0ck94QmtsNGdENndNSkFXMGlRK3FWNGNv?= =?utf-8?B?N29uc0E1cm9QYytsY0hjWDVUOWxmcXg2M2RGZWdJR25FdDlxV2ZtWjFsc0sz?= =?utf-8?B?NDdZMmg1Vm5DOVJqeTNSdkJEcTZ5d2p4NW5NV25oZkdFcmNSZ09lWWt0cEtR?= =?utf-8?B?SGk1M05OcG5yc1UwZTlNOFc1YjRtOGErcDBDYTBERHF0aEFpeWlhY2pjTmhm?= =?utf-8?B?TDEvN1IxNitNa2xXcUVmQ3ZLRWlOa0Z5cEQyaTNDVUZ1WjBiOWRVSjlheG1E?= =?utf-8?Q?E=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB2041; 6:scCvxfuF0kb+shNaYzucIZJ/TiYZRZfk/skj9eYMtYB/62ODwQ4VE47EfdaQrNboczUTSMSKykK3vNoXEv+dUk05RB/0x6e+rdLBJ/1NcKGruivOevfeAGUNyI+3XKl77eYV6ZTODH7qbciCbcsO7rYcpx72puAmHTtr03DIlpa4TuCetCv7lY4B7AVNungaAhye8YOqM4Bvi/FbuQYITqDiH513/QMDW9KrQ6O0vYijxErSiM88v/zjkr9EdP3tmRZ99bUQlkXPT27DnTflqC6iDynOHHrhvV1KlTIV0V2Akl6pmaSKrW/hs97LzrtNfh1s8FJgR6pRfnv09b2fyFOX3OeYB1FBvfrbCvDG4AI=; 5:NpOPzqmpSk7N8ihlzmAsXNRWCT3LQAHinnWo3eAcatNIc8/S351F+wqqPevHN2ZI01asiVDEzl5D61QbXNWm/Wnrz0KWgzEVkH1ZOH6HynBPMVK3Y7z+Ca+oBfEBAeqgFLC9T1YTENgCsejEkCUISK21DszKlIifv0pI7yQsZGw=; 24:FL+8esz3ElGPvNYBKrCM3R9uSoB+O9NYGyQd49X9R2wHttgNeUDGx+P6opfJANyOaxQV/o1gbssFv2KW/00ZB4pWyJDZ+5zmNNSqAuztDMc=; 7:Nis3Nhufe9C4uOsiTmXze/+GDSV3mDFxID9jI/a2baZ1XqtMlQixnparb412jCt6UhGXSoH618RPrP/MOwPYAht+rG1Fdd7Jp0K7Tp5sGm5CW6OjdUDpO32YNccQciO52Ptei78rIaumrzOxIj56QSx0thxXR8T4eOonA7xaS6iNStJPqQGaKEXGrnodwH0R+y10+GaEb6SgyGcqMhqF2vbdRCkxflPamaZJwqzFgpBlmSZU7BVjrY4LAVVWIwZK SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2017 20:57:31.1471 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d351b669-ba23-49ce-44d6-08d541a2f64f X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0701MB2041 The latest ToT GCC is warning about the use of strncpy in nscd/nscd.h. The strncpy is intentionally truncating a string so the warning is not really useful in this instance.  Joseph suggested changing it to a memcpy and that seems to work fine.  I built glibc with ToT GCC using this patch and ran the glibc test with no regressions on aarch64. OK to checkin? Steve Ellcey sellcey@cavium.com 2017-12-12  Steve Ellcey   * nscd/nscd.h (init_traced_file): Change strncpy to memcpy. diff --git a/nscd/nscd.h b/nscd/nscd.h index c6b0a3c..edcb5b6 100644 --- a/nscd/nscd.h +++ b/nscd/nscd.h @@ -108,7 +108,7 @@ init_traced_file(struct traced_file *file, const char *fname, int crinit)         size_t len = (size_t)(dname - fname);         if (len > sizeof (file->dname))    abort (); -       strncpy (file->dname, file->fname, len); +       memcpy (file->dname, file->fname, len);         file->dname[len] = '\0';       }     /* The basename is the name just after the last forward slash.  */