From patchwork Thu Dec 7 13:17:25 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Brobecker X-Patchwork-Id: 24775 Received: (qmail 99026 invoked by alias); 7 Dec 2017 13:17:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 99012 invoked by uid 89); 7 Dec 2017 13:17:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 07 Dec 2017 13:17:28 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 04A38116AC3; Thu, 7 Dec 2017 08:17:27 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id tKNpmRa8Z4va; Thu, 7 Dec 2017 08:17:26 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C85FF116AC2; Thu, 7 Dec 2017 08:17:26 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 40406809B5; Thu, 7 Dec 2017 14:17:25 +0100 (CET) Date: Thu, 7 Dec 2017 14:17:25 +0100 From: Joel Brobecker To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [pushed] Update GDB's list of maintainers to reflect today's reality Message-ID: <20171207131725.dva757q4owqpgqba@adacore.com> References: <20171201134047.14609-1-brobecker@adacore.com> <86k1y0oxsa.fsf@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <86k1y0oxsa.fsf@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) Hi Yao, > Some gdb build scripts gdb_buildall.sh and gdb_mbuild.sh parse > MAINTAINERS file to build gdb for each port. With your patch applied, > the scripts won't build gdb for these ports, is it intended? I am not > aware of other people using gdb_buildall.sh and gdb_mbuild.sh to build > gdb for different ports but I still use it from time to time. To be > clear, I don't mind stopping building them. Thanks for bringing that up. I did not realize this side-effect when I first pushed my change, and this is not something we should be doing without a discussion. I don't see a reason myself to change anything at the moment, so I don't think we need to do anything else other than restore the target entries, which the attached patch I just pushed does. gdb/ChangeLog: * MAINTAINERS: Restore target entries for m68hc11-elf, score-elf and xstormy16-elf, incorrectly removed in a previous patch meant to only update the list of active maintainers. Pushed to master. From 9c226a8689db8bced43b94f551e118551219ce54 Mon Sep 17 00:00:00 2001 From: Joel Brobecker Date: Thu, 7 Dec 2017 14:10:33 +0100 Subject: [PATCH] gdb/MAINTAINERS: restore m68hc11, score and xstormy16 entries This patch restores some entries removed by a recent patch whose purpose was to update the list of active maintainers. I thought that, the target information was purely to document the scope of the given target, and thus could be removed is maintainerless. But, in fact, those entries are still useful, as a number of scripts (eg: gdb_buildall.sh) use that information to build GDB with all targets enabled. gdb/ChangeLog: * MAINTAINERS: Restore target entries for m68hc11-elf, score-elf and xstormy16-elf, incorrectly removed in a previous patch meant to only update the list of active maintainers. --- gdb/ChangeLog | 6 ++++++ gdb/MAINTAINERS | 3 +++ 2 files changed, 9 insertions(+) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index cb3c83dace..4d42cf9234 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2017-12-07 Joel Brobecker + + * MAINTAINERS: Restore target entries for m68hc11-elf, + score-elf and xstormy16-elf, incorrectly removed in a previous + patch meant to only update the list of active maintainers. + 2017-12-06 Pedro Alves * break-catch-syscall.c (insert_catch_syscall) diff --git a/gdb/MAINTAINERS b/gdb/MAINTAINERS index 955536fb4c..4597972464 100644 --- a/gdb/MAINTAINERS +++ b/gdb/MAINTAINERS @@ -258,6 +258,7 @@ the native maintainer when resolving ABI issues. m32r --target=m32r-elf ,-Werror + m68hc11 --target=m68hc11-elf ,-Werror , m68k --target=m68k-elf ,-Werror m88k --target=m88k-openbsd ,-Werror @@ -300,6 +301,7 @@ the native maintainer when resolving ABI issues. s390 --target=s390-linux-gnu ,-Werror Andreas Arnez arnez@linux.vnet.ibm.com + score --target=score-elf sh --target=sh-elf ,-Werror --target=sh64-elf ,-Werror @@ -318,6 +320,7 @@ the native maintainer when resolving ABI issues. x86-64 --target=x86_64-linux-gnu ,-Werror + xstormy16 --target=xstormy16-elf xtensa --target=xtensa-elf All developers recognized by this file can make arbitrary changes to -- 2.11.0