Patchwork [pushed] Update GDB's list of maintainers to reflect today's reality

login
register
mail settings
Submitter Joel Brobecker
Date Dec. 7, 2017, 1:17 p.m.
Message ID <20171207131725.dva757q4owqpgqba@adacore.com>
Download mbox | patch
Permalink /patch/24775/
State New
Headers show

Comments

Joel Brobecker - Dec. 7, 2017, 1:17 p.m.
Hi Yao,

> Some gdb build scripts gdb_buildall.sh and gdb_mbuild.sh parse
> MAINTAINERS file to build gdb for each port.  With your patch applied,
> the scripts won't build gdb for these ports, is it intended?  I am not
> aware of other people using gdb_buildall.sh and gdb_mbuild.sh to build
> gdb for different ports but I still use it from time to time.  To be
> clear, I don't mind stopping building them.

Thanks for bringing that up. I did not realize this side-effect
when I first pushed my change, and this is not something we should
be doing without a discussion. I don't see a reason myself to change
anything at the moment, so I don't think we need to do anything else
other than restore the target entries, which the attached patch
I just pushed does.

gdb/ChangeLog:

        * MAINTAINERS: Restore target entries for m68hc11-elf,
        score-elf and xstormy16-elf, incorrectly removed in a previous
        patch meant to only update the list of active maintainers.

Pushed to master.

Patch

From 9c226a8689db8bced43b94f551e118551219ce54 Mon Sep 17 00:00:00 2001
From: Joel Brobecker <brobecker@adacore.com>
Date: Thu, 7 Dec 2017 14:10:33 +0100
Subject: [PATCH] gdb/MAINTAINERS: restore m68hc11, score and xstormy16 entries

This patch restores some entries removed by a recent patch whose purpose
was to update the list of active maintainers. I thought that, the target
information was purely to document the scope of the given target, and
thus could be removed is maintainerless. But, in fact, those entries
are still useful, as a number of scripts (eg: gdb_buildall.sh) use
that information to build GDB with all targets enabled.

gdb/ChangeLog:

	* MAINTAINERS: Restore target entries for m68hc11-elf,
	score-elf and xstormy16-elf, incorrectly removed in a previous
	patch meant to only update the list of active maintainers.
---
 gdb/ChangeLog   | 6 ++++++
 gdb/MAINTAINERS | 3 +++
 2 files changed, 9 insertions(+)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index cb3c83dace..4d42cf9234 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@ 
+2017-12-07  Joel Brobecker  <brobecker@adacore.com>
+
+	* MAINTAINERS: Restore target entries for m68hc11-elf,
+	score-elf and xstormy16-elf, incorrectly removed in a previous
+	patch meant to only update the list of active maintainers.
+
 2017-12-06  Pedro Alves  <palves@redhat.com>
 
 	* break-catch-syscall.c (insert_catch_syscall)
diff --git a/gdb/MAINTAINERS b/gdb/MAINTAINERS
index 955536fb4c..4597972464 100644
--- a/gdb/MAINTAINERS
+++ b/gdb/MAINTAINERS
@@ -258,6 +258,7 @@  the native maintainer when resolving ABI issues.
 
 	m32r		--target=m32r-elf ,-Werror
 
+	m68hc11		--target=m68hc11-elf ,-Werror ,
 	m68k		--target=m68k-elf ,-Werror
 
 	m88k		--target=m88k-openbsd ,-Werror
@@ -300,6 +301,7 @@  the native maintainer when resolving ABI issues.
 	s390		--target=s390-linux-gnu ,-Werror
 			Andreas Arnez		arnez@linux.vnet.ibm.com
 
+	score	--target=score-elf
 	sh		--target=sh-elf ,-Werror
 			--target=sh64-elf ,-Werror
 
@@ -318,6 +320,7 @@  the native maintainer when resolving ABI issues.
 
 	x86-64		--target=x86_64-linux-gnu ,-Werror
 
+	xstormy16	--target=xstormy16-elf
 	xtensa		--target=xtensa-elf
 
 All developers recognized by this file can make arbitrary changes to
-- 
2.11.0