From patchwork Tue Dec 5 18:05:04 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Szabolcs Nagy X-Patchwork-Id: 24744 Received: (qmail 89734 invoked by alias); 5 Dec 2017 18:05:13 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 89722 invoked by uid 89); 5 Dec 2017 18:05:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.8 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR01-VE1-obe.outbound.protection.outlook.com Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Szabolcs.Nagy@arm.com; Message-ID: <5A26DFD0.2090301@arm.com> Date: Tue, 05 Dec 2017 18:05:04 +0000 From: Szabolcs Nagy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: GNU C Library , Joseph Myers , Rajalakshmi Srinivasaraghavan CC: nd@arm.com Subject: [PATCH] fix sinf(NAN) X-ClientProxiedBy: AM3PR07CA0118.eurprd07.prod.outlook.com (2603:10a6:207:7::28) To DB6PR0802MB2486.eurprd08.prod.outlook.com (2603:10a6:4:a0::21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: b6772e36-b69b-48fa-aaae-08d53c0ab734 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603286)(49563074); SRVR:DB6PR0802MB2486; X-Microsoft-Exchange-Diagnostics: 1; DB6PR0802MB2486; 3:yv8xu4NNTCFAf+wre8FMonSj3/nouwyvY9WM1RgIsIlQKKSCbUSLJWvkdF1xEhqeaS01FXm3cWNCq5SioeU3VPKRefFkYh7A549y4hjoa87n98UP/c4GPaQx5mYbI9nJsLmGzZ1qZFLCqzECOMyA8X3y8e6FO/TquDCTbjq3PKr0tdYtdOqIJXlLp1Tfnu8Zq1kmbJwWhjUU7kApPcc9bNZPaaIVsaENnfD9JICIyQSHMn46vgjeC3i8c/cN8VtJ; 25:ZilvOKk0RJdtgVYTftMpRFVunki8DXi2TP9k2oUp5E9zapffXSEO3Sh8Wt9MhmZDmK2zod8PTxvfXGggIvblETxGCq8yS8ufWXeD1KYO9bUAtse8vnXDXlXx42+NkMo2rhwNiNys60zN+7H0qO1fEzI5LKkxvRVO5B369IzbX+AHCUbwTxUK0ko1E9TWjpjR/tgAaFyIViWqH+vQBW+QVTfau0h1Cc0UID/Bwg6UZAPcxTcO7RI7QR2DOd7+KiKaScdZfJO5vuT/3HJhVSWA59Je5BhhQfvneU0H1YxjX9i3e8UwtHK7azaigZ/F2FxDFjcrgJc5Ku74Sim68mhSBQ==; 31:hAYUODh8lTHU+nng3n3ye02YNVO2kXb96+MAr0VVYqR9s3uQfEvtcMzhmZeaF9dv+/deVMRCBIkesYhDszFnQ6pF3RylTqGEv+fN3TPacfrk22Wn10mUp0SpIBI4xRrMQfxsx3gSoeXC/vMIzYSXBtf0oHJ8L25IVwhyDW2A0AgvVGQ0eqP4YWh11bWrFeqH56zmgozUxWyqdcfFUhgSphFM0QGau8JjxMiVQejIKm4= X-MS-TrafficTypeDiagnostic: DB6PR0802MB2486: NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1; DB6PR0802MB2486; 20:otNNnENid9m52q4IuYiaVzTnYY/Ff1amjqZnikFkoRWj1dxL/0xcWog9/lyRRMxa0r9Eu/u0OEAjkECO9sL4bavhAjQjlRFirwFYGhTFAczXfY6E1WdAPxdvMRD9LV30gps5Rcyah0kS8YUZQ+tcToV/6ASsvAGJAvDaj6pYDL0=; 4:7qkDVUCgDhqWwKxKurttxb/KbVcxDr7hawXS2sDj5+qEz4e3d1RY8jqdkV4veQeoGDov7ri8PAZx4HrvakA6LeIANX96un9f8zzvA45FeYkHkutl6GzcEdYthmPoe0NhzCDksj5hjnaEaA+2uPl05nCPItQMzgeFntPNAi7hI3vSvKnqUxVVlugXeaVsPE1AfpZe+GLc8FvuM2yUy/gKtohzud1/OLd22uPMyvME7xV8HdgBuWMYja9n1Zg+RZ5HFP4e/UZlb1xB/VFjpue26l7r7axlCloHX0Lj4c9WQ5NaPS5Q6CMlfJ8OUnC6XQC8 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(102415395)(6040450)(2401047)(5005006)(8121501046)(3231022)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041248)(20161123562025)(20161123558100)(20161123560025)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:DB6PR0802MB2486; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:DB6PR0802MB2486; X-Forefront-PRVS: 0512CC5201 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(366004)(39860400002)(346002)(376002)(377424004)(199004)(189003)(270700001)(86362001)(21490400003)(7736002)(101416001)(65806001)(66066001)(5890100001)(16586007)(80316001)(58126008)(568964002)(65956001)(33656002)(16576012)(316002)(16526018)(68736007)(305945005)(106356001)(564344004)(105586002)(36756003)(6116002)(110136005)(3846002)(5660300001)(25786009)(2476003)(59896002)(83506002)(5000100001)(8676002)(4326008)(8936002)(65816011)(64126003)(87266011)(2906002)(81156014)(33964004)(81166006)(52116002)(6486002)(77096006)(478600001)(97736004)(4610100001)(72206003)(84326002)(53936002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0802MB2486; H:[10.2.206.69]; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR0802MB2486; 23:qhKMivcjJO4wyACYTrTYyVNAyrINdhodBkO3HUN?= =?us-ascii?Q?CmzXKOOC+kgtD1CmuB1/XeDBiOL2MCq5WRRAdE4ttbK1HTBa6nVXWQBm7QT4?= =?us-ascii?Q?f4t9Q1Ksy8m8JZYJshSUpiW5uLqzQUC0rrKjNm9KAHPuzjRhUjcam9LaYDfF?= =?us-ascii?Q?qdU0pqSLZTI45GPxNqEl3HR6eKXQFcOFJFuZjXnhTe4zXvy/HvQHGHW5fcM+?= =?us-ascii?Q?tjcuLcKhNtch3suZxsrzyEBoplUB+hdzSk2YZOPA7Qei0M36qU08O91AX54C?= =?us-ascii?Q?P9x4lL7U8kGM0yqev28ttucaNvImKgeL+Kt25/P76MaQt2JhZMI6ZL0tY0bk?= =?us-ascii?Q?3BCir5gzk/znbOx4Pj7NYGnFCve2tfWCVNTggPeAY8GMg/Xa3uzJSpXo9pDa?= =?us-ascii?Q?kLp2lzLcHpOqpPXxHl7rxMpgeZOcsR9tLRyWN50a0HD0N8rkBExnVv7LTkMS?= =?us-ascii?Q?b27Wk+gSj8dMGmyWaXHH+0+HgQUiNv3QmcY2kbnXrlZcYUY7QHaYl6I827gL?= =?us-ascii?Q?2XN6pHoPhas5GIysizvYyZBwXhVWQUO7Y7QRUt61AyZOnuTkuq1fxuyntItE?= =?us-ascii?Q?9OGAnQFQo8q3p2HyAAS6ldaw74nt//wiTAsHV6r9s0WE2RmnqqshIK36vjja?= =?us-ascii?Q?Qj6zF1q/m4839qarDqFedteInMz0qx+A440bgxe5kmCl+/cd7Xa2htqZCMXz?= =?us-ascii?Q?THmsHoHmsZGqP0+dA1u90KPUyzGtqBHf0LbpWNtocieoU3dAl9KVM4N+mQq5?= =?us-ascii?Q?uTmaHT0+9Aib7QoZPWOyQ0tSeDwk+IkOEhtV+5M3oosRJyDLAl/UkerV+iPF?= =?us-ascii?Q?teNsnPuCkCPytVtv+AvYsY6xG7VMvbKLvumWLX9suX5QxVzlPeRJxa8o6/E9?= =?us-ascii?Q?K0oESGqeky5678S3a2WUvSwLQNrCz8UpyyogijWgS+n0IBCS2xajK8VJa5J2?= =?us-ascii?Q?G9i4UykaERon7S7Yn2RCRCJE7S9UoCca31hTQoAYAJ/BAadolEJMmwXPG8V7?= =?us-ascii?Q?6G9p9P/a5KfZ1aeDJSMRzUBEIq+smCQ+weW5swQL3RpQtBbVhon4jWmTaSyK?= =?us-ascii?Q?RbfMHOH7JKNGG+SbTPOCQ4Cea/GjBPOGFmaf7CLTRy3E+xs7hicGOjgcwYna?= =?us-ascii?Q?2FGjkrLxmCqbpHto2OP5FTN7BI2cUds4U1wJOrDGT0fk/e+QYFGWxjdRROP7?= =?us-ascii?Q?4SVKKnkGZov5ZoUEePH+ycLhnp0wiOcaSfLv5+sBEZxj1AmDmqV2CmhBiyhB?= =?us-ascii?Q?GXI8XzH/LePYAWbaHYxyGA/v5/BDStpcxAn5cbU3LUNTXuoJitzFXI2zkyUn?= =?us-ascii?Q?MoX1HqVSXlfikEd5UkFymJrcrT1sVyJ2ezAKHCZbfgmkh/zNUkHwfKP6azvY?= =?us-ascii?Q?ndbGAzQGZ5QVdz2dnYu+/E5zLxfgtkFW8unEPKs2ULBuWoMLo?= X-Microsoft-Exchange-Diagnostics: 1; DB6PR0802MB2486; 6:bAk3dyobwZN+zL6khjqoh/AYZ4sLzRMh5mDkn9RpH9MAyrS1TIlCiuL1pGYdXhgAuuU1ku14jqU0yEM8reMSnbX8RHCbevWqqvJ2bV6b9NfnQFEbUozuk0iarsDWkArSnZ+3o52FONtDk6bYXvWMANF042pP9iCzwOEmkcwomxGYuinsvj0Hc3/2U6JUUYDWIbZ5/Gd1EZn9R9cyZetUj/ARXhK8eSXiLb/8+Hg5gaAyATbrp6QfOt4GqnAhDM0Sm/BbnThDGn0EauhbT96guvjB7iL9kljO88iWJcKaeOoM+ZqGpt7x0UdrZ9bLsKhNg7YRCYkNHUKqDWIgH7nIc9BDbWhSsSyU6wF0imdeg9E=; 5:Voft0dvXnQaENn6VReoMK+edZB5NxILZ3F/BEGngsPJLd9C3x7b41zCC3a5S6sxao+OJCn4b5gAT4baMM5lz4x6Y7FeuHISF3+3+WSW+U/8TSM7xg9oCtdDTwXBArvYRQsuf25wB5jzwxbORFNB394jPKrKosPDXANuOBfg2SAg=; 24:EeT4B6IwKmZ/QYfCbTSFUlCRMC+/hyi5kNAYBFeZgXk2uEJa/PqECcmU4/XRN4bl4/UYTASTxYWzyr9Rf7Hcb85ogutDUKz3vKn2islnL8g=; 7:6IRYy07IKBrmkTeKtu6q5ouz45ueKmV08ZAoC9oV2Axxa/blU6DHkCbSfqWgajYJof+HUKSZVV5zkWM0//sKF+l5W/z0jViP++wjqffjeeLqFEeRjijfSKkLp91gMFRdCeYljYSF7wdF3UhjOZb3E9aDMGqUKcQuv4zHlC8pc6K6xSrs9IQtUO2QPWq3RCAQBhU3fbMfIBiiXmaJfuH6Ci4H9g+oPLsfp7+vYOloQWBtppoCBF42z39IccTZpwJN SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2017 18:05:06.1314 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b6772e36-b69b-48fa-aaae-08d53c0ab734 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2486 sinf(NAN) should not signal invalid fp exception so use isless instead of < where NAN is compared. this makes the sinf tests pass on aarch64. 2017-12-05 Szabolcs Nagy * sysdeps/ieee754/flt-32/s_sinf.c (sinf): Use isless. diff --git a/sysdeps/ieee754/flt-32/s_sinf.c b/sysdeps/ieee754/flt-32/s_sinf.c index 40d3d197a8..db1b5a18cb 100644 --- a/sysdeps/ieee754/flt-32/s_sinf.c +++ b/sysdeps/ieee754/flt-32/s_sinf.c @@ -128,7 +128,7 @@ SINF_FUNC (float x) double theta = x; double abstheta = fabs (theta); /* If |x|< Pi/4. */ - if (abstheta < M_PI_4) + if (isless (abstheta, M_PI_4)) { if (abstheta >= 0x1p-5) /* |x| >= 2^-5. */ { @@ -162,8 +162,8 @@ SINF_FUNC (float x) } else /* |x| >= Pi/4. */ { - unsigned int signbit = (x < 0); - if (abstheta < 9 * M_PI_4) /* |x| < 9*Pi/4. */ + unsigned int signbit = isless (x, 0); + if (isless (abstheta, 9 * M_PI_4)) /* |x| < 9*Pi/4. */ { /* There are cases where FE_UPWARD rounding mode can produce a result of abstheta * inv_PI_4 == 9,