Patchwork fix sinf(NAN)

login
register
mail settings
Submitter Szabolcs Nagy
Date Dec. 5, 2017, 6:05 p.m.
Message ID <5A26DFD0.2090301@arm.com>
Download mbox | patch
Permalink /patch/24744/
State New
Headers show

Comments

Szabolcs Nagy - Dec. 5, 2017, 6:05 p.m.
sinf(NAN) should not signal invalid fp exception
so use isless instead of < where NAN is compared.

this makes the sinf tests pass on aarch64.

2017-12-05  Szabolcs Nagy  <szabolcs.nagy@arm.com>

	* sysdeps/ieee754/flt-32/s_sinf.c (sinf): Use isless.
Joseph Myers - Dec. 5, 2017, 6:06 p.m.
On Tue, 5 Dec 2017, Szabolcs Nagy wrote:

> sinf(NAN) should not signal invalid fp exception
> so use isless instead of < where NAN is compared.
> 
> this makes the sinf tests pass on aarch64.
> 
> 2017-12-05  Szabolcs Nagy  <szabolcs.nagy@arm.com>
> 
> 	* sysdeps/ieee754/flt-32/s_sinf.c (sinf): Use isless.

OK.

Patch

diff --git a/sysdeps/ieee754/flt-32/s_sinf.c b/sysdeps/ieee754/flt-32/s_sinf.c
index 40d3d197a8..db1b5a18cb 100644
--- a/sysdeps/ieee754/flt-32/s_sinf.c
+++ b/sysdeps/ieee754/flt-32/s_sinf.c
@@ -128,7 +128,7 @@  SINF_FUNC (float x)
   double theta = x;
   double abstheta = fabs (theta);
   /* If |x|< Pi/4.  */
-  if (abstheta < M_PI_4)
+  if (isless (abstheta, M_PI_4))
     {
       if (abstheta >= 0x1p-5) /* |x| >= 2^-5.  */
 	{
@@ -162,8 +162,8 @@  SINF_FUNC (float x)
     }
   else                          /* |x| >= Pi/4.  */
     {
-      unsigned int signbit = (x < 0);
-      if (abstheta < 9 * M_PI_4)        /* |x| < 9*Pi/4.  */
+      unsigned int signbit = isless (x, 0);
+      if (isless (abstheta, 9 * M_PI_4))        /* |x| < 9*Pi/4.  */
 	{
 	  /* There are cases where FE_UPWARD rounding mode can
 	     produce a result of abstheta * inv_PI_4 == 9,