From patchwork Mon Dec 4 18:09:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lu, Hongjiu" X-Patchwork-Id: 24715 Received: (qmail 112534 invoked by alias); 4 Dec 2017 18:09:08 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 112521 invoked by uid 89); 4 Dec 2017 18:09:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-23.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY, KAM_SHORT, KAM_STOCKGEN, NO_DNS_FOR_FROM, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=5566 X-HELO: mga01.intel.com X-ExtLoop1: 1 Date: Mon, 4 Dec 2017 10:09:05 -0800 From: "H.J. Lu" To: GNU C Library Cc: Arjan van de Ven Subject: [PATCH] x86-64: Add sinf with FMA Message-ID: <20171204180905.GA31592@gmail.com> Reply-To: "H.J. Lu" MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.9.1 (2017-09-22) On Skylake, bench-sinf reports performance improvement: Before After Improvement max 153.996 100.094 54% min 8.546 6.852 25% mean 18.1223 14.4616 25% Any comments? H.J. --- * sysdeps/x86_64/fpu/multiarch/Makefile (libm-sysdep_routines): Add s_sinf-sse2 and s_sinf-fma. (CFLAGS-s_sinf-fma.c): New. * sysdeps/x86_64/fpu/s_sinf.S (sinf): Add alias only if __sinf is undefined. * sysdeps/x86_64/fpu/multiarch/s_sinf-fma.c: New file. * sysdeps/x86_64/fpu/multiarch/s_sinf-sse2.S: Likewise. * sysdeps/x86_64/fpu/multiarch/s_sinf.c: Likewise. --- sysdeps/x86_64/fpu/multiarch/Makefile | 5 ++++- sysdeps/x86_64/fpu/multiarch/s_sinf-fma.c | 3 +++ sysdeps/x86_64/fpu/multiarch/s_sinf-sse2.S | 3 +++ sysdeps/x86_64/fpu/multiarch/s_sinf.c | 28 ++++++++++++++++++++++++++++ sysdeps/x86_64/fpu/s_sinf.S | 2 ++ 5 files changed, 40 insertions(+), 1 deletion(-) create mode 100644 sysdeps/x86_64/fpu/multiarch/s_sinf-fma.c create mode 100644 sysdeps/x86_64/fpu/multiarch/s_sinf-sse2.S create mode 100644 sysdeps/x86_64/fpu/multiarch/s_sinf.c diff --git a/sysdeps/x86_64/fpu/multiarch/Makefile b/sysdeps/x86_64/fpu/multiarch/Makefile index c78624b47d..cab84bff3a 100644 --- a/sysdeps/x86_64/fpu/multiarch/Makefile +++ b/sysdeps/x86_64/fpu/multiarch/Makefile @@ -37,14 +37,17 @@ CFLAGS-slowpow-fma.c = -mfma -mavx2 CFLAGS-s_sin-fma.c = -mfma -mavx2 CFLAGS-s_tan-fma.c = -mfma -mavx2 +libm-sysdep_routines += s_sinf-sse2 + libm-sysdep_routines += e_exp2f-fma e_expf-fma e_log2f-fma e_logf-fma \ - e_powf-fma + e_powf-fma s_sinf-fma CFLAGS-e_exp2f-fma.c = -mfma -mavx2 CFLAGS-e_expf-fma.c = -mfma -mavx2 CFLAGS-e_log2f-fma.c = -mfma -mavx2 CFLAGS-e_logf-fma.c = -mfma -mavx2 CFLAGS-e_powf-fma.c = -mfma -mavx2 +CFLAGS-s_sinf-fma.c = -mfma -mavx2 libm-sysdep_routines += e_exp-fma4 e_log-fma4 e_pow-fma4 s_atan-fma4 \ e_asin-fma4 e_atan2-fma4 s_sin-fma4 s_tan-fma4 \ diff --git a/sysdeps/x86_64/fpu/multiarch/s_sinf-fma.c b/sysdeps/x86_64/fpu/multiarch/s_sinf-fma.c new file mode 100644 index 0000000000..5f6e17fc4d --- /dev/null +++ b/sysdeps/x86_64/fpu/multiarch/s_sinf-fma.c @@ -0,0 +1,3 @@ +#define SINF __sinf_fma + +#include diff --git a/sysdeps/x86_64/fpu/multiarch/s_sinf-sse2.S b/sysdeps/x86_64/fpu/multiarch/s_sinf-sse2.S new file mode 100644 index 0000000000..523456c66c --- /dev/null +++ b/sysdeps/x86_64/fpu/multiarch/s_sinf-sse2.S @@ -0,0 +1,3 @@ +#define __sinf __sinf_sse2 + +#include diff --git a/sysdeps/x86_64/fpu/multiarch/s_sinf.c b/sysdeps/x86_64/fpu/multiarch/s_sinf.c new file mode 100644 index 0000000000..831bc6f131 --- /dev/null +++ b/sysdeps/x86_64/fpu/multiarch/s_sinf.c @@ -0,0 +1,28 @@ +/* Multiple versions of sinf. + Copyright (C) 2017 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#include + +extern float __redirect_sinf (float); + +#define SYMBOL_NAME sinf +#include "ifunc-fma.h" + +libc_ifunc_redirected (__redirect_sinf, __sinf, IFUNC_SELECTOR ()); + +libm_alias_float (__sin, sin) diff --git a/sysdeps/x86_64/fpu/s_sinf.S b/sysdeps/x86_64/fpu/s_sinf.S index c505d60091..db7dce0c8a 100644 --- a/sysdeps/x86_64/fpu/s_sinf.S +++ b/sysdeps/x86_64/fpu/s_sinf.S @@ -556,4 +556,6 @@ L(SP_ABS_MASK): /* Mask for getting SP absolute value */ .type L(SP_ABS_MASK), @object ASM_SIZE_DIRECTIVE(L(SP_ABS_MASK)) +#ifndef __sinf libm_alias_float (__sin, sin) +#endif