Use boards/local-board.exp more
Commit Message
local-board.exp was introduced recently, containing the code required to
force the gdbserver boards to be non-remote (from the DejaGNU point of
view). Other board files use the same trick of forcing isremote to 0.
Instead of doing it by hand in each file, include local-board.exp.
gdb/testsuite/ChangeLog:
* boards/cc-with-tweaks.exp: Include local-board.exp instead of
setting isremote by hand.
* boards/dwarf4-gdb-index.exp: Likewise.
* boards/fission.exp: Likewise.
* boards/stabs.exp: Likewise.
---
gdb/testsuite/boards/cc-with-tweaks.exp | 5 +----
gdb/testsuite/boards/dwarf4-gdb-index.exp | 5 +----
gdb/testsuite/boards/fission.exp | 6 ++----
gdb/testsuite/boards/stabs.exp | 6 ++----
4 files changed, 6 insertions(+), 16 deletions(-)
Comments
On 11/30/2017 04:34 PM, Simon Marchi wrote:
> local-board.exp was introduced recently, containing the code required to
> force the gdbserver boards to be non-remote (from the DejaGNU point of
> view). Other board files use the same trick of forcing isremote to 0.
> Instead of doing it by hand in each file, include local-board.exp.
OK.
Thanks,
Pedro Alves
On 2017-11-30 11:37, Pedro Alves wrote:
> On 11/30/2017 04:34 PM, Simon Marchi wrote:
>> local-board.exp was introduced recently, containing the code required
>> to
>> force the gdbserver boards to be non-remote (from the DejaGNU point of
>> view). Other board files use the same trick of forcing isremote to 0.
>> Instead of doing it by hand in each file, include local-board.exp.
>
> OK.
>
> Thanks,
> Pedro Alves
Thanks, pushed.
Simon
@@ -30,10 +30,7 @@ if ![info exists CC_WITH_TWEAKS_FLAGS] {
}
# This is needed otherwise dejagnu tries to rsh to host "cc-with-tweaks".
-# set_board_info only sets the value if not already set.
-# find_gcc checks for this, so set early.
-unset_board_info isremote
-set_board_info isremote 0
+load_board_description "local-board"
# This is based on baseboards/unix.exp.
# At the moment we only support systems that unix.exp supports.
@@ -20,10 +20,7 @@
# bash$ make check RUNTESTFLAGS='--target_board=dwarf4-gdb-index'
# This is needed otherwise dejagnu tries to rsh to host "dwarf4-gdb-index".
-# set_board_info only sets the value if not already set.
-# find_gcc checks for this, so set early.
-unset_board_info isremote
-set_board_info isremote 0
+load_board_description "local-board"
# This is based on baseboards/unix.exp.
# At the moment we only support systems that unix.exp supports.
@@ -31,7 +31,5 @@ set_board_info compiler "[find_gcc]"
# -gsplit-dwarf implies -ggnu-pubnames for gcc, it doesn't for clang.
set_board_info debug_flags "-gdwarf-4 -gsplit-dwarf -ggnu-pubnames -fdebug-types-section -Wl,--gdb-index"
-# This is needed otherwise dejagnu tries to rsh to host "fission". Blech.
-# Double blech: set_board_info only sets the value if not already set.
-unset_board_info isremote
-set_board_info isremote 0
+# This is needed otherwise dejagnu tries to rsh to host "fission".
+load_board_description "local-board"
@@ -39,7 +39,5 @@ set_board_info compiler "[find_gcc]"
# Use -gstabs+ instead of -gstabs for better c++ support.
set_board_info debug_flags "-gstabs+"
-# This is needed otherwise dejagnu tries to rsh to host "stabs". Blech.
-# Double blech: set_board_info only sets the value if not already set.
-unset_board_info isremote
-set_board_info isremote 0
+# This is needed otherwise dejagnu tries to rsh to host "stabs".
+load_board_description "local-board"