From patchwork Wed Nov 29 17:04:32 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 24601 Received: (qmail 17063 invoked by alias); 29 Nov 2017 17:04:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 17027 invoked by uid 89); 29 Nov 2017 17:04:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.5 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KB_WAM_FROM_NAME_SINGLEWORD, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*RU:sk:cm15.we, liking, H*RU:100.42.49.9, Hx-spam-relays-external:sk:cm15.we X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.186.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Nov 2017 17:04:34 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway36.websitewelcome.com (Postfix) with ESMTP id A79C1400D18A9 for ; Wed, 29 Nov 2017 11:04:33 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id K5mjeo3nf5b6TK5mjeyDeT; Wed, 29 Nov 2017 11:04:33 -0600 Received: from 71-218-90-63.hlrn.qwest.net ([71.218.90.63]:34848 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1eK5mj-000ZUN-Dv; Wed, 29 Nov 2017 11:04:33 -0600 From: Tom Tromey To: Tom Tromey Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [RFA] Fix gdb snapshots References: <20171129163158.18968-1-tom@tromey.com> <8e2ede504e1aab0bc0cda57e10989bb2@polymtl.ca> <87zi756mw4.fsf@tromey.com> Date: Wed, 29 Nov 2017 10:04:32 -0700 In-Reply-To: <87zi756mw4.fsf@tromey.com> (Tom Tromey's message of "Wed, 29 Nov 2017 10:00:11 -0700") Message-ID: <87vaht6mov.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 X-BWhitelist: no X-Source-L: No X-Exim-ID: 1eK5mj-000ZUN-Dv X-Source-Sender: 71-218-90-63.hlrn.qwest.net (pokyo) [71.218.90.63]:34848 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes Tom> Perhaps rmdir||true will be more to your liking. How's this? Tom commit ea7e34a8e4a79231ea952f711d02729021cbabd0 Author: Tom Tromey Date: Wed Nov 29 09:27:40 2017 -0700 Fix gdb snapshots Joel pointed out that gdb snapshots were broken by my Makefile patch series. The bug is that rmdir in distclean was failing, because the directories in question did not exist. This fixes the problem by ignoring errors from rmdir. Tested using "src-release.sh gdb". 2017-11-29 Tom Tromey * Makefile.in (distclean): Handle the case where rmdir fails. diff --git a/gdb/ChangeLog b/gdb/ChangeLog index ebb969998c..dbea503d02 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2017-11-29 Tom Tromey + + * Makefile.in (distclean): Handle the case where rmdir fails. + 2017-11-27 Tom Tromey * Makefile.in (REMOTE_OBS): Remove. diff --git a/gdb/Makefile.in b/gdb/Makefile.in index 6e16bc6682..1ecd5a76b3 100644 --- a/gdb/Makefile.in +++ b/gdb/Makefile.in @@ -1995,7 +1995,7 @@ distclean: clean rm -f Makefile rm -rf $(DEPDIR) for i in $(CONFIG_SRC_SUBDIR); do \ - rmdir $$i/$(DEPDIR); \ + rm -rf $$i/$(DEPDIR) || true; \ done maintainer-clean: local-maintainer-clean do-maintainer-clean distclean