From patchwork Wed Nov 29 16:31:58 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 24599 Received: (qmail 41974 invoked by alias); 29 Nov 2017 16:32:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 41957 invoked by uid 89); 29 Nov 2017 16:32:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.5 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KB_WAM_FROM_NAME_SINGLEWORD, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1294, H*MI:tom, i X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.179.30) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Nov 2017 16:32:01 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 98981647B for ; Wed, 29 Nov 2017 10:32:00 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id K5HEezHCvRtUXK5HEe6UV2; Wed, 29 Nov 2017 10:32:00 -0600 Received: from 71-218-90-63.hlrn.qwest.net ([71.218.90.63]:46542 helo=pokyo.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1eK5HE-000Sn3-8r; Wed, 29 Nov 2017 10:32:00 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFA] Fix gdb snapshots Date: Wed, 29 Nov 2017 09:31:58 -0700 Message-Id: <20171129163158.18968-1-tom@tromey.com> X-BWhitelist: no X-Source-L: No X-Exim-ID: 1eK5HE-000Sn3-8r X-Source-Sender: 71-218-90-63.hlrn.qwest.net (pokyo.Home) [71.218.90.63]:46542 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes Joel pointed out that gdb snapshots were broken by my Makefile patch series. The bug is that rmdir in distclean was failing, because the directories in question did not exist. The simplest fix was to just use "rm -rf", which won't fail if the directory is missing. Tested using "src-release.sh gdb". 2017-11-29 Tom Tromey * Makefile.in (distclean): Use "rm -rf", not "rmdir". --- gdb/ChangeLog | 4 ++++ gdb/Makefile.in | 4 +++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index ebb969998c..7532016499 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2017-11-29 Tom Tromey + + * Makefile.in (distclean): Use "rm -rf", not "rmdir". + 2017-11-27 Tom Tromey * Makefile.in (REMOTE_OBS): Remove. diff --git a/gdb/Makefile.in b/gdb/Makefile.in index 6e16bc6682..39f90bad9f 100644 --- a/gdb/Makefile.in +++ b/gdb/Makefile.in @@ -1995,7 +1995,9 @@ distclean: clean rm -f Makefile rm -rf $(DEPDIR) for i in $(CONFIG_SRC_SUBDIR); do \ - rmdir $$i/$(DEPDIR); \ + # Use rm -rf, not rmdir, to avoid errors when the \ + # directory does not exist. \ + rm -rf $$i/$(DEPDIR); \ done maintainer-clean: local-maintainer-clean do-maintainer-clean distclean