From patchwork Wed Nov 29 10:55:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergio Lopez X-Patchwork-Id: 24593 Received: (qmail 123214 invoked by alias); 29 Nov 2017 10:55:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 123184 invoked by uid 89); 29 Nov 2017 10:55:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.7 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KB_WAM_FROM_NAME_SINGLEWORD, SPF_HELO_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=2039 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Nov 2017 10:55:57 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 47EC57F41E for ; Wed, 29 Nov 2017 10:55:56 +0000 (UTC) Received: from dritchie.redhat.com (ovpn-117-26.ams2.redhat.com [10.36.117.26]) by smtp.corp.redhat.com (Postfix) with ESMTP id 698BB5D6A3; Wed, 29 Nov 2017 10:55:55 +0000 (UTC) From: Sergio Lopez To: gdb-patches@sourceware.org Cc: Sergio Lopez Subject: [PATCH v2 3/4] Implement "-a" command line option for gcore Date: Wed, 29 Nov 2017 11:55:42 +0100 Message-Id: <20171129105543.19236-4-slp@redhat.com> In-Reply-To: <20171129105543.19236-1-slp@redhat.com> References: <20171129105543.19236-1-slp@redhat.com> With the new "-a" command line option, the user may request gcore to actually dump all present memory mappings. The actual effect of this argument is OS dependent. On GNU/Linux, it will disable use-coredump-filter and enable dump-excluded-mappings. gdb/ChangeLog: 2017-11-29 Sergio Lopez * gcore.in: Add "-a" command line option for instructing gdb to dump all memory mappings (OS dependent). --- gdb/gcore.in | 47 ++++++++++++++++++++++++++++++----------------- 1 file changed, 30 insertions(+), 17 deletions(-) diff --git a/gdb/gcore.in b/gdb/gcore.in index 632f21bdfa..44b2e98b27 100644 --- a/gdb/gcore.in +++ b/gdb/gcore.in @@ -20,27 +20,39 @@ # It starts up gdb, attaches to the given PID and invokes the gcore command. # -if [ "$#" -eq "0" ] -then - echo "usage: @GCORE_TRANSFORM_NAME@ [-o filename] pid" - exit 2 -fi - # Need to check for -o option, but set default basename to "core". name=core -if [ "$1" = "-o" ] +# When the -a option is present, this may hold additional commands +# to ensure gdb dumps all mappings (OS dependent). +dump_all_cmds=() + +while getopts :ao: opt; do + case $opt in + a) + case $OSTYPE in + linux*) + dump_all_cmds=("-ex" "set use-coredump-filter off") + dump_all_cmds+=("-ex" "set dump-excluded-mappings on") + ;; + esac + ;; + o) + name=$OPTARG + ;; + *) + echo "usage: @GCORE_TRANSFORM_NAME@ [-a] [-o filename] pid" + exit 2 + ;; + esac +done + +shift $((OPTIND-1)) + +if [ "$#" -eq "0" ] then - if [ "$#" -lt "3" ] - then - # Not enough arguments. - echo "usage: @GCORE_TRANSFORM_NAME@ [-o filename] pid" - exit 2 - fi - name=$2 - - # Shift over to start of pid list - shift; shift + echo "usage: @GCORE_TRANSFORM_NAME@ [-a] [-o filename] pid" + exit 2 fi # Attempt to fetch the absolute path to the gcore script that was @@ -87,6 +99,7 @@ do # available but not accessible as GDB would get stopped on SIGTTIN. $binary_path/@GDB_TRANSFORM_NAME@