[RFA,13/13] Redefine REMOTE_OBS in terms of a list of sources
Commit Message
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> I think it'd be even better to get rid of REMOTE_SRCS and fold it into
Pedro> the common sources.
Pedro> If you want to go ahead and that, then it's pre-approved.
Seems like a good idea. I've appended what I came up with.
I probably won't check these patches in until next week, in case they
break the build somehow. Like much of the US I'm not really around
right now.
Tom
commit 3f85218462fd335be2884f545663671cc9eabbf0
Author: Tom Tromey <tom@tromey.com>
Date: Wed Nov 22 20:57:04 2017 -0700
Remove REMOTE_OBS
This removes REMOTE_OBS from the Makefile. It is no longer needed, as
remote support is always built into gdb. The relevant sources are now
added to COMMON_SFILES, where they are treated like other ordinary
sources.
ChangeLog
2017-11-22 Tom Tromey <tom@tromey.com>
* Makefile.in (REMOTE_OBS): Remove.
(SFILES): Remove remote sources.
(COMMON_SFILES): Add remote sources.
(ALLDEPFILES): Remove dcache.c.
Comments
On 11/23/2017 04:01 AM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> I think it'd be even better to get rid of REMOTE_SRCS and fold it into
> Pedro> the common sources.
>
> Pedro> If you want to go ahead and that, then it's pre-approved.
>
> Seems like a good idea. I've appended what I came up with.
Thank you.
>
> I probably won't check these patches in until next week, in case they
> break the build somehow. Like much of the US I'm not really around
> right now.
>
Have fun! :-)
Thanks,
Pedro Alves
@@ -1,3 +1,10 @@
+2017-11-22 Tom Tromey <tom@tromey.com>
+
+ * Makefile.in (REMOTE_OBS): Remove.
+ (SFILES): Remove remote sources.
+ (COMMON_SFILES): Add remote sources.
+ (ALLDEPFILES): Remove dcache.c.
+
2017-11-21 Tom Tromey <tom@tromey.com>
* Makefile.in (SUBDIR_TARGET_SRCS, SUBDIR_TARGET_OBS): New
@@ -619,20 +619,6 @@ XMLFILES = \
# See configure.ac.
SER_HARDWIRE = @SER_HARDWIRE@
-# The `remote' debugging target is supported for most architectures,
-# but not all (e.g. 960)
-REMOTE_OBS = \
- ax-gdb.o \
- ax-general.o \
- ctf.o \
- dcache.o \
- remote.o \
- remote-fileio.o \
- remote-notif.o \
- tracefile.o \
- tracefile-tfile.o \
- tracepoint.o
-
# This is remote-sim.o if a simulator is to be linked in.
SIM_OBS = @SIM_OBS@
@@ -926,6 +912,8 @@ COMMON_SFILES = \
arch-utils.c \
auto-load.c \
auxv.c \
+ ax-gdb.c \
+ ax-general.c \
bcache.c \
bfd-target.c \
block.c \
@@ -955,10 +943,12 @@ COMMON_SFILES = \
cp-namespace.c \
cp-support.c \
cp-valprint.c \
+ ctf.c \
d-lang.c \
d-namespace.c \
d-valprint.c \
dbxread.c \
+ dcache.c \
debug.c \
demangle.c \
dictionary.c \
@@ -1053,6 +1043,9 @@ COMMON_SFILES = \
regcache.c \
reggroups.c \
registry.c \
+ remote.c \
+ remote-fileio.c \
+ remote-notif.c \
reverse.c \
rust-lang.c \
selftest-arch.c \
@@ -1078,6 +1071,9 @@ COMMON_SFILES = \
thread-fsm.c \
tid-parse.c \
top.c \
+ tracefile.c \
+ tracefile-tfile.c \
+ tracepoint.c \
trad-frame.c \
tramp-frame.c \
target-float.c \
@@ -1100,11 +1096,8 @@ COMMON_SFILES = \
SFILES = \
ada-exp.y \
arch/i386.c \
- ax-gdb.c \
- ax-general.c \
c-exp.y \
cp-name-parser.y \
- ctf.c \
d-exp.y \
dtrace-probe.c \
elfread.c \
@@ -1115,9 +1108,6 @@ SFILES = \
m2-exp.y \
p-exp.y \
proc-service.list \
- remote.c \
- remote-fileio.c \
- remote-notif.c \
rust-exp.y \
ser-base.c \
ser-unix.c \
@@ -1125,7 +1115,6 @@ SFILES = \
stap-probe.c \
stub-termcap.c \
symfile-mem.c \
- tracepoint.c \
ui-file.h \
common/agent.c \
common/btrace-common.c \
@@ -2237,8 +2226,6 @@ ALLDEPFILES = \
bsd-kvm.c \
bsd-uthread.c \
darwin-nat.c \
- dcache.c \
- dcache.c \
dicos-tdep.c \
exec.c \
fbsd-nat.c \