Message ID | a6ce31ba-d802-653a-c7bf-cfd162d4053b@ericsson.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 99748 invoked by alias); 17 Nov 2017 16:54:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 99406 invoked by uid 89); 17 Nov 2017 16:54:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KB_WAM_FROM_NAME_SINGLEWORD autolearn=ham version=3.3.2 spammy= X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 17 Nov 2017 16:54:55 +0000 Received: from ESESSHC021.ericsson.se (Unknown_Domain [153.88.183.81]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id 2A.28.09556.D541F0A5; Fri, 17 Nov 2017 17:54:53 +0100 (CET) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.81) with Microsoft SMTP Server (TLS) id 14.3.352.0; Fri, 17 Nov 2017 17:54:52 +0100 Received: from [142.133.48.38] (192.75.88.130) by DB4PR07MB313.eurprd07.prod.outlook.com (2a01:111:e400:982f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.20.239.4; Fri, 17 Nov 2017 16:54:50 +0000 Subject: Re: [PATCH] [testsuite] Pass -lpthread in libs To: Yao Qi <qiyaoltc@gmail.com>, <gdb-patches@sourceware.org> References: <1510932166-11816-1-git-send-email-yao.qi@linaro.org> From: Simon Marchi <simon.marchi@ericsson.com> Message-ID: <a6ce31ba-d802-653a-c7bf-cfd162d4053b@ericsson.com> Date: Fri, 17 Nov 2017 11:54:38 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1510932166-11816-1-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CO1PR15CA0060.namprd15.prod.outlook.com (2603:10b6:101:1f::28) To DB4PR07MB313.eurprd07.prod.outlook.com (2a01:111:e400:982f::13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7fd755b5-858a-4df0-59fd-08d52ddbeb45 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603258); SRVR:DB4PR07MB313; X-Microsoft-Exchange-Diagnostics: 1; DB4PR07MB313; 3:QZkIGHTR8ndrljl2M02Au1T1r8DuX/5cEgisr0BsI5yw0NuuGKZ+u81nRTKAo0dGbHWjWNdiBHKXcplN+NnLZ+Ew39j9far+UCYCm6xuZn8LpgWOgQqFWgPebhV7TkQLo7xwtl5em2JPWbNLHtKwE+gKg7Jmg9JxnfBLd1I6iTRxcgdaI9OLYILbd5RpfshFlXDqJZhGPCVkncL136QA5xiBch7F9Wr4gXThSfwsm8CKc15fsqneCeH+68v6Rr6H; 25:z53jgdAusSqe/Wazm70MmF77gACYZEbJgsJ6y5cECrfbAYjU4GEPwps5vCz/YWjL6N4mBcMlK3ELa/liyNMslIqLXPZexZuDfJrjNv05wptzIKDLlS2bh5Nrz1fiUP0aDAKtXIKbgFCG+5MCo2gURiygjbk2kw1QwPmAkQFmFTsUYIgVdwuJJzgHyFPRz5EbECg+uc4mEgK1en0lmInc8Rqw4yMhwK324t3A+hVNw+oJusIhdY/K/n5Q6Jxbkxptvr0XdptDA8PxO0SMIJ1WqxERei/+avmgsFuItHluJgrrVjxhR5RQXQd2flL5OzjsA6AZh3oACdGxVPlWmHsIGtF8ofpmckydN8cVK1eDNZw=; 31:SUQfGNi9czPJkXyXuFR2+p9kPfZMRMMHJTlpU+g79nYzHUZSKkuUR6q5VRvcATz1XZkXCb0qr6Rvy6cpQLC9hKa5ods0nh9lY/CNkyTxe8ArWrBezZVm187Tjatw9ROETLUfjRO2B5ZwezBo0qZipUXLcbM7bKvKq0kEYsHzWV8k25KNjvQiUziK4iovZWlUmcNiyg6U9LGe6hRBXuMoPuTMCgjlecnWJ7+YinJI0ek= X-MS-TrafficTypeDiagnostic: DB4PR07MB313: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; X-Microsoft-Exchange-Diagnostics: 1; DB4PR07MB313; 20:J+d/MQ8DppR4QyxGp1eC+jS+O3FUdmibOCEuSShj1bLp0XzRhUwbUeUQnje2y5/FxJqOLxIx5L5KVRi4fbbyP+Hw84tVuAYewPMu/xKgLZNGAZddGziH7mLWZWi5lDQ9gk74VRYS00e0d3/j5KzHDamInjJiz++KsszXdwjFP9S5m9HY3zQkI4bQvQksvFC1ru9HFFR5Pr77sLDhSNFu8BL0Rhwu4QkgxPFllXi9EwMzzJnh6eLcNfDZS+rjd2LhELbsVzUBsFta987OspZhcMJEUomA7iZ0SVTPYVD82xeQet0vWTd+VZaGv2G6yBXpA4h6aTlqLarQEhJmZ5AtFWbhMI/CtFpYF8DSXZXv6JinM/oePlAqdlioUUvjA+q4Qu3KMKvDNgUWnvqQ7p0CaT0+Hewio7+Km5vswYxFLK3AYOZI9sXWRGzCiY3DOhTX57k4Voui3GsRdJmWEAd1hGUaalNyXdZ8Dc8L/CyUBD6IRZPRtSK/vM2I4ZrAIr8h; 4:wU/rE1mHlidn1CdDFxtQifNjY0SuaumOrS6TPqqhqu9Qa9aUeKDG2ogZz0I2g5T0CIK5lSuQ91kJZGAnnwhJGc216YXBb+7l6qpBJKrK/cTwbD9JiMmDjS6g1nCeG4aA+k/jwOb6XjH9ovJ8xbUsPmmBfiCgd3X+nRQ0IBYXS7E0iia0R1EMxWLPoPwBUEEkXGo6VDNtiZ+GM01e3bbPF6JgFmspaWfnorIiL36g0S/UJKuYgycXiHXbOkWiBDRm6fs5iCXowxqBiC7AJGZ0+A== X-Microsoft-Antispam-PRVS: <DB4PR07MB313B39859C121EB989C9F51ED2F0@DB4PR07MB313.eurprd07.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(3231022)(93006095)(93001095)(3002001)(100000703101)(100105400095)(6041248)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123558100)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DB4PR07MB313; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DB4PR07MB313; X-Forefront-PRVS: 049486C505 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(6009001)(346002)(39860400002)(376002)(24454002)(377424004)(189002)(199003)(36756003)(5660300001)(230700001)(6486002)(47776003)(6116002)(101416001)(68736007)(25786009)(64126003)(4001150100001)(50466002)(16526018)(23676003)(31696002)(66066001)(31686004)(3846002)(65956001)(83506002)(5890100001)(97736004)(65806001)(39060400002)(81156014)(58126008)(6666003)(229853002)(16576012)(316002)(2950100002)(7736002)(189998001)(81166006)(86362001)(49976008)(33646002)(305945005)(8676002)(53936002)(65826007)(2906002)(50986999)(8936002)(478600001)(6246003)(53546010)(76176999)(105586002)(106356001)(54356999)(78286006); DIR:OUT; SFP:1101; SCL:1; SRVR:DB4PR07MB313; H:[142.133.48.38]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjRQUjA3TUIzMTM7MjM6VFRHa3kwU05kK3ZlRFpkayttRk1sUFhqQlFZ?= =?utf-8?B?VFQ3NXVXRFQ3aEltRjlqV0tKZXpNTm5xL3d2SEgzN3JMM2syeFVydW9BcDNK?= =?utf-8?B?Z0RGMXh0N1EzaE83aVZSdCs4M1NxR1puZ2x6MDBLbm5ZZW4xWmN3dHJSaXNx?= =?utf-8?B?VkFpZnNWWFNkV3I1aTZQbnlCZW1QS21YUGFERkxTdi9ldEdveHJYYjZzNWt5?= =?utf-8?B?aXA2L3psMGlzcTNNZWtGSHlBTVg2blpiWWluZ1M3cnF4Ykp3V1N6VXFZVEtW?= =?utf-8?B?MUJ0Q1o4dmMvZFhkbFlGL01UellUbVZ0QTZrRFBreXJMU0pkNWZaWkZUS3BS?= =?utf-8?B?NUZvQjVkcmh2UnYwaVJQVFBqbG9lekdTMlNkaXAxLzZScHh0VmRQMG56cHMy?= =?utf-8?B?aEtRamttYkhnY1l4WkRNbVJkR0pHekQzaG5uWllkempTZGovTG1RaWFZWVRJ?= =?utf-8?B?cjhSMGltSVI4SjVWc1VoekdhVmYydVpJRUJjU3pzRTVmWnh5L2QvUlkyWTdu?= =?utf-8?B?cmM4ZERhT21GaTdIazRFRXB6RU9mN1dTT05OMnJSTm5ZRmpEck5wS0JlMXdU?= =?utf-8?B?VW5QdmVsbmtrSU5DZ0krUDFlNG1XTmRySXJKcFlDZWRrYzJNaTlqN1lXNUhS?= =?utf-8?B?RDllcXN3eU9LRFdiTWpNNCtrOXdzeDBtY00wbGxBemwwdis2WkZkZ0FLYmlQ?= =?utf-8?B?dXZQRHZzSThnczVRaEo4MnJ6YnlKTnR0WjYySGM5cytCbWkvNFdWKzFEaXlz?= =?utf-8?B?cC9sbmR5RWI1aEJ0dWpnSGt2ZlFSdm5NMytEVGNOMml5K05aYm5qWDdpWXZj?= =?utf-8?B?eExPdlRwTENhTVJsbUs5czgxZERhWGJCUUxiNVhRWnY1OU9qV3lrR0h2L1NE?= =?utf-8?B?YlBKczg2UnlRRkYrbmhDaWNYc0pLY1pDTVpSZWVRaGQ0UnFTQ01MRmxPZWkx?= =?utf-8?B?My9EVGtzaEkwNzB3SDgrSWhQdHh4WXhzamlWZTR5aitJcWJaSlVXRUY3aFUy?= =?utf-8?B?b3VUdnY2cmZEelZQYStUdTA3MFgwdzJ5OHhaYjk0Qitld29GeFoxTVM0TUJ6?= =?utf-8?B?dEQzaUFaZkwwU0hTbFVvL0FUMWJVWVZYQ0d5SGR2SGdxdFdPcUZGRjlOeG8v?= =?utf-8?B?eHJtdUtBSUxQWm90VTNhaFZ6cm1wR1hpT3ppWUVUSXp0REdjU0ZzU054WnpH?= =?utf-8?B?aDZHb1BjTVNEQ09YdnQrQmtNSHVCR2R3NDg4cXloa0o4YmRmNll1T0JVblR2?= =?utf-8?B?UGhnVmt4Mk5ONkFyQWUvTVRDd05hbFMrcVdjSHZVSHZmd1hsYm1QYStVb3l2?= =?utf-8?B?QkhTVlEzR2tPai9yTmRRRlpJWUZXNjc0UHNJRTI1YmdablVmQlRFZTVlclZm?= =?utf-8?B?QUFwbmRzeENBTTRYSllxUDdUOGc5ZjMrbFVvOWJHcHgwMWVjdS8rV21hSVpE?= =?utf-8?B?Zmo3ZHFEejNDY1dFY0hjbkZiTFQ0Tmsya0ZRYmJ0dVduNlVVdCt0WnBCNEwr?= =?utf-8?B?WThCOUZEVkRFOS9iQTJvcGRZOFN5Tk9DTHdXWWxlZWRLQ2RiaDNNdDZDWENU?= =?utf-8?B?dW5OS2dkR3hpdHJLZTNsTmRjU1BpcUlFaHRiME4xRGI2TFZCQlBxTTNWbFBF?= =?utf-8?B?SmZUYW02ZlBEa3dvRlAzWDBQRWVQSVVYU2gva1ZFTUhXdkhJUzMycVNtaFli?= =?utf-8?B?N0ZKSWhXLzlhL1NHZWkvRTVNSkxDWnhLNXhvWHpQWHMyWVJwWkl2SXVWZExZ?= =?utf-8?B?Qld4VlJuNHdDRVdtbFNmRjZ1NHprSUdnTERydVJYQm9LR3Q3RWZtbWN0YWdh?= =?utf-8?B?ZFhPeWZQYlRGQUlVT21OUnBPSktJZEZZVUlxTTZtMGllMWxEdXBWQUk5UEVj?= =?utf-8?B?WEJ0QVZJazdEL1JzemVOODdQM0VGOHZQa3lEVSs0akcxWVZxdFdaclM2aUs5?= =?utf-8?Q?aoNoVF4OnuQ50wILdd8RZN8nfDRgA=3D?= X-Microsoft-Exchange-Diagnostics: 1; DB4PR07MB313; 6:VFCdujnff83Lhs8F+xNxQ98MheLsCKSaU1NBX0Pvd6HvViijQ2ftAcAXUb/EkPf4/Rg/2KJ0jrmWrVHvUqvgPlHd5tFRJ5pS1ncr+JURdFT/8RPjMUq1hufirutnIVJAjTjpYV+o/X0wpOypTJejJ/osJ2l8TFhJTMA31nZMVXMaUQdtmJ/io7vB2N+oD7sc8bBOThJvQB41cx30ghp6BZVMC8p1U4rK261yoJw01FduCWtIkMEQjvsmasnB2xuK+k2JieZrJBY68xe680SxphuuxrJSyf1flzLZOHjiQR/1NGsHJMRJrelWR5T6fm0Pw8mDPC/4yToQs6VbdozUWhYBRps4dkS1PE7YvjcAx4Q=; 5:53lBaRYhSu2UTLpFSyERW5SfBdc567AWGAEphXkQSLio9c0lvQ935K+UXPMELZQKtqlfauv8Wh5StjKgVSMMbioAfmtQtGWoQrZYJb7Uxuwm/He1LCaVhmyLtWWh60WnP4/ISWdZ9wzVxNjZjCJw9sg+wJk5mD3zNIl5ejWlong=; 24:iML763+mxJy5TqQqMjW2k2c/VHuQ0lYiAL5JfSIb58V2nmMfDuRw4ypgxHcgJZzLPuEAP0UMXpWV266+axmE3/UHLzFvsN5jSbUYFYNdFYI=; 7:G7yJdBUjJ95FAqUsjL+G0evdWQDJ+6mFS+Lm4JdIC1R93xoOKGHzVdGZ6ST9zQrljDthLWrNJzZH5F6nCvebsNwA/jxIGh1gL0pm55CAnUTmlhJimZa4OYTEQB/ZjMi3F3pgUnLcpwIhH3k+P+2QF87c4LvCNZRwJpKC4DfmxLdPg0ouw22WjM1igzYh3kVLcuQqB+grKV+m4mDPdBqS0vkAtdc//dA6RxZv/j6tFxv9i0W3Bx9OruBsKcLw1m/j SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2017 16:54:50.2634 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7fd755b5-858a-4df0-59fd-08d52ddbeb45 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR07MB313 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes |
Commit Message
Simon Marchi
Nov. 17, 2017, 4:54 p.m. UTC
On 2017-11-17 10:22 AM, Yao Qi wrote: > "libs" is the right flag to pass a library to a linker, instead of > additional_flags. Without this patch, the test case can't be complied > by clang. > > gdb compile failed, clang: warning: -lpthread: 'linker' input unused > > gdb/testsuite: > > 2017-11-17 Yao Qi <yao.qi@linaro.org> > > * gdb.base/info-os.exp: Pass -lpthread in libs. > * gdb.multi/multi-attach.exp: Likewise. > --- > gdb/testsuite/gdb.base/info-os.exp | 2 +- > gdb/testsuite/gdb.multi/multi-attach.exp | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdb/testsuite/gdb.base/info-os.exp b/gdb/testsuite/gdb.base/info-os.exp > index 574da26..b3109e1 100644 > --- a/gdb/testsuite/gdb.base/info-os.exp > +++ b/gdb/testsuite/gdb.base/info-os.exp > @@ -28,7 +28,7 @@ if [gdb_skip_xml_test] then { > } > > # Compile test program. > -if { [prepare_for_testing "failed to prepare" $testfile $srcfile {debug additional_flags=-lpthread}] } { > +if { [prepare_for_testing "failed to prepare" $testfile $srcfile {debug libs=-lpthread}] } { > fail "cannot compile test program" > return -1 > } > diff --git a/gdb/testsuite/gdb.multi/multi-attach.exp b/gdb/testsuite/gdb.multi/multi-attach.exp > index 9397f85..52acc91 100644 > --- a/gdb/testsuite/gdb.multi/multi-attach.exp > +++ b/gdb/testsuite/gdb.multi/multi-attach.exp > @@ -23,7 +23,7 @@ if {![can_spawn_for_attach]} { > return 0 > } > > -if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug additional_flags=-lpthread}]} { > +if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug libs=-lpthread}]} { > return -1 > } > > Hi Yao, I am seeing: gdb compile failed, .../info-os.c:51:1: warning: control reaches end of non-void function [-Wreturn-type] with clang-6.0. Once I fix it, the test passes for me. Instead of passing -lpthread directly, it would probably be better to pass the "pthreads" option, like this: build_executable_from_specs eventually converts that into a call to gdb_compile_pthreads, which then chooses the right linker flag based on the platform. So it's a bit more portable. Simon
diff --git a/gdb/testsuite/gdb.base/info-os.exp b/gdb/testsuite/gdb.base/info-os.exp index 574da26..3267eec 100644 --- a/gdb/testsuite/gdb.base/info-os.exp +++ b/gdb/testsuite/gdb.base/info-os.exp @@ -28,7 +28,7 @@ if [gdb_skip_xml_test] then { } # Compile test program. -if { [prepare_for_testing "failed to prepare" $testfile $srcfile {debug additional_flags=-lpthread}] } { +if { [prepare_for_testing "failed to prepare" $testfile $srcfile {debug pthreads}] } { fail "cannot compile test program" return -1 }