diff mbox

[pushed] common-utils-selftests.c: Add ATTRIBUTE_PRINTF

Message ID 1509161886-9902-1-git-send-email-simon.marchi@ericsson.com
State New, archived
Headers

Commit Message

Simon Marchi Oct. 28, 2017, 3:38 a.m. UTC 
  Fix this, when building with clang:

/home/emaisin/src/binutils-gdb/gdb/unittests/common-utils-selftests.c:50:40: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
  std::string result = string_vprintf (fmt, vp);
                                       ^~~
gdb/ChangeLog:

	* unittests/common-utils-selftests.c (format): Add
	ATTRIBUTE_PRINTF.
---
 gdb/ChangeLog                          | 5 +++++
 gdb/unittests/common-utils-selftests.c | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)
diff mbox

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 51e3422..9fe6329 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@ 
+2017-10-27  Simon Marchi  <simon.marchi@ericsson.com>
+
+	* unittests/common-utils-selftests.c (format): Add
+	ATTRIBUTE_PRINTF.
+
 2017-10-27  Simon Marchi  <simon.marchi@polymtl.ca>
 
 	* xml-syscall.c (struct syscall_desc): Add constructor.
diff --git a/gdb/unittests/common-utils-selftests.c b/gdb/unittests/common-utils-selftests.c
index 0f26b21..c48904b 100644
--- a/gdb/unittests/common-utils-selftests.c
+++ b/gdb/unittests/common-utils-selftests.c
@@ -41,7 +41,7 @@  string_printf_tests ()
   SELF_CHECK (string_printf ("%s", X100000) == X100000);
 }
 
-static std::string
+static std::string ATTRIBUTE_PRINTF (1, 2)
 format (const char *fmt, ...)
 {
   va_list vp;