Message ID | 1507987729-6984-1-git-send-email-simon.marchi@ericsson.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 27061 invoked by alias); 14 Oct 2017 13:29:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 27039 invoked by uid 89); 14 Oct 2017 13:29:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 14 Oct 2017 13:29:04 +0000 Received: from ESESSHC020.ericsson.se (Unknown_Domain [153.88.183.78]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id 9B.E4.07039.E1112E95; Sat, 14 Oct 2017 15:29:02 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.78) with Microsoft SMTP Server (TLS) id 14.3.352.0; Sat, 14 Oct 2017 15:29:01 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from elxacz23q12.lan (192.222.251.162) by AMSPR07MB312.eurprd07.prod.outlook.com (2a01:111:e400:802f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.5; Sat, 14 Oct 2017 13:28:59 +0000 From: Simon Marchi <simon.marchi@ericsson.com> To: <gdb-patches@sourceware.org> CC: Simon Marchi <simon.marchi@ericsson.com> Subject: [pushed] Fix build failure in linux-osdata.c Date: Sat, 14 Oct 2017 09:28:49 -0400 Message-ID: <1507987729-6984-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BN6PR2201CA0009.namprd22.prod.outlook.com (2603:10b6:405:5e::22) To AMSPR07MB312.eurprd07.prod.outlook.com (2a01:111:e400:802f::24) X-MS-Office365-Filtering-Correlation-Id: 2c0c104d-8678-4a43-dbef-08d51307878d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:AMSPR07MB312; X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB312; 3:BBlahECcRUmGOcubaA6X8WhsSVbg0+nMPKmjWHhnLKVHCAYo9W8iCeETp9OsEn6z/h7Qqp215BcYTAFIgVkDXvRvGPm+APWAx86CWb9Jcrw4hNQfvZWYOJ6UlFZ3hWqCqU4akK2e7/2qnMuPI6LWEkPIZk7Q1wxjyQI4Qs/0JF/hGB5zRxeka0DNThMaTEV7y//rBcDYoxbk9GAIkt0VvfIthgnp1NissRt6sEJa64t7J6LW1Ih83TNh9+vI2gdk; 25:mtjmo2jmJiMZI/jajZNCkilRNAf09SSY74mPDvVGk1VqmImxYsLkhZmSyzD+cSDCwMmNcdXi+38f85NHWY0mnh7GWUQJIoCdoZriqgxi80u0oMP84pcsKtGUd0QaHEi5oqa+dnXDkEyEk26LAMwwuUnV+AOJqm7Z75mXw6DjPI6LRjeWMXUbNAq0CI4jiXRq+eB+cYP7RMoAsljcqUyG5NPe6bdNHMG2bCFRxXc/gcCKFfiF84OZ7YuS3OzmqmBZzIAFM2CuNLT4+LT+yYe5ISZapFHpMWcYr0Kn20x9yqbH/+v1cL+HF7iDS63kEP8/7wHPubVONlAH0zhmjB5En6PAPM15vtVWeH/LYZaM5/M=; 31:PqVK00Z5l2nNpvJ0mdOysBxlJjND9NP4ZukCKSxHGVU9I+SRC2eHR7EM7CDj6M6BWkV13P5shEtHRrCY9n/OATs1yZEleXK1GpI18m2ybDuuXLlNHRMHuINeRaCGcyvzCPbkkM0n0B/DnjVd5rDZPKrpD+q75MDXwsM8IWbcW/w6Wy5+PwUxzUfaCNRPWNJ0QUENfXYTWwRtLsUVop4APmBxFcck4z6vpNfu2+KGuGM= X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMSPR07MB312: X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB312; 20:NucbePWkAnhIJLvKgTVFbH6hVINZb609SaDP6k4+H5gYoZp3i01d+Odt9Yg5zeyaaoHpKg0fPQSc+X0yazGZFJzpeaQf1mPf2WYPabP+1CFAiTbOF7dvnym9mVlRCKInfBA/jABvLdOtszgBq7YaumWNfOu6uUork+BpZLZ3IWHy+lWqwGu/8wwo+u3Sl0yW53kpHBnqOlLUZrIGq1kfqzbkvqHMM0QPOuMlxY3VYcOEve1f4tjEC4nQMFF5CwXqk3uFe53Qw57ZYwWDAWHJyQPbPt2fj/8Xc5QD9zYlTZTdFgJ6mBQXkiCBabx8597D+yqJRBwa1vHUq2oebgnOn5GhWG9RVKBnxISVkM2/JIdIo3jhsisFbFzAzC4pRqM0oo4ia3/fenI9vAQCI1rU4iyFm0rKKoG6qq8+Sa/D6RRNCydWRPuaIqhd8E+9xIz4OYUZ3SVMVX8Hmu/VuvZeNDTVDsuXCSt9jttLx8Sww5xEz1wgB3v3gyTtU++MjOSr; 4:URxjAZErJDwxW3PyVm2YDeFPXVYGejiZC5QAIvouqp23ZomYk7TTGmy93GcDmlpfQJGwHWhty2P++j3ewnctBuwwNBz6wN5QnYRflxgV5hadG9J89KidNRgXN6I52xfV+izNUlu9ETz6qALLDBHsrBvnQJmTRfZ+z1HheXrOP3YFKjP0Sb92XDLm8ri2MuB04Y0MVcE0tozJG7eysa5bojJzMtePn1dWC2kbOxQrRRolIU21TuCW9aZsL95NevLWuf8aj1clny7cr5O82T0otGkCUWgR+k9X/KMxhkpx3So= X-Exchange-Antispam-Report-Test: UriScan:(37575265505322); X-Microsoft-Antispam-PRVS: <AMSPR07MB3129049AB48B8DF13FC1EF0ED490@AMSPR07MB312.eurprd07.prod.outlook.com> X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(100000703101)(100105400095)(6041248)(20161123564025)(20161123560025)(20161123555025)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AMSPR07MB312; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AMSPR07MB312; X-Forefront-PRVS: 046060344D X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(199003)(377424004)(189002)(54534003)(6512007)(4001150100001)(53936002)(33646002)(5660300001)(4326008)(101416001)(2361001)(189998001)(2351001)(107886003)(50986999)(106356001)(105586002)(8936002)(50226002)(50466002)(81166006)(23676002)(36756003)(8676002)(21086003)(81156014)(6916009)(47776003)(69596002)(7736002)(305945005)(25786009)(2906002)(2870700001)(66066001)(97736004)(86362001)(6666003)(68736007)(6506006)(6486002)(316002)(478600001)(16526018)(3846002)(6116002); DIR:OUT; SFP:1101; SCL:1; SRVR:AMSPR07MB312; H:elxacz23q12.lan; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTVNQUjA3TUIzMTI7MjM6MjJwZ3Z1dHN5YytsUkx5RzBQR2FKUkIwb0N4?= =?utf-8?B?WWxNUkwrV3hmdjhUN2NUcjVpeWRGeHJOTUhuZS85Zk1ObFpKRnBHcTlzUGxL?= =?utf-8?B?QVBwaTdpcXNrTk9kZUI5Mm9kc0VUTmllemlvYzRGWDdYaFA1R2w4RWpCQzBK?= =?utf-8?B?Q1ZubERSODBFSjIvWXNHaTcwUEg3THlqTUhXakVkRmg0NjY4WGphT0MyWDFU?= =?utf-8?B?MWF1TTYya1hFOUFuZ3FkU2tmZ1o4NGVEeHQyd3o5V09nS2NXSHl6cXg4QkVQ?= =?utf-8?B?VnA2eENqZzdad0p4OUJXM0dINTRGS3c3emhZaXRsVVdZb1J4U2FIODFIVXE5?= =?utf-8?B?MmFWcTduOGs0Yk9ZOXViRFFWempvbWdBclBwSkNMa1UwSXh4L0srM0xhNVBR?= =?utf-8?B?WU1lK0FwWThsSVdlVnZpMkxReXlFMWJlODdaOFlYaWFQT2trQkdRdGNVZmJU?= =?utf-8?B?NTEvTnFubWR4RlBjRnhrWDgwVURhR3Fwd1RHUFBmd1doaDZPWTdZc0VJUG5C?= =?utf-8?B?V3FwWlczQ1RMZnFraEhoblVNT0x4NklPKzI2NXJ4czdFWTZ0dE9Zclc5Q2Ry?= =?utf-8?B?R05DNzA5OXVzZUJ1aHpnNS92dlYrV3R3dmVJREpEekh4enRaNXNMN1pGU1Bw?= =?utf-8?B?QnFVUDFyR2p4aDRFc3IvUmJLN2dJTXl5VFFDWjhWbmxYczBGa1AvaHh6Q3Ju?= =?utf-8?B?aWpNUUVPajF0S3VuUEZYY3lPaEFLSzJUK0NkTjRuck93OWVvRWY1R1hIV0ZL?= =?utf-8?B?Lzl1ajhQVjhDT0Z4dVRZd3VudEVtVW92Mmx6VU5qa1VpOFFHRzZ0RkhQcVhu?= =?utf-8?B?R2t6Q1FCVzhaa2VFU3FCYkJvcmlWM0Joa3UzYXU3MGYzMDhJaXZ4a1Z2WUFN?= =?utf-8?B?eTdTSjZHYjl3M3pkVTdYOXZzUW9GbDBTWlJwRFJHSW0yZGU1alk3ci9GTmk4?= =?utf-8?B?cnd0NklvbGpJNjZVMFFvU21WN3NDb2c0N3JETXdqZ2crSHcrSzU5VFZxSENR?= =?utf-8?B?Y2dqYWltbE1XNnpmeUVVVTkrNEJJZm9oS09Lb1M2NGxaUUd3UmNGZGU5c3hu?= =?utf-8?B?eTE1UU81aGdFdkoxc3BISHV0bW5xYnRNVUdTUjlwbmQ3Q3l1ZEJjRURrYlI3?= =?utf-8?B?azZwb1d2TUVqZjZtZXpBRWxQQ2hEalY3M2FNc0ZIVzlackxJSnc5aVgwV3dt?= =?utf-8?B?S1lQQ2UyMU1PTEZvOVcwMkIwOTY4c3BibnpmNmRTOVNGYWJxUVNvcFlsMlpu?= =?utf-8?B?ZFVGWnpZUWZzVDNzRENLRzdEdmV3R3N3ZVgySUFFb3JjbXdiK29iS0FTRnZL?= =?utf-8?B?cC9pbTQ3RERjeW0yN1dSVHFQTTRHZ0dtUVI4QUxuM1l4N3hIQ2lXY3cwcnpt?= =?utf-8?B?bGhnOVFUQjNCNjlZcDU3eVJLL3lmcldzMG94Mk9WUVM1bE90UStrYnk2RlNU?= =?utf-8?B?WGdiZU9uSzFWZnhIZHBtK0JzSVFLZGpVMEc1QzlWL0xsS1ZMaDVPOFYxUU1r?= =?utf-8?B?NWtmT0ZmaTgwenR3MFU3bkpTSlJJSHVwNEkyd2RQeGhOOWo0cCtOUG1RVkF4?= =?utf-8?B?Rm1aT2RqYVEyVFh5WjNURDR5dUg4UT09?= X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB312; 6:eq17uSeYJO6yqtt6Jhr3nsajlg8PC9Yw/OKLChR7Z6wLl2JZGfC7iNwGsnqNaV1xgpo0DDXQKnQnUNi5vJeZkMKbrCltSu/n0qyEDqcWIasz6EXxQtDJIWEnSTjCfpSSIWKd8ogXMK/JWbQCMpTu8sECVrLnFdK5Hw/YdnLGPdNqN2dDiKjy5iSW4caD1lECn4+iO7KdMSIReFQeiboATKGQcZrNdrOk1JZGJbsKG372o0CK1nL5tyKVvpACK5wgMtvdWbCEv/yl6NB4mMp/yfiptNGwExGhSBh/lqOMXmEBkXs+4yVGm9ehmYYiWuHBmhsFXfGbMOBHZawVxfAvcA==; 5:ZLa7excQVwfBUuGduWwggw8nfb2km1FcgyjNJ3D78adnv6F/h/vKEov83+JJS8a9Q3GnryEckPikrcRhaSeR22Dr2o94EyXgUauePMP9Xk17Ue9jy/aLXTUQbsHQ7vt2CsZo6hOd5xf93TE1xNWUqQ==; 24:aI4y5JcSU33FnKQIO+dx8J+lI0ozC7YeiZiUcQ0w+SWF3O1WG+LMIo16w5CbGv3WnTaO/VNSZ62t1cPsOV6ohOC63yHjBOhiMT7aY4GDZdY=; 7:nvje9Pxoz9FECOmY9rgmVJ76m8n+yhBboxuTYw0kC2ID9SGbQWxfVegFiHsuZEVc+1MP9SNvNtVEQqxPLEnFUK3n8KcKkF1QAiDpR3EoUUnQMOr0pxxPuC6+hltmPAo6dhhhVfRpufmnhEjiQI0mmR6FV80ELYH33i8HR03q4/GGxhIPcXnBu2xd41Ck87y7b1MULpZ7GZbBjwIJuTlPPHvyif9q+5FLGOBie1KYhj4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2017 13:28:59.8026 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR07MB312 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes |
Commit Message
Simon Marchi
Oct. 14, 2017, 1:28 p.m. UTC
Commit Use std::vector in linux_xfer_osdata_processgroups b129dcac882da87767cb863ad8b2572f90e9e5bc broke the build with older gcc (at least 4.7 and 4.8): In file included from /usr/include/c++/4.7/algorithm:63:0, from /home/emaisin/src/binutils-gdb/gdb/nat/linux-osdata.c:40: /usr/include/c++/4.7/bits/stl_algo.h: In instantiation of ‘_RandomAccessIterator std::__unguarded_partition(_RandomAccessIterator, _RandomAccessIterator, const _Tp&) [with _RandomAccessIterator = __gnu_cxx::__normal_iterator<pid_pgid_entry*, std::vector<pid_pgid_entry> >; _Tp = pid_pgid_entry]’: /usr/include/c++/4.7/bits/stl_algo.h:2315:70: required from ‘_RandomAccessIterator std::__unguarded_partition_pivot(_RandomAccessIterator, _RandomAccessIterator) [with _RandomAccessIterator = __gnu_cxx::__normal_iterator<pid_pgid_entry*, std::vector<pid_pgid_entry> >]’ /usr/include/c++/4.7/bits/stl_algo.h:2347:54: required from ‘void std::__introsort_loop(_RandomAccessIterator, _RandomAccessIterator, _Size) [with _RandomAccessIterator = __gnu_cxx::__normal_iterator<pid_pgid_entry*, std::vector<pid_pgid_entry> >; _Size = long int]’ /usr/include/c++/4.7/bits/stl_algo.h:5483:4: required from ‘void std::sort(_RAIter, _RAIter) [with _RAIter = __gnu_cxx::__normal_iterator<pid_pgid_entry*, std::vector<pid_pgid_entry> >]’ /home/emaisin/src/binutils-gdb/gdb/nat/linux-osdata.c:480:57: required from here /usr/include/c++/4.7/bits/stl_algo.h:2277:4: error: passing ‘const pid_pgid_entry’ as ‘this’ argument of ‘bool pid_pgid_entry::operator<(const pid_pgid_entry&)’ discards qualifiers [-fpermissive] Making the operator< method const fixes it. gdb/ChangeLog: * nat/linux-osdata.c (struct pid_pgid_entry) <operator<>: Make const. --- gdb/ChangeLog | 5 +++++ gdb/nat/linux-osdata.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index af22deb..25ae470 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2017-10-14 Simon Marchi <simon.marchi@ericsson.com> + + * nat/linux-osdata.c (struct pid_pgid_entry) <operator<>: Make + const. + 2017-10-14 Simon Marchi <simon.marchi@polymtl.ca> * target.h: Include tracepoint.h. diff --git a/gdb/nat/linux-osdata.c b/gdb/nat/linux-osdata.c index 5d1a7bd..0980c8d 100644 --- a/gdb/nat/linux-osdata.c +++ b/gdb/nat/linux-osdata.c @@ -407,7 +407,7 @@ struct pid_pgid_entry return pid == pgid; } - bool operator< (const pid_pgid_entry &other) + bool operator< (const pid_pgid_entry &other) const { /* Sort by PGID. */ if (this->pgid != other.pgid)