[RFA,5/8] Constify add_path and friends
Commit Message
This constifies add_path, mod_path, and directory_switch.
gdb/ChangeLog
2017-10-13 Tom Tromey <tom@tromey.com>
* source.c (directory_switch, mod_path, add_path): Constify.
* defs.h (add_path, mod_path, directory_switch): Constify.
* mi/mi-cmd-env.c (env_mod_path): Constify.
---
gdb/ChangeLog | 6 ++++++
gdb/defs.h | 6 +++---
gdb/mi/mi-cmd-env.c | 4 +---
gdb/source.c | 6 +++---
4 files changed, 13 insertions(+), 9 deletions(-)
Comments
Tom Tromey <tom@tromey.com> writes:
> This constifies add_path, mod_path, and directory_switch.
>
> gdb/ChangeLog
> 2017-10-13 Tom Tromey <tom@tromey.com>
>
> * source.c (directory_switch, mod_path, add_path): Constify.
> * defs.h (add_path, mod_path, directory_switch): Constify.
> * mi/mi-cmd-env.c (env_mod_path): Constify.
Looks good to me.
@@ -350,11 +350,11 @@ extern int openp (const char *, int, const char *, int, char **);
extern int source_full_path_of (const char *, char **);
-extern void mod_path (char *, char **);
+extern void mod_path (const char *, char **);
-extern void add_path (char *, char **, int);
+extern void add_path (const char *, char **, int);
-extern void directory_switch (char *, int);
+extern void directory_switch (const char *, int);
extern char *source_path;
@@ -32,8 +32,6 @@
#include "top.h"
#include <sys/stat.h>
-static void env_mod_path (char *dirname, char **which_path);
-
static const char path_var_name[] = "PATH";
static char *orig_path = NULL;
@@ -94,7 +92,7 @@ mi_cmd_env_cd (const char *command, char **argv, int argc)
}
static void
-env_mod_path (char *dirname, char **which_path)
+env_mod_path (const char *dirname, char **which_path)
{
if (dirname == 0 || dirname[0] == '\0')
return;
@@ -444,7 +444,7 @@ directory_command (char *dirname, int from_tty)
This will not be quoted so we must not treat spaces as separators. */
void
-directory_switch (char *dirname, int from_tty)
+directory_switch (const char *dirname, int from_tty)
{
add_path (dirname, &source_path, 0);
}
@@ -452,7 +452,7 @@ directory_switch (char *dirname, int from_tty)
/* Add zero or more directories to the front of an arbitrary path. */
void
-mod_path (char *dirname, char **which_path)
+mod_path (const char *dirname, char **which_path)
{
add_path (dirname, which_path, 1);
}
@@ -464,7 +464,7 @@ mod_path (char *dirname, char **which_path)
as space or tab. */
void
-add_path (char *dirname, char **which_path, int parse_separators)
+add_path (const char *dirname, char **which_path, int parse_separators)
{
char *old = *which_path;
int prefix = 0;